From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16287C43215 for ; Thu, 28 Nov 2019 15:02:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E2B2B217AB for ; Thu, 28 Nov 2019 15:02:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mslmdNSS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726582AbfK1PC0 (ORCPT ); Thu, 28 Nov 2019 10:02:26 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:40712 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726446AbfK1PC0 (ORCPT ); Thu, 28 Nov 2019 10:02:26 -0500 Received: by mail-pg1-f194.google.com with SMTP id e17so13022467pgd.7; Thu, 28 Nov 2019 07:02:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/yK+bP/ZquyDqTbwLOoQFt7m4Vf6MNFvYmMx+oPcx0U=; b=mslmdNSSudE7yrNxVl9gLKm+PW7faAyM+eH7GAB9JmUxunrZ+delEqNm4/4ejVIm5R 6A5ngV7ImLhf+KfUj3ECrYK2CM9yXjTX3V5eI2cMxq+8if3m3CelEq6oXt3EyoWAHau9 2gAH1IOUpTOUyYQ8lI4m/+7Ivw/GDUGd3qiZ3R3pBEz4IN/eQ8tdI/9op3ZUewTeoCd8 tV8D6Hgp1CryCOZsHcgWKckLtcxCEnAjEtlgrDkkBy3CZJh//UQYr3sJp2k/U6Ppla8E Ks9XUiSVHgPIcCpmMxw+IWteo2+p2EWvcNJA7+zoeviWLLedA4ku1VpbfrpkL8xh3fNN eRlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/yK+bP/ZquyDqTbwLOoQFt7m4Vf6MNFvYmMx+oPcx0U=; b=Ep7Z4MOrMxQp5HXaeDCArD8lNMB5XH8F25hXmAHUtoB+grvNAvWmsB3I+5SWr8Gmf7 VtpU+gOaELFiNjxLbtuj3RBN50AZGK6eEgfReqwqOQa7k2OuSN2uIY96ZV9R5jWgXk0D 1Uaj1dluHzU2y9zLUyYj9JKEiQZw2MlTPDG0JdNvprFk9GaP8/wT/Kt2b39fka+/dQ3L pfJERhrg+GWzxNtjv/swXxr4l4twBAzSlH0ZKx8CbeEsyzc3Gj7bdtqylJTHIb+omLBv GU9U9iGjv1HPDSlJx0/HlZVx1Y7tSa7c+aPbnD4UUbTnJEgi8iIuoEp0GF5XSUY512GV j3ZA== X-Gm-Message-State: APjAAAWaNvmSDb/IhEyzrSjx0y5ihJezj4EPUPjbA2Ig/5Yb+k8y+5bz sfxbVVabol8XqsHtB3Hair7ztAnQYxQM3fJgfLQ= X-Google-Smtp-Source: APXvYqzI7Qf+yzT4pAOOBFmdCFGcdvppyFYuVIaWxgTEMPPJrdcAYC6dW5CPkHAinmujdN25OW+CtNH57+kcSY3ry0o= X-Received: by 2002:a65:6118:: with SMTP id z24mr11995545pgu.203.1574953345343; Thu, 28 Nov 2019 07:02:25 -0800 (PST) MIME-Version: 1.0 References: <1574952879-7200-1-git-send-email-akinobu.mita@gmail.com> <1574952879-7200-5-git-send-email-akinobu.mita@gmail.com> In-Reply-To: <1574952879-7200-5-git-send-email-akinobu.mita@gmail.com> From: Andy Shevchenko Date: Thu, 28 Nov 2019 17:02:15 +0200 Message-ID: Subject: Re: [PATCH v2 4/8] platform/x86: intel_menlow: switch to use helpers To: Akinobu Mita Cc: Linux NVMe Mailinglist , linux-hwmon@vger.kernel.org, Linux PM , Linux Kernel Mailing List , Sujith Thomas , Darren Hart , Andy Shevchenko , Zhang Rui , Daniel Lezcano , Amit Kucheria , Jean Delvare , Guenter Roeck , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, Nov 28, 2019 at 4:55 PM Akinobu Mita wrote: > > This switches the intel_menlow driver to use deci_kelvin_to_celsius() and > celsius_to_deci_kelvin() in instead of helpers in > . > > This is preparation for centralizing the kelvin to/from Celsius conversion > helpers in . > > This also removes a trailing space, while we're at it. > Reviewed-by: Andy Shevchenko > Cc: Sujith Thomas > Cc: Darren Hart > Cc: Andy Shevchenko > Cc: Zhang Rui > Cc: Daniel Lezcano > Cc: Amit Kucheria > Cc: Jean Delvare > Cc: Guenter Roeck > Cc: Keith Busch > Cc: Jens Axboe > Cc: Christoph Hellwig > Cc: Sagi Grimberg > Signed-off-by: Akinobu Mita > --- > * v2 > - include explicitly from thermal drivers > - fix s/temprature/temperature/ typo in commit log > - don't mix up another fix (format string for cellsius value) > > drivers/platform/x86/intel_menlow.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/intel_menlow.c b/drivers/platform/x86/intel_menlow.c > index b102f6d..12c1094 100644 > --- a/drivers/platform/x86/intel_menlow.c > +++ b/drivers/platform/x86/intel_menlow.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -302,8 +303,10 @@ static ssize_t aux_show(struct device *dev, struct device_attribute *dev_attr, > int result; > > result = sensor_get_auxtrip(attr->handle, idx, &value); > + if (result) > + return result; > > - return result ? result : sprintf(buf, "%lu", DECI_KELVIN_TO_CELSIUS(value)); > + return sprintf(buf, "%lu", deci_kelvin_to_celsius(value)); > } > > static ssize_t aux0_show(struct device *dev, > @@ -332,8 +335,8 @@ static ssize_t aux_store(struct device *dev, struct device_attribute *dev_attr, > if (value < 0) > return -EINVAL; > > - result = sensor_set_auxtrip(attr->handle, idx, > - CELSIUS_TO_DECI_KELVIN(value)); > + result = sensor_set_auxtrip(attr->handle, idx, > + celsius_to_deci_kelvin(value)); > return result ? result : count; > } > > -- > 2.7.4 > -- With Best Regards, Andy Shevchenko