From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DC73C43331 for ; Fri, 6 Sep 2019 10:51:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D7A352070C for ; Fri, 6 Sep 2019 10:51:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567767079; bh=F40/vyERzL2PLT+u7CNuLPRmvSEYRMi6jl/F1YioOow=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=k3sbE1ePvWPYSqVcOaX6LlTBx+fRAQo/Pjlut2Hs0rg15Z6YH6Ztnu1feuZuHDNtz oBoynXr+z8xx568nLWzKuGQhSy0w1Hy9b7lb5v7+XHbyCxzHQ1wHqYSUwYx4XQZ7Ha VIspxL3Zs6f4W2WVrc9Ma3W0Sr9iz9uM4rwFTvrk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389620AbfIFKvP (ORCPT ); Fri, 6 Sep 2019 06:51:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:36898 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725946AbfIFKvP (ORCPT ); Fri, 6 Sep 2019 06:51:15 -0400 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D51F7214E0; Fri, 6 Sep 2019 10:51:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567767075; bh=F40/vyERzL2PLT+u7CNuLPRmvSEYRMi6jl/F1YioOow=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=XC7BjD4hpWNrKK1pOpCRX02SjWQJCOK5gbUvFoli/8DoHFwcrigpVQp1QjIv24WpF 3hJfKMDgOn65XmIZDcVCGO/8Sr3r8YzUkIFTLavQgHRoyJu9StYgFHDfQQAjBcVc19 ARQKYejAHq4EGjxZetUnrB+vwDkoilM7UE3eDMcE= Received: by mail-lj1-f173.google.com with SMTP id x18so5611106ljh.1; Fri, 06 Sep 2019 03:51:14 -0700 (PDT) X-Gm-Message-State: APjAAAUh3hVUqSUtvNoPL9Hvk3wMzH3mgRGf+L8EaQysZkHZ9arQVoot jxTyhOuiAabRMC2SAg8vm0gG6SQ1YA731I0QBIk= X-Google-Smtp-Source: APXvYqwz+PkOkcsh+hE8+0p+GyRXl5rEBYk6E+6at+bWRa6Bvz54E4CXhRKX/zpdsB3GgFZGBaVFW3t88k1Ohu8cSYo= X-Received: by 2002:a2e:8785:: with SMTP id n5mr1760238lji.210.1567767072972; Fri, 06 Sep 2019 03:51:12 -0700 (PDT) MIME-Version: 1.0 References: <20190906101344.3535-1-l.luba@partner.samsung.com> <20190906101344.3535-2-l.luba@partner.samsung.com> In-Reply-To: <20190906101344.3535-2-l.luba@partner.samsung.com> From: Krzysztof Kozlowski Date: Fri, 6 Sep 2019 12:51:01 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] memory: Exynos5422: minor fixes in DMC To: Lukasz Luba Cc: devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-pm@vger.kernel.org, "linux-samsung-soc@vger.kernel.org" , linux-arm-kernel@lists.infradead.org, =?UTF-8?B?QmFydMWCb21pZWogxbtvxYJuaWVya2lld2ljeg==?= , kgene@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org, Chanwoo Choi , kyungmin.park@samsung.com, Marek Szyprowski , s.nawrocki@samsung.com, myungjoo.ham@samsung.com, willy.mh.wolff.ml@gmail.com Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Fri, 6 Sep 2019 at 12:14, Lukasz Luba wrote: > > Small fixes captured by static analyzes. Explain please what are the errors being fixed. Additionally error message from tool might be useful. Also: Reported-by: Krzysztof Kozlowski Best regards, Krzysztof > Signed-off-by: Lukasz Luba > --- > drivers/memory/samsung/exynos5422-dmc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c > index 8c2ec29a7d57..a809fa997c03 100644 > --- a/drivers/memory/samsung/exynos5422-dmc.c > +++ b/drivers/memory/samsung/exynos5422-dmc.c > @@ -269,7 +269,7 @@ static int exynos5_init_freq_table(struct exynos5_dmc *dmc, > return 0; > > err_free_tables: > - kfree(dmc->opp); > + devm_kfree(dmc->dev, dmc->opp); > err_opp: > dev_pm_opp_of_remove_table(dmc->dev); > > @@ -732,7 +732,7 @@ static struct devfreq_dev_profile exynos5_dmc_df_profile = { > * statistics engine which supports only registered values. Thus, some alignment > * must be made. > */ > -unsigned long > +static unsigned long > exynos5_dmc_align_init_freq(struct exynos5_dmc *dmc, > unsigned long bootloader_init_freq) > { > -- > 2.17.1 >