From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29917C3A59E for ; Wed, 21 Aug 2019 12:17:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3A05233A2 for ; Wed, 21 Aug 2019 12:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566389823; bh=uynG4lj2NFKmPKucYZd6LWpEU0LW0PqM8k6juv4kk6Q=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=u1cMQ/SF64vyGV8C/FIHoVEAP0c1K5GCJb4mtBAio8w5U9XYe8tpwVQBUf+RldrEY rowdbVAl3a6MS1EifHAx4nhg1UREz5W2NXWFJkJX1cDAOSjQPYEUWj/lcHpyqwPv6A sOzs7f8IZ533P9eminhIBYTKYrMIMqCD+VG/3Czo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728142AbfHUMQ7 (ORCPT ); Wed, 21 Aug 2019 08:16:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:58684 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727346AbfHUMQ7 (ORCPT ); Wed, 21 Aug 2019 08:16:59 -0400 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3933923401; Wed, 21 Aug 2019 12:16:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566389817; bh=uynG4lj2NFKmPKucYZd6LWpEU0LW0PqM8k6juv4kk6Q=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=n5XzPGno2q7GDr4k8K4aFDxr1MHVuArZuIuRAba8kHNpJ3sIFhzq0MGouM4G0xett ITlIE91yd6uf4r08BfyR7p6rw8W8m28KdhSeQpG+ed04AI7T3ZhrCorMo4CtXgG8be u/EA4VZ1s5JbIepDqrjmk4ocsLQh22dVof1FpxHg= Received: by mail-lj1-f169.google.com with SMTP id t14so1928129lji.4; Wed, 21 Aug 2019 05:16:57 -0700 (PDT) X-Gm-Message-State: APjAAAW4kegqaqZgggo1ygGRP7UcCdgmzMrOYF+vdu3cnpzTmSXd/CEi JC4bZrx4P3ETJJXUmq051S1Ds2JezB/tz21RCcc= X-Google-Smtp-Source: APXvYqylX2rUmIlELH4D93bM3e4TXvEwUkh5Y4r23cXAhB6gAMzrPtx7w1O/W8NsexFVtpfI5op4YqTOQY/zJHbWoqA= X-Received: by 2002:a2e:9b13:: with SMTP id u19mr14134020lji.40.1566389815350; Wed, 21 Aug 2019 05:16:55 -0700 (PDT) MIME-Version: 1.0 References: <20190813150827.31972-1-s.nawrocki@samsung.com> <20190813150827.31972-3-s.nawrocki@samsung.com> <1e428c8e-f4b5-0810-77f9-2c899c040fc7@kernel.org> <72eea1ea-2433-2f76-6265-5851554e845d@samsung.com> In-Reply-To: <72eea1ea-2433-2f76-6265-5851554e845d@samsung.com> From: Krzysztof Kozlowski Date: Wed, 21 Aug 2019 14:16:44 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API To: Bartlomiej Zolnierkiewicz Cc: Sylwester Nawrocki , Jon Hunter , Sylwester Nawrocki , robh+dt@kernel.org, vireshk@kernel.org, devicetree@vger.kernel.org, kgene@kernel.org, pankaj.dubey@samsung.com, "linux-samsung-soc@vger.kernel.org" , linux-arm-kernel@lists.infradead.org, "linux-kernel@vger.kernel.org" , linux-pm@vger.kernel.org, Marek Szyprowski , linux-tegra , Arnd Bergmann Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Wed, 21 Aug 2019 at 13:51, Bartlomiej Zolnierkiewicz wrote: > >>> Following this change, I am now seeing the above error on our Tegra > >>> boards where this driver is enabled. This is triggering a kernel > >>> warnings test we have to fail. Hence, I don't think that you can remove > >>> the compatible node test here, unless you have a better way to determine > >>> if this is a samsung device. > >> > >> Right, this is really wrong... I missed that it is not a probe but > >> early init. And this init will be called on every board... Probably it > >> should be converted to a regular driver. > > Early initialization is needed for SoC driver to be used from within > arch/arm/mach-exynos/ and _initcall() usage is the usual way for SoC > drivers to be initialized: > > drivers/soc/amlogic/meson-gx-socinfo.c > drivers/soc/amlogic/meson-mx-socinfo.c > drivers/soc/atmel/soc.c > drivers/soc/bcm/brcmstb/common.c > drivers/soc/imx/soc-imx-scu.c > drivers/soc/imx/soc-imx8.c > drivers/soc/renesas/renesas-soc.c > drivers/soc/tegra/fuse/fuse-tegra.c > drivers/soc/ux500/ux500-soc-id.c > drivers/soc/versatile/soc-integrator.c > drivers/soc/versatile/soc-integrator.c > > The only SoC drivers that are regular drivers are: > > drivers/soc/fsl/guts.c > drivers/soc/versatile/soc-realview.c Thanks for pointing it out. Indeed, the initcall was needed in your set of patches here: https://patchwork.kernel.org/project/linux-samsung-soc/list/?series=43565&state=* but this work was not continued here. Maybe it will be later resubmitted... maybe not... who knows? Therefore I would prefer proper solution for current case (driver), unless patches for mach are being brought back to life now. > > I'm also inclined to have it converted to a regular driver. We already > > have "exynos-asv" driver matching on the chipid node (patch 3/9). > > The ASV patches will not be merged soon anyway, all this needs some more > > thought. Krzysztof, can we abandon the chipid patches for now? Your > > chipid driver is good and useful on its own. The preferred solution > IMHO would be to just revert "soc: samsung: Convert exynos-chipid > driver to use the regmap API" commit. I queued the chipid as a dependency for ASV but ASV requires the regmap. What would be left after reverting the regmap part? Simple unused printk driver? No need for such. If reverting, then let's drop entire driver and rework it offline. Best regards, Krzysztof