From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 902F8C3A589 for ; Tue, 20 Aug 2019 19:37:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5DC372332A for ; Tue, 20 Aug 2019 19:37:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566329868; bh=nSPTWxgTSSBej7q5ret8+e8QFb0fXix0iVWrBjjhUQk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=prbYIhiRbzjZ2J6AtwRLog3/oTz+rPeQg2HHlMPqFUKotQe6IFUwpF4TupjDeLLIu fhdICOh0m1900iqD8WiL3ivXhI+J4WTt1uOG/kLXSsmgGFl5GCgXKgQWvSYeadIFr4 HqKSYs2DGN10Mks6qrz3FjZdPlOnZ65hmoq6NT+k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730717AbfHTTho (ORCPT ); Tue, 20 Aug 2019 15:37:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:43016 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728185AbfHTTho (ORCPT ); Tue, 20 Aug 2019 15:37:44 -0400 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B0524214DA; Tue, 20 Aug 2019 19:37:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566329863; bh=nSPTWxgTSSBej7q5ret8+e8QFb0fXix0iVWrBjjhUQk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=1+JhBm9RGKco7pgqDqsCD/WBQh5pzJsVXXyb/glnz93S5JI9lfsq4aT6zEZ19couM uCFRZCyMt7T7b7/QJQHaaP1SUVKHdBb/e20ZE5j8hc98Ch4kwrid3JYZBvIcQaMUt0 4HVbbrtwqc9RUCwx0cYNtF+oZBWHlRH9yEtk4Xcg= Received: by mail-lj1-f170.google.com with SMTP id e27so6231877ljb.7; Tue, 20 Aug 2019 12:37:42 -0700 (PDT) X-Gm-Message-State: APjAAAUEB7e8CchviKkQ4XnZneXVsuKVcUBo5Jrtevz/iPfTaJv7nQqc 5FqnQ7US9kJ7/Ax5nWAFSqSA4QkdG1V8mbpUTDM= X-Google-Smtp-Source: APXvYqzYqxJRbRYm6dWQWcuF6mGrgohmoKorAwd/s9QlXOo/me03d2EOKdPcqUIWWnwYqLsRbaLjK+3gTgKYvrXxP2Y= X-Received: by 2002:a2e:b4d4:: with SMTP id r20mr16800519ljm.5.1566329860916; Tue, 20 Aug 2019 12:37:40 -0700 (PDT) MIME-Version: 1.0 References: <20190813150827.31972-1-s.nawrocki@samsung.com> <20190813150827.31972-3-s.nawrocki@samsung.com> In-Reply-To: From: Krzysztof Kozlowski Date: Tue, 20 Aug 2019 21:37:29 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API To: Jon Hunter , Sylwester Nawrocki Cc: robh+dt@kernel.org, vireshk@kernel.org, devicetree@vger.kernel.org, kgene@kernel.org, pankaj.dubey@samsung.com, "linux-samsung-soc@vger.kernel.org" , linux-arm-kernel@lists.infradead.org, "linux-kernel@vger.kernel.org" , linux-pm@vger.kernel.org, =?UTF-8?B?QmFydMWCb21pZWogxbtvxYJuaWVya2lld2ljeg==?= , Marek Szyprowski , linux-tegra , Arnd Bergmann Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, 20 Aug 2019 at 21:24, Jon Hunter wrote: > > > On 13/08/2019 16:08, Sylwester Nawrocki wrote: > > Convert the driver to use regmap API in order to allow other > > drivers, like ASV, to access the CHIPID registers. > > > > This patch adds definition of selected CHIPID register offsets > > and register bit fields for Exynos5422 SoC. > > > > Signed-off-by: Sylwester Nawrocki > > --- > > Changes since v2: > > - s/_EXYNOS_ASV_H/__LINU_SOC_EXYNOS_ASV_H, > > - removed __func__ from error log, > > - removed unneeded header inclusion. > > > > Changes since v1 (RFC): > > - new patch > > --- > > drivers/soc/samsung/exynos-chipid.c | 34 ++++++--------- > > include/linux/soc/samsung/exynos-chipid.h | 52 +++++++++++++++++++++++ > > 2 files changed, 65 insertions(+), 21 deletions(-) > > create mode 100644 include/linux/soc/samsung/exynos-chipid.h > > > > diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c > > index bcf691f2b650..006a95feb618 100644 > > --- a/drivers/soc/samsung/exynos-chipid.c > > +++ b/drivers/soc/samsung/exynos-chipid.c > > @@ -9,16 +9,13 @@ > > */ > > > > #include > > +#include > > #include > > -#include > > +#include > > #include > > +#include > > #include > > > > -#define EXYNOS_SUBREV_MASK (0xF << 4) > > -#define EXYNOS_MAINREV_MASK (0xF << 0) > > -#define EXYNOS_REV_MASK (EXYNOS_SUBREV_MASK | EXYNOS_MAINREV_MASK) > > -#define EXYNOS_MASK 0xFFFFF000 > > - > > static const struct exynos_soc_id { > > const char *name; > > unsigned int id; > > @@ -51,29 +48,24 @@ static const char * __init product_id_to_soc_id(unsigned int product_id) > > int __init exynos_chipid_early_init(void) > > { > > struct soc_device_attribute *soc_dev_attr; > > - void __iomem *exynos_chipid_base; > > struct soc_device *soc_dev; > > struct device_node *root; > > - struct device_node *np; > > + struct regmap *regmap; > > u32 product_id; > > u32 revision; > > + int ret; > > > > - /* look up for chipid node */ > > - np = of_find_compatible_node(NULL, NULL, "samsung,exynos4210-chipid"); > > - if (!np) > > - return -ENODEV; > > - > > - exynos_chipid_base = of_iomap(np, 0); > > - of_node_put(np); > > - > > - if (!exynos_chipid_base) { > > - pr_err("Failed to map SoC chipid\n"); > > - return -ENXIO; > > + regmap = syscon_regmap_lookup_by_compatible("samsung,exynos4210-chipid"); > > + if (IS_ERR(regmap)) { > > + pr_err("Failed to get CHIPID regmap\n"); > > + return PTR_ERR(regmap); > > } > > Following this change, I am now seeing the above error on our Tegra > boards where this driver is enabled. This is triggering a kernel > warnings test we have to fail. Hence, I don't think that you can remove > the compatible node test here, unless you have a better way to determine > if this is a samsung device. Right, this is really wrong... I missed that it is not a probe but early init. And this init will be called on every board... Probably it should be converted to a regular driver. This is very old patchset, revived recently. I see that in v6 it was a platform driver: https://patchwork.kernel.org/patch/9134949/ Pankaj, apparently based on these comments, made it initcall... but why? Another point is that Arnd complained there about exposing global header and no change here - we still expose the global header, but not with soc revisions but register internals... although it has its purpose - other Exynos-specific drivers need to access through regmap. Best regards, Krzysztof