From: Joel Fernandes <joelaf@google.com>
To: Patrick Bellasi <patrick.bellasi@arm.com>
Cc: "Michal Koutný" <mkoutny@suse.com>,
LKML <linux-kernel@vger.kernel.org>,
"Linux PM" <linux-pm@vger.kernel.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Tejun Heo" <tj@kernel.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Paul Turner" <pjt@google.com>,
"Quentin Perret" <quentin.perret@arm.com>,
"Dietmar Eggemann" <dietmar.eggemann@arm.com>,
"Morten Rasmussen" <morten.rasmussen@arm.com>,
"Juri Lelli" <juri.lelli@redhat.com>,
"Todd Kjos" <tkjos@google.com>,
"Steve Muckle" <smuckle@google.com>,
"Suren Baghdasaryan" <surenb@google.com>,
"Alessio Balsini" <balsini@android.com>
Subject: Re: [PATCH v11 3/5] sched/core: uclamp: Propagate system defaults to root group
Date: Tue, 16 Jul 2019 11:46:18 -0400 [thread overview]
Message-ID: <CAJWu+opGqXG0shybpLvt5fXOe_UdoiXU-tNWjkWSrHmO+wtavw@mail.gmail.com> (raw)
In-Reply-To: <20190716143417.us3xhksrsaxsl2ok@e110439-lin>
On Tue, Jul 16, 2019 at 10:34 AM Patrick Bellasi
<patrick.bellasi@arm.com> wrote:
>
> On 15-Jul 18:42, Michal Koutný wrote:
> > On Mon, Jul 08, 2019 at 09:43:55AM +0100, Patrick Bellasi <patrick.bellasi@arm.com> wrote:
> > > +static void uclamp_update_root_tg(void)
> > > +{
> > > + struct task_group *tg = &root_task_group;
> > > +
> > > + uclamp_se_set(&tg->uclamp_req[UCLAMP_MIN],
> > > + sysctl_sched_uclamp_util_min, false);
> > > + uclamp_se_set(&tg->uclamp_req[UCLAMP_MAX],
> > > + sysctl_sched_uclamp_util_max, false);
> > > +
> > > + cpu_util_update_eff(&root_task_group.css);
> > > +}
> > cpu_util_update_eff internally calls css_for_each_descendant_pre() so
> > this should be protected with rcu_read_lock().
>
> Right, good catch! Will add in v12.
>
Hopefully these can catch it in the near future!
https://lore.kernel.org/rcu/20190715143705.117908-1-joel@joelfernandes.org/T/#t
next prev parent reply other threads:[~2019-07-16 15:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 8:43 [PATCH v11 0/5] Add utilization clamping support (CGroups API) Patrick Bellasi
2019-07-08 8:43 ` [PATCH v11 1/5] sched/core: uclamp: Extend CPU's cgroup controller Patrick Bellasi
2019-07-08 11:08 ` Quentin Perret
2019-07-15 13:38 ` Patrick Bellasi
2019-07-18 14:52 ` Tejun Heo
2019-07-18 15:26 ` Patrick Bellasi
2019-07-08 8:43 ` [PATCH v11 2/5] sched/core: uclamp: Propagate parent clamps Patrick Bellasi
2019-07-15 16:42 ` Michal Koutný
2019-07-16 14:07 ` Patrick Bellasi
2019-07-16 15:29 ` Michal Koutný
2019-07-16 17:55 ` Patrick Bellasi
2019-07-08 8:43 ` [PATCH v11 3/5] sched/core: uclamp: Propagate system defaults to root group Patrick Bellasi
2019-07-15 16:42 ` Michal Koutný
2019-07-16 14:34 ` Patrick Bellasi
2019-07-16 15:36 ` Michal Koutný
2019-07-16 18:00 ` Patrick Bellasi
2019-07-16 15:46 ` Joel Fernandes [this message]
2019-07-08 8:43 ` [PATCH v11 4/5] sched/core: uclamp: Use TG's clamps to restrict TASK's clamps Patrick Bellasi
2019-07-15 16:42 ` Michal Koutný
2019-07-16 14:34 ` Patrick Bellasi
2019-07-16 15:58 ` Michal Koutný
2019-07-08 8:43 ` [PATCH v11 5/5] sched/core: uclamp: Update CPU's refcount on TG's clamp changes Patrick Bellasi
2019-07-15 16:51 ` [PATCH v11 0/5] Add utilization clamping support (CGroups API) Michal Koutný
2019-07-16 14:03 ` Patrick Bellasi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJWu+opGqXG0shybpLvt5fXOe_UdoiXU-tNWjkWSrHmO+wtavw@mail.gmail.com \
--to=joelaf@google.com \
--cc=balsini@android.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mkoutny@suse.com \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=quentin.perret@arm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=smuckle@google.com \
--cc=surenb@google.com \
--cc=tj@kernel.org \
--cc=tkjos@google.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).