From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8A40CCA47A for ; Thu, 16 Jun 2022 17:31:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233749AbiFPRbe (ORCPT ); Thu, 16 Jun 2022 13:31:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230386AbiFPRbe (ORCPT ); Thu, 16 Jun 2022 13:31:34 -0400 Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52C4F2AE0E; Thu, 16 Jun 2022 10:31:33 -0700 (PDT) Received: by mail-yb1-f180.google.com with SMTP id t1so3330397ybd.2; Thu, 16 Jun 2022 10:31:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=irnPXDDs9giqZixb3bVvb0MoUIRIDyuwHiNhzsO5+C4=; b=4hK5hLrqQ3HzQqlkrFWj7oCH/NdTeQ1ZX9JZ07dXs3AwQ/gW9hckpNmXOrva4I6M+h /WEC45HQdR8QFbgo9v/yqIGmkrVI6GCUH3mCsDK6X6myYVCKeMBhXWYqE92MFZ2o5b6i xwOBjO6yi5Ew0R6OEn35FKDRuE+HHMoUYUXJANQk7u2MLjPZvcu3uHK/cz+hxIAFimBh wZh/VJYQUSDCYaafxEI7+O3//WPwZyQFqb5nNVcY4r0KFW97ooT2DEsXAEf+WGLKo+s+ sa7RnKoZOllMnKBS/uXgsBbjX9aEzj+lNCwGnDsmC8gMK0s6OzlNv+LGkifBDqt1JhNY skhw== X-Gm-Message-State: AJIora+DimyjG8F+2rpWBxR99sArFv9vZWjwY3PhzXONS5qDTCD9o/+J SA6NNn8JY0Oi+R8KEHKVk1+NWADIdkTxs86atsU= X-Google-Smtp-Source: AGRyM1vOEjiPb25k6E6zUt4jvZQIEK/MmQe5h6fqDF85t8MOVMtMD693ctQIewxPENLk6VF/02yz4vAev58TJ4Ji1qQ= X-Received: by 2002:a25:84ca:0:b0:65c:b5a4:3d0a with SMTP id x10-20020a2584ca000000b0065cb5a43d0amr6539892ybm.137.1655400692553; Thu, 16 Jun 2022 10:31:32 -0700 (PDT) MIME-Version: 1.0 References: <1843211.tdWV9SEqCh@kreacher> <2653857.mvXUDI8C0e@kreacher> <2726954.BEx9A2HvPv@kreacher> In-Reply-To: From: "Rafael J. Wysocki" Date: Thu, 16 Jun 2022 19:31:21 +0200 Message-ID: Subject: Re: [PATCH v2 13/16] mfd: core: Use acpi_dev_for_each_child() To: Lee Jones Cc: "Rafael J. Wysocki" , Linux ACPI , LKML , Linux PM , Andy Shevchenko , Mika Westerberg , Hans de Goede , Sakari Ailus Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, Jun 16, 2022 at 12:39 AM Lee Jones wrote: > > On Mon, 13 Jun 2022, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > Instead of walking the list of children of an ACPI device directly, > > use acpi_dev_for_each_child() to carry out an action for all of > > the given ACPI device's children. > > > > This will help to eliminate the children list head from struct > > acpi_device as it is redundant and it is used in questionable ways > > in some places (in particular, locking is needed for walking the > > list pointed to it safely, but it is often missing). > > > > Signed-off-by: Rafael J. Wysocki > > Reviewed-by: Andy Shevchenko > > --- > > > > v1 -> v2: > > * Add R-by from Andy. > > > > --- > > drivers/mfd/mfd-core.c | 31 ++++++++++++++++++++++++------- > > 1 file changed, 24 insertions(+), 7 deletions(-) > > Applied, thanks. Thank you! Can you please expose a branch containing it for integration? The last patch in the series depends on this one.