From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6416C7618E for ; Tue, 23 Jul 2019 09:13:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C06EC227B9 for ; Tue, 23 Jul 2019 09:13:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563873213; bh=wujA94+Og9Bx9XzZozqqH52IFciDgKWmF/1WB888+Tw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=vXSjIQrFoKTg7uv7sPB+FC4JVf/uxtYH9O3JSs1YZWEl4DDkXL1hT92aFNt1ZfVAx Tm/RYbR/rmxMBrqiv3tSgHVczRJJKn1+JTOiIf88Mkh4LTTo8ifdbeDiOWjEFNtOB9 uz5kqonh2KWUiGIIVAqFqrXwJS08erLk9IA7VGoU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730572AbfGWJN3 (ORCPT ); Tue, 23 Jul 2019 05:13:29 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:41150 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726352AbfGWJN3 (ORCPT ); Tue, 23 Jul 2019 05:13:29 -0400 Received: by mail-oi1-f195.google.com with SMTP id g7so31762677oia.8; Tue, 23 Jul 2019 02:13:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wujA94+Og9Bx9XzZozqqH52IFciDgKWmF/1WB888+Tw=; b=R6LWVFAU6Z/PmvNWFEMKWwXBmV8B2yUImSYjMEQFv5FQgTAkxcVF/ll+2oB/fw0Yqv Mm+J/Q+iSKwZ4zx/6N4J7KXMiwDJdjHWouUtB5Y/wik7kcEp24D0Lu6gh0uCT2OXOPBp FI9VtqPmjNf6eLNZjG8kJ11PfgeiEMZnt9WeLcy4R2hakHo9LeeMfbYEHsvPq7PKV96v YAlwDz9SuFZrjEXh7TFz6xwgirrjWILlFgCGvRyT6AfZyV24gmKha3PnzwqGXDCXMCYh rY2JOGuOeT/NXcbnkehneEcmsXbArC3CJhRbODPQDiY93xwpELER4P2Pi8ycge62VK6h HYhA== X-Gm-Message-State: APjAAAX8GnFN/j53diH/MJW3F16GuFu3arC+TvNQ7v5MsqB+R5KW4Jl8 pEKg6flU4ebIT9VPvF7L73oyqj8WNXmaZJ17vEY= X-Google-Smtp-Source: APXvYqycTX8Zfj7JWcbdeDeuWvjXA1EJqOWRQ4+e1v+Vfhp98qBwthTQGrb2dWn3PpBWJ+qFbxBXPbisFLBGOnH0g4s= X-Received: by 2002:aca:edc8:: with SMTP id l191mr36097785oih.103.1563873208155; Tue, 23 Jul 2019 02:13:28 -0700 (PDT) MIME-Version: 1.0 References: <1563431200-3042-1-git-send-email-dsmythies@telus.net> <8091ef83f264feb2feaa827fbeefe08348bcd05d.1563778071.git.viresh.kumar@linaro.org> <001201d54125$a6a82350$f3f869f0$@net> In-Reply-To: <001201d54125$a6a82350$f3f869f0$@net> From: "Rafael J. Wysocki" Date: Tue, 23 Jul 2019 11:13:17 +0200 Message-ID: Subject: Re: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change To: Doug Smythies Cc: Viresh Kumar , Rafael Wysocki , Ingo Molnar , Peter Zijlstra , Linux PM , Vincent Guittot , Joel Fernandes , "v4 . 18+" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, Jul 23, 2019 at 9:10 AM Doug Smythies wrote: > > On 2019.07.21 23:52 Viresh Kumar wrote: > > > To avoid reducing the frequency of a CPU prematurely, we skip reducing > > the frequency if the CPU had been busy recently. > > > > This should not be done when the limits of the policy are changed, for > > example due to thermal throttling. We should always get the frequency > > within limits as soon as possible. > > > > Fixes: ecd288429126 ("cpufreq: schedutil: Don't set next_freq to UINT_MAX") > > Cc: v4.18+ # v4.18+ > > Reported-by: Doug Smythies > > Signed-off-by: Viresh Kumar > > --- > > @Doug: Please try this patch, it must fix the issue you reported. > > It fixes the driver = acpi-cpufreq ; governor = schedutil test case > It does not fix the driver = intel_cpufreq ; governor = schedutil test case So what's the difference between them, with the patch applied? > I have checked my results twice, but will check again in the day or two. OK, thanks!