From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC295C432C0 for ; Wed, 27 Nov 2019 08:31:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AE6762064B for ; Wed, 27 Nov 2019 08:31:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574843488; bh=PTA/YWepvxWmdgiKNgo8P0O2OE2q/H8svD4znDnxCag=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=h5df/AWkh9lkX+ZQ8/iURI/pMxutap5Z9NpIWZmrAERSHDmubiYDcBYSivnPu3jj+ MZvzwHW02QEYUFcINFOQTEyMLWhA89Ekc+34W4A6IxB+o6oAFLAceXCYmPMVs1hvYq Oe8QCCbyNFP6UTIJrhlS8y93TeToYjLvp1hVXEZk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726591AbfK0Ib2 (ORCPT ); Wed, 27 Nov 2019 03:31:28 -0500 Received: from mail-oi1-f173.google.com ([209.85.167.173]:35647 "EHLO mail-oi1-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726125AbfK0Ib1 (ORCPT ); Wed, 27 Nov 2019 03:31:27 -0500 Received: by mail-oi1-f173.google.com with SMTP id k196so2976731oib.2 for ; Wed, 27 Nov 2019 00:31:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JflAYgH18LGpyCuInG2JHUoQW9JnvUIZaMYidLrqwpI=; b=owsL3lUkbPU7Y58ljNmn2RUdo2hiwbUcbpuC6ZUPZLUXzUfdPF2DoCBffxUXzNVzn5 ycGys7KlfiuqSK5XypGRK8caFAvmmJ41yuKqevidlt2mi2U66F9BghRMy736WvrYvzJP wpLDaDUfQhQq/QkPq3jXMO1Tm/glUnJZMzqiJ/CTLrIQme6M6L3jpSIFNwzWRON24WCk 7lyEQyCB5q4h/YAA8vCaC9rsy31CxjVUDIJAgGsJ4Wa2bW/nlLTg7hcE1y6+ZrKTOm4W FVeDLdc2z2YcX+IJpWEmXJC3mbDYKeoAuMTw4tR94hGh/Ck51OVDrKotfvIPDMyBEYlA RfDw== X-Gm-Message-State: APjAAAX2ulebOGi900GOUOVpLsnGtvTBl5RfVJTeFyH7oiMCnPUl7qV3 3rb9WQ1jN+dhXHIVo51vDEJ6QP4t0BdjD/s8pEY= X-Google-Smtp-Source: APXvYqy/Q9sYRCLynazZz3nToevvj7G4XlaYjai6/wBo45t8jwBjhWjVEgOE7k3eCFupORXz2X6OrmNeJ+Lt03L6ks8= X-Received: by 2002:a05:6808:901:: with SMTP id w1mr3114446oih.57.1574843487000; Wed, 27 Nov 2019 00:31:27 -0800 (PST) MIME-Version: 1.0 References: <12933162.9b7K5rSXZx@kreacher> In-Reply-To: From: "Rafael J. Wysocki" Date: Wed, 27 Nov 2019 09:31:15 +0100 Message-ID: Subject: Re: Help me fix a regression caused by 56b9918490 (PM: sleep: Simplify suspend-to-idle control flow) To: "Kenneth R. Crudup" Cc: "Rafael J. Wysocki" , "Rafael J. Wysocki" , Rafael Wysocki , Linux PM Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Wed, Nov 27, 2019 at 3:35 AM Kenneth R. Crudup wrote: > > > On Tue, 26 Nov 2019, Kenneth R. Crudup wrote: > > > So there were some 5 times where my laptop spontaneously (I'll bet it was > > that damned accelerometer) woke up, sometimes for minutes at at time, all > > the while in my laptop bag. > ... > > But the great news about this is this maybe explains why I'll try and resume > > after being mobile; whatever awakening we used to do wouldn't be handled > > (again, guessing :)) and we'd freeze up. > > So I'd just realized something- when you'd first pushed the series of commits > changing the S2idle flow, I'd sent an E-mail about some issues I'd had: > > ---- > Date: Wed, 18 Sep 2019 18:05:53 > From: Kenneth R. Crudup > To: rafael.j.wysocki@intel.com > Cc: linux-pm@vger.kernel.org > Message-ID: > Subject: Help me help you debug what seems to be an EC resume issue > ... > >>> Before these commits, I used to set "acpi.ec_no_wakeup=1" because the > >>> orientation sensor (at least, and probably other things) would wake up > >>> the laptop (then immediately suspend), which I'm sure was using up > >>> battery while I'm just walking around. > >>> I've turned off "ec_no_wakeup" for testing and the good news is the > >>> orientation sensor doesn't cause the laptop to draw more power when shaking it. > ---- > > Whoops- I guess in the face of everything we now know, that was indeed a > bug and not a feature, because I'd also posted: > > >>> Randomly, if left suspended, nothing other than a hard power off will get > >>> it back (and I can't be sure, but I think current consumption can be normal > >>> when it suspends, but this seems to only happen if I've unplugged the > >>> charger after suspending (so no power meter)) > > So now we know. > > So, now that apparently (fingers still crossed, but so far, so very good) > you've squashed that resume bug, do I have any recourse about this thing > waking up for just by staring at it very hard other than "ec_no_wakeup=1"? > > Personally I don't mind at all having the keyboard being the only thing > that'll take the laptop out of suspend, and the only reason I was looking > for not having to modify the EC operation was 'cause I thought having that > set meant we'd short-circuited some other s2idle optimization, and I'm > constantly trying to minimize s2idle power consumption. > > If all "ec_no_wakeup=1" actually does is silently ignore EC wakeup events, > then I'll stick with it. Yes, that's all it does.