From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40959C31E49 for ; Wed, 19 Jun 2019 12:28:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0CBA9208CB for ; Wed, 19 Jun 2019 12:28:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560947301; bh=JkqxDQxaoP4bZHVemNak1GsJ+YOnJiiFXfkLhDNKRc4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=cO/Y432gnRdRDlTOokYvg59AphTzwJo9P8BHwtxqKrC56NXabrvFGtqhOEFaMi0rD bbgwgYKKe7vvlBpCoLGcjVQan63LS9FmoxDzoReWHkCZy5xGATRT/+NlJAaHtTUNrB d+V+QL8GNS91Z4dBPdk1z9jTx/lpGAZ+pNu1lu40= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727129AbfFSM2U (ORCPT ); Wed, 19 Jun 2019 08:28:20 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:39020 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727068AbfFSM2U (ORCPT ); Wed, 19 Jun 2019 08:28:20 -0400 Received: by mail-ot1-f68.google.com with SMTP id r21so16177965otq.6; Wed, 19 Jun 2019 05:28:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JkqxDQxaoP4bZHVemNak1GsJ+YOnJiiFXfkLhDNKRc4=; b=gvcBmI66xXrBP5+Jk2zO1D4++wI2WogAy0xLZ/5M3StlaNV0SXnn3WoLOeTaCRIRUl NXUNrkkTKgLYFvK5bEC8L2D9MIGWoEwo0PuKI5QiFPYLdgIQAgTTs20pa4lx6Yo227Ck 84rTK+pyGTP9heEoykx6pqElgVKehn5wScrOS/ippBzsMeOmbSwOgmfKSxJixZox149q e7e2HIttBhSvxh9yWG7QpkjUrP3ysKrYipWVnRDuqPCSGLiQx5n2ym3blofQ/ywuKqHs 2Lt76L79JD8Up8FCQcDmkhINpLVN5+ORlhb++cOKBuO7mnF9WzRQ6dsdKCHAVbvZN9O6 0nsA== X-Gm-Message-State: APjAAAXnkJzW4O4027/ynpS525eAWNoBFl5ni0nSn00jaWFCjN4u+7nS Wqwyb1dqNJaoO1B5wBshi/1kn54L7LH5WL4g5xUbAQ== X-Google-Smtp-Source: APXvYqzYviKAQmZCcYPk9Ok0Mn8ppwliIjXjrV1wp/5C+WyaMBH2nWvDpbWKL7Cl2P3JwZUmGxNEO6o8V1ISO/3A3KM= X-Received: by 2002:a05:6830:8a:: with SMTP id a10mr5443795oto.167.1560947299668; Wed, 19 Jun 2019 05:28:19 -0700 (PDT) MIME-Version: 1.0 References: <8c563c8f3515ceefd88875160302b6fd472c3dac.1560944014.git.viresh.kumar@linaro.org> In-Reply-To: <8c563c8f3515ceefd88875160302b6fd472c3dac.1560944014.git.viresh.kumar@linaro.org> From: "Rafael J. Wysocki" Date: Wed, 19 Jun 2019 14:28:08 +0200 Message-ID: Subject: Re: [PATCH 4/6] cpufreq: Use has_target() instead of !setpolicy To: Viresh Kumar Cc: Rafael Wysocki , Linux PM , Vincent Guittot , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Wed, Jun 19, 2019 at 1:36 PM Viresh Kumar wrote: > > For code consistency, use has_target() instead of !setpolicy everywhere, > as it is already done at several places. That's OK > Maybe we should also use !has_target() for setpolicy case to use only one expression > for this differentiation. But I'm not sure what you mean here?