From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB499C43465 for ; Mon, 21 Sep 2020 14:05:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9262C2084C for ; Mon, 21 Sep 2020 14:05:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600697136; bh=p5GM0HufjDCBY4j9GY6j6PtP3N5Mo7/PJrVzUKSEWv4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=PgPjVCv7QvMQsNR5f/vCC6hXppkxAQpyPQLPNjYCqIO/G7OePre4ljgSrhdEtJZip jL2EuLNxPUXOfJXp9GZi6SKRlMtOEcI7qX/MdGC8/mHowfTa5/l1KcmN7545cgBA/4 GCVoY1hNdh6Pz5zj3SuX+Yq8DeH4aj90t4vmvJLA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726457AbgIUOFg convert rfc822-to-8bit (ORCPT ); Mon, 21 Sep 2020 10:05:36 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:36846 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726430AbgIUOFf (ORCPT ); Mon, 21 Sep 2020 10:05:35 -0400 Received: by mail-ot1-f65.google.com with SMTP id 60so12430101otw.3; Mon, 21 Sep 2020 07:05:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=m3af6KAALaFvlr4Q2RRafvRSlyPMyI1uJ+s7w7rbtg8=; b=p4fGwWZCv7VT1L4g2rMBnfkWosAurzhLuM5pPFKmh07NTJpaRW6r+DV5kMT7eXEwmm yJLZheWdf60KjYQXmvRpxzvXqbMYxrFpBwJ5WXhIi/mIsh86UWyn0DcEtCZSqLLYf9C0 tMaf+DSq1DZulpN1poA3Zc3QJA4fc12zn3lH6EYmksSnkTFbRrQOac7DM0SorTpkfynr Az7p8x/k/gfbC7OooV0aKNcDw7apO1MYlZ8wDR2JpT8jxPQe2V03ItvPgYP0HbSiOhmT QFXUNfulCuI7h42DiHE9CnoM7aEOMGuzczqkqthgtlVNZKn/qz9o0cHPFlY/M4Luot1C +5Ew== X-Gm-Message-State: AOAM53154JEMNP7L9cAe1VsdacnsXrWHlU4QQJWnTxgmHxVxUz0TyKvs kn11wfbo40G84F1GKrrs8tson7IMyZygdRpIAxafHiEX X-Google-Smtp-Source: ABdhPJynamnm+QTlBdEB5AWXXyoTB1zIi3eWOv5yVneZU2nOyAvIMpDt8BoI5QXpH5zX+PdUADnDGgpN6UMdsoFSl2E= X-Received: by 2002:a9d:6010:: with SMTP id h16mr31684732otj.262.1600697134575; Mon, 21 Sep 2020 07:05:34 -0700 (PDT) MIME-Version: 1.0 References: <20200921070417.1121-1-hankinsea@gmail.com> In-Reply-To: <20200921070417.1121-1-hankinsea@gmail.com> From: "Rafael J. Wysocki" Date: Mon, 21 Sep 2020 16:05:19 +0200 Message-ID: Subject: Re: [PATCH v2] powercap: include header to fix -Wmissing-prototypes To: Herrington Cc: "Rafael J . Wysocki" , Linux PM , Linux Kernel Mailing List , shipujin.t@gmail.com, Pujin Shi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Sep 21, 2020 at 9:04 AM Herrington wrote: > > Include the linux/idle_inject.h header to fix W=1 build warning: > > drivers/powercap/idle_inject.c:152:6: warning: no previous prototype for ‘idle_inject_set_duration’ [-Wmissing-prototypes] > drivers/powercap/idle_inject.c:167:6: warning: no previous prototype for ‘idle_inject_get_duration’ [-Wmissing-prototypes] > drivers/powercap/idle_inject.c:179:6: warning: no previous prototype for ‘idle_inject_set_latency’ [-Wmissing-prototypes] > drivers/powercap/idle_inject.c:195:5: warning: no previous prototype for ‘idle_inject_start’ [-Wmissing-prototypes] > drivers/powercap/idle_inject.c:227:6: warning: no previous prototype for ‘idle_inject_stop’ [-Wmissing-prototypes] > drivers/powercap/idle_inject.c:299:28: warning: no previous prototype for ‘idle_inject_register’ [-Wmissing-prototypes] > drivers/powercap/idle_inject.c:345:6: warning: no previous prototype for ‘idle_inject_unregister’ [-Wmissing-prototypes] > > Signed-off-by: Herrington > Signed-off-by: Pujin Shi > Signed-off-by: Pujin Shi First, who is the other person whose S-o-b is present here? For a co-author of the patch, a Co-developed-by tag should be present too. Otherwise, a Reviewed-by tag should be used instead of the S-o-b. Also, one S-o-b (or R-by) per developer would be sufficient. > --- > drivers/powercap/idle_inject.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/powercap/idle_inject.c b/drivers/powercap/idle_inject.c > index 4310901a074e..6e1a0043c411 100644 > --- a/drivers/powercap/idle_inject.c > +++ b/drivers/powercap/idle_inject.c > @@ -43,6 +43,7 @@ > #include > #include > #include > +#include > > #include > > -- > 2.25.4 >