From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE736C433E0 for ; Mon, 27 Jul 2020 12:20:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8D6B2075D for ; Mon, 27 Jul 2020 12:20:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595852412; bh=7pJMijVBnv56ag3JXHloaDv3iPnaHiPzA5w0hsV8KWw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=WGFHItMThW2LUsa5uJmJBFtpdOZTbyoUp/4Hy6vkXefSfW5ySqc2r90KBzbJldh2f mydS4kTsezb2NSP99IS4jlFFuiFshUFPSZxXqy21l7X4FoG8iZ5Rwr60WqsFPLyXMy PGR1emDCw11O7ShKrkqGktCzJQByQbClVib9qJhQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727844AbgG0MUL (ORCPT ); Mon, 27 Jul 2020 08:20:11 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:36707 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727775AbgG0MUK (ORCPT ); Mon, 27 Jul 2020 08:20:10 -0400 Received: by mail-oi1-f195.google.com with SMTP id s144so4207085oie.3; Mon, 27 Jul 2020 05:20:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VYdNJKGJtndbhOIlB1kpCwUiNVjH+51o2Mmpgcq8fg8=; b=oVmhMJgcuva+Z2pRZEeBuVUBn+M8cuVfC05UMl5+WYQfIbybGD1w+uYg5rl2Rq0AJ+ OPPP/FW8xohoppIOHqj8UuNeveuBJhjYz2tYuDIOhqsN/cr4ThZUkVWLlCQrZwtwHY6L a1NHwB3OULdLcdlsllFYRqUZCUAdHSkRI2pXIuiDdQ+O6UvnM+thVr3xDFdPPxYMIh43 BbU2qQ7BhofwjZb0/wNgWV7rDVyB31x/504MzjSrAda5srhC34tkMoRKYf/Vwn7MeOFs E/1Tvt0x2V2ZqV7nXKO0vtiFlaESWJqt1AcjH7q3CxVFxOBVfNY+uYGHo+RY2BxQhDXp Y5YQ== X-Gm-Message-State: AOAM531qz/ui9ZnDMcZ0mZuFZLa62mGsc9d6JSJcEFeCceIVZZejia6f sQLg5bZBnMbDzY4Q7a8nC8i8LCcYHrhlPOWvWTs= X-Google-Smtp-Source: ABdhPJzESE2uHUqdDkzrQl8akjB+yPlCH6ucxF6MZ8U6NcVwVphYWXUbyfgNtAl73OF/Rb45GhRPevNJ/DK2nyFBJDo= X-Received: by 2002:a05:6808:34e:: with SMTP id j14mr18551226oie.110.1595852409614; Mon, 27 Jul 2020 05:20:09 -0700 (PDT) MIME-Version: 1.0 References: <1594921495-519-1-git-send-email-sumeet.r.pawnikar@intel.com> <20200727121316.GS3703480@smile.fi.intel.com> In-Reply-To: <20200727121316.GS3703480@smile.fi.intel.com> From: "Rafael J. Wysocki" Date: Mon, 27 Jul 2020 14:19:41 +0200 Message-ID: Subject: Re: [PATCH v3] powercap: Add Power Limit4 support To: "Shevchenko, Andriy" Cc: "Rafael J. Wysocki" , Sumeet Pawnikar , "Rafael J. Wysocki" , "Zhang, Rui" , Srinivas Pandruvada , Linux PM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Jul 27, 2020 at 2:13 PM Shevchenko, Andriy wrote: > > On Mon, Jul 27, 2020 at 01:46:12PM +0200, Rafael J. Wysocki wrote: > > On Thu, Jul 16, 2020 at 7:38 PM Sumeet Pawnikar > > wrote: > > > > > > Modern Intel Mobile platforms support power limit4 (PL4), which is > > > the SoC package level maximum power limit (in Watts). It can be used > > > to preemptively limits potential SoC power to prevent power spikes > > > from tripping the power adapter and battery over-current protection. > > > This patch enables this feature by exposing package level peak power > > > capping control to userspace via RAPL sysfs interface. With this, > > > application like DTPF can modify PL4 power limit, the similar way > > > of other package power limit (PL1). > > > As this feature is not tested on previous generations, here it is > > > enabled only for the platform that has been verified to work, > > > for safety concerns. > > > > Queued up as 5.9 material -> > > > > > Signed-off-by: Sumeet Pawnikar > > > Co-developed-by: Zhang Rui > > > Signed-off-by: Zhang Rui > > > > -> with this tag removed, because the only case in which you can > > include an S-o-b from someone else is when you also add a From: > > pointing to that person. IOW, you add a From: with a matching S-o-b > > from someone else and you can add your own S-o-b to that. > > > > In this particular case, the C-d-b tag is sufficient to make a record > > of somebody else's contribution to a patch carrying a From: header > > that points to you (ie. your patch). > > Rafael, it looks like it contradicts documentation. I mean your amendment. > SoB is specifically required to be coupled with Co-developed-by. That said, > both or none are acceptable. (I don't consider the chain of SoB when it goes > thru maintainers) OK, I stand corrected and so I've added the Rui's S-o-b back to the commit. Thanks!