From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50202C3F2D1 for ; Wed, 4 Mar 2020 09:53:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22C6D2072D for ; Wed, 4 Mar 2020 09:53:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583315631; bh=X+lFtpSez7M/cKFbU4vrFz0GRlLJa1zcIInskBBDy58=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=qY7rf2BG5n/1cB7KIeOAqO9Zavj4+fjq7t00hDIsZDQcTc3udYKGag16jggSs7nO6 +Bu0xMgolEnoGgcziG8NSJ6l7tEGxfUJjf3gUsWK6w4t7ZqneGu1r7jK7oQk/8Thq6 R/xcpJ8vaM3V8wLl1Kx8NPQM/cFz4kXlyaaTZCsU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387736AbgCDJxu (ORCPT ); Wed, 4 Mar 2020 04:53:50 -0500 Received: from mail-oi1-f196.google.com ([209.85.167.196]:33149 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387730AbgCDJxu (ORCPT ); Wed, 4 Mar 2020 04:53:50 -0500 Received: by mail-oi1-f196.google.com with SMTP id q81so1510909oig.0; Wed, 04 Mar 2020 01:53:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PWiXu1+kJXOlwOOpFNo5aE1XWbQqXbi+uifPWRjlrfo=; b=RqAnTBJ0zv90EjnDJ2daFDK1OQOcKTp0W5oHkdnUnf4UhSfDRrT7yvGPcSWTlu6zYB PfbJu0M6WDnS67PZm6BidVyYcdCFRuX25qGLm0Pkw3X2OYg1aZ58UadTp+upFi9WV2xq VtTr5dVjGrF+M7RqmtkUtqHLdOk073Ac3ihvQVLNygKmZcAODXBLOkpDqREZW7GwXVSj W1Byi33qA1UufVOi5tesRi0TgGP+UYVrR1KDCak24oUGTb8ciLrkiO4OWQhty8oqcCuh pr+hsmeoC8fmxncqn8JNYpeFxbYDPlOLWuIk649lEsIMZeuN7Q07o+voSmvfycSTOrfl yUjQ== X-Gm-Message-State: ANhLgQ1ErAOmQeWI+yeg5OknCgkt+mdzWOG48t2eHP1RSbyinVaXcdRY rkrpO8fRFmJ85zs5buzp3NAx3JWe/PDlU6jO/Cg= X-Google-Smtp-Source: ADFU+vtVWZhGfGf6R94WwxIgGmV4KIpNe17sPVEV0Rt5PoQsGytvmiGxeM29nQ7TeQliq+SetX2cwwMlR+GafhuGbNg= X-Received: by 2002:aca:bfc2:: with SMTP id p185mr1182951oif.57.1583315629465; Wed, 04 Mar 2020 01:53:49 -0800 (PST) MIME-Version: 1.0 References: <20200227013411.1.Ica3bb9fa898499d94e0b0a2bfa08ec46c89d84fa@changeid> <20200303170948.1.I108734f38ade020c3e5da825839dca11d2a2ff87@changeid> In-Reply-To: <20200303170948.1.I108734f38ade020c3e5da825839dca11d2a2ff87@changeid> From: "Rafael J. Wysocki" Date: Wed, 4 Mar 2020 10:53:38 +0100 Message-ID: Subject: Re: [PATCH v3] intel_idle: Add Comet Lake support To: Harry Pan Cc: LKML , Harry Pan , Jacob Pan , Len Brown , Linux PM Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, Mar 3, 2020 at 10:10 AM Harry Pan wrote: > > Add a general C-state table in order to support Comet Lake. > > Signed-off-by: Harry Pan > > --- > > drivers/idle/intel_idle.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c > index d55606608ac8..05bce595fafe 100644 > --- a/drivers/idle/intel_idle.c > +++ b/drivers/idle/intel_idle.c > @@ -1067,6 +1067,11 @@ static const struct idle_cpu idle_cpu_dnv = { > .use_acpi = true, > }; > > +static const struct idle_cpu idle_cpu_cml = { > + .state_table = skl_cstates, > + .disable_promotion_to_c1e = true, .use_acpi = true, missing? Otherwise you can just use idle_cpu_skl as is, can't you? > +}; > + > static const struct x86_cpu_id intel_idle_ids[] __initconst = { > INTEL_CPU_FAM6(NEHALEM_EP, idle_cpu_nhx), > INTEL_CPU_FAM6(NEHALEM, idle_cpu_nehalem), > @@ -1105,6 +1110,8 @@ static const struct x86_cpu_id intel_idle_ids[] __initconst = { > INTEL_CPU_FAM6(ATOM_GOLDMONT_PLUS, idle_cpu_bxt), > INTEL_CPU_FAM6(ATOM_GOLDMONT_D, idle_cpu_dnv), > INTEL_CPU_FAM6(ATOM_TREMONT_D, idle_cpu_dnv), > + INTEL_CPU_FAM6(COMETLAKE_L, idle_cpu_cml), > + INTEL_CPU_FAM6(COMETLAKE, idle_cpu_cml), > {} > }; > > -- > 2.24.1 >