From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D9FEC31E49 for ; Wed, 19 Jun 2019 08:29:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 390ED208CB for ; Wed, 19 Jun 2019 08:29:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560932990; bh=0ll4DW7zH4OTUHDoryj5FvLDHB7fdZ2QkstqI9xjeOs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=H1tCqCzJ6+KRB/2eRxRMLorwtL6eN2jXtt4ioEGGkARXUSueMj+M5fFntLxz/srTS Z6d+R4CkAzB3nrAiDy+rYYZbr14Hw/VWwwreuZ12Dp4ZDD9LTCXTBviac+Vei2wU13 aZSgdewTXNXcwIqCvi5qJ0if0F8GNWjhwCazRCXY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731143AbfFSI3t (ORCPT ); Wed, 19 Jun 2019 04:29:49 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:37884 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731136AbfFSI3t (ORCPT ); Wed, 19 Jun 2019 04:29:49 -0400 Received: by mail-oi1-f195.google.com with SMTP id t76so9915860oih.4; Wed, 19 Jun 2019 01:29:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0ll4DW7zH4OTUHDoryj5FvLDHB7fdZ2QkstqI9xjeOs=; b=p9GkQ0abmd+ufpfTnHLyWHY5wp6XIaKZAGrFHPJP/EcZwi7pTGaIxeSr4t51YBqsP9 2Zk5wgpKMSUNeSegpnoZvRIVPibzsS9P+X9KOMcTNKTItoGoemSRoUTHkh2jUpylb0RV 8JMfAswR0LV2IeL6GrTl5xYUU+RSecRtAc/XkLw8l6NB6yB5Ejyoefx/MtV2WC/m1vRB 73WBMd4899sc19HusBdpCiD5SzHveSAXMCLznSyYkD9+gz6MdLEdumYuOkPH7AK4jgQx wBVtBJUSGwHlGBQ2QXgYDBrthpFLkMEoslBsuhVXJ/fKkTsxB3wyfHUudEygu+4aN7oS uYaw== X-Gm-Message-State: APjAAAXud/TiuvAvr4fCvCNilyMaDQzSuJ0qU+6Jbo5uY7JzWERULpDX kon8JNE1miEY/62Xecco8rnvbY/hFINR2GC0eSk= X-Google-Smtp-Source: APXvYqxAhgS2y9uBdRjy8zluvrnMxA6YhPLGCdPogicOQ0/567vNgcp4XWXL1z66OS5T5zc+Ne+sEufHlLhmXeHsr7Y= X-Received: by 2002:aca:d907:: with SMTP id q7mr1662790oig.68.1560932988746; Wed, 19 Jun 2019 01:29:48 -0700 (PDT) MIME-Version: 1.0 References: <7812857.KkDK7346ep@kreacher> <20190619001905.GA62571@dtor-ws> In-Reply-To: <20190619001905.GA62571@dtor-ws> From: "Rafael J. Wysocki" Date: Wed, 19 Jun 2019 10:29:37 +0200 Message-ID: Subject: Re: [PATCH] PM: suspend: Rename pm_suspend_via_s2idle() To: Dmitry Torokhov Cc: "Rafael J. Wysocki" , Linux PM , LKML , linux-input@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Wed, Jun 19, 2019 at 2:19 AM Dmitry Torokhov wrote: > > Hi Rafael, > > On Tue, Jun 18, 2019 at 10:18:28AM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > The name of pm_suspend_via_s2idle() is confusing, as it doesn't > > reflect the purpose of the function precisely enough and it is > > very similar to pm_suspend_via_firmware(), which has a different > > purpose, so rename it as pm_suspend_default_s2idle() and update > > its only caller, i8042_register_ports(), accordingly. > > > > Signed-off-by: Rafael J. Wysocki > > I assume you'll take it through your tree... I will. > Acked-by: Dmitry Torokhov Thanks!