* [PATCH] genirq/PM: Unexport {suspend,resume}_device_irqs()
@ 2022-06-10 7:40 Lukas Wunner
2022-06-10 13:33 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Wunner @ 2022-06-10 7:40 UTC (permalink / raw)
To: Thomas Gleixner, Rafael J. Wysocki; +Cc: linux-kernel, linux-pm
Ever since {suspend,resume}_device_irqs() were introduced in 2009
by commit 0a0c5168df27 ("PM: Introduce functions for suspending and
resuming device interrupts"), they've been exported even though there
are no module users and never will be: The functions are solely called
by the PM core, which is always built-in. Unexport them.
Signed-off-by: Lukas Wunner <lukas@wunner.de>
---
kernel/irq/pm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c
index ca71123a6130..c556bc49d213 100644
--- a/kernel/irq/pm.c
+++ b/kernel/irq/pm.c
@@ -147,7 +147,6 @@ void suspend_device_irqs(void)
synchronize_irq(irq);
}
}
-EXPORT_SYMBOL_GPL(suspend_device_irqs);
static void resume_irq(struct irq_desc *desc)
{
@@ -259,4 +258,3 @@ void resume_device_irqs(void)
{
resume_irqs(false);
}
-EXPORT_SYMBOL_GPL(resume_device_irqs);
--
2.35.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] genirq/PM: Unexport {suspend,resume}_device_irqs()
2022-06-10 7:40 [PATCH] genirq/PM: Unexport {suspend,resume}_device_irqs() Lukas Wunner
@ 2022-06-10 13:33 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2022-06-10 13:33 UTC (permalink / raw)
To: Lukas Wunner
Cc: Thomas Gleixner, Rafael J. Wysocki, Linux Kernel Mailing List, Linux PM
On Fri, Jun 10, 2022 at 9:41 AM Lukas Wunner <lukas@wunner.de> wrote:
>
> Ever since {suspend,resume}_device_irqs() were introduced in 2009
> by commit 0a0c5168df27 ("PM: Introduce functions for suspending and
> resuming device interrupts"), they've been exported even though there
> are no module users and never will be: The functions are solely called
> by the PM core, which is always built-in. Unexport them.
>
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
or I can take it if no one else does.
> ---
> kernel/irq/pm.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c
> index ca71123a6130..c556bc49d213 100644
> --- a/kernel/irq/pm.c
> +++ b/kernel/irq/pm.c
> @@ -147,7 +147,6 @@ void suspend_device_irqs(void)
> synchronize_irq(irq);
> }
> }
> -EXPORT_SYMBOL_GPL(suspend_device_irqs);
>
> static void resume_irq(struct irq_desc *desc)
> {
> @@ -259,4 +258,3 @@ void resume_device_irqs(void)
> {
> resume_irqs(false);
> }
> -EXPORT_SYMBOL_GPL(resume_device_irqs);
> --
> 2.35.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-10 13:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-10 7:40 [PATCH] genirq/PM: Unexport {suspend,resume}_device_irqs() Lukas Wunner
2022-06-10 13:33 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).