From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Sumeet Pawnikar <sumeet.r.pawnikar@intel.com>
Cc: "Zhang, Rui" <rui.zhang@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Shevchenko, Andriy" <andriy.shevchenko@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: Re: [PATCH] powercap: remove unused local MSR define
Date: Mon, 25 May 2020 11:01:02 +0200 [thread overview]
Message-ID: <CAJZ5v0jWtBK7jR3q64+4_9zVowORVp5rO9CMUDNhYVWMo_Yriw@mail.gmail.com> (raw)
In-Reply-To: <1590043466-11325-1-git-send-email-sumeet.r.pawnikar@intel.com>
On Thu, May 21, 2020 at 8:38 AM Sumeet Pawnikar
<sumeet.r.pawnikar@intel.com> wrote:
>
> Remove unused PLATFORM_POWER_LIMIT MSR local definition from file
> intel_rapl_common.c. This was missed while splitting old RAPL code
> intel_rapl.c file into two new files intel_rapl_msr.c and
> intel_rapl_common.c as per the commit 3382388d7148
> ("intel_rapl: abstract RAPL common code"). Currently, this #define
> entry is being used only in intel_rapl_msr.c file and local definition
> present in this file.
>
> Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> ---
> drivers/powercap/intel_rapl_common.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/powercap/intel_rapl_common.c b/drivers/powercap/intel_rapl_common.c
> index eb328655bc01..5527a7c76309 100644
> --- a/drivers/powercap/intel_rapl_common.c
> +++ b/drivers/powercap/intel_rapl_common.c
> @@ -26,9 +26,6 @@
> #include <asm/cpu_device_id.h>
> #include <asm/intel-family.h>
>
> -/* Local defines */
> -#define MSR_PLATFORM_POWER_LIMIT 0x0000065C
> -
> /* bitmasks for RAPL MSRs, used by primitive access functions */
> #define ENERGY_STATUS_MASK 0xffffffff
>
> --
Applied as 5.8 material, thanks!
next prev parent reply other threads:[~2020-05-25 9:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 6:44 [PATCH] powercap: remove unused local MSR define Sumeet Pawnikar
2020-05-25 9:01 ` Rafael J. Wysocki [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-20 11:36 Sumeet Pawnikar
2020-05-20 11:53 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0jWtBK7jR3q64+4_9zVowORVp5rO9CMUDNhYVWMo_Yriw@mail.gmail.com \
--to=rafael@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=sumeet.r.pawnikar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).