Linux-PM Archive on lore.kernel.org
 help / color / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Xin Hao <xhao@linux.alibaba.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linux PM <linux-pm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] cpufreq: CPPC: simply the code access 'highest_perf' value in cppc_perf_caps struct
Date: Thu, 2 Jul 2020 13:06:28 +0200
Message-ID: <CAJZ5v0jbsinLBZqNiCPH0NFk0b8H4Uxuf8U5y0R5nkxUH8tX8g@mail.gmail.com> (raw)
In-Reply-To: <20200702023746.li2uf4zl7bwzg62x@vireshk-i7>

On Thu, Jul 2, 2020 at 4:37 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 01-07-20, 14:16, Rafael J. Wysocki wrote:
> > On Wed, Jul 1, 2020 at 6:52 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > >
> > > On 01-07-20, 12:20, Xin Hao wrote:
> > > >  The 'caps' variable has been defined, so there is no need to get
> > > >  'highest_perf' value through 'cpu->caps.highest_perf', you can use
> > > >  'caps->highest_perf' instead.
> > > >
> > > > Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
> > > > ---
> > > >  drivers/cpufreq/cppc_cpufreq.c | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
> > > > index 257d726a4456..051d0e56c67a 100644
> > > > --- a/drivers/cpufreq/cppc_cpufreq.c
> > > > +++ b/drivers/cpufreq/cppc_cpufreq.c
> > > > @@ -161,7 +161,7 @@ static unsigned int cppc_cpufreq_perf_to_khz(struct cppc_cpudata *cpu,
> > > >               if (!max_khz)
> > > >                       max_khz = cppc_get_dmi_max_khz();
> > > >               mul = max_khz;
> > > > -             div = cpu->perf_caps.highest_perf;
> > > > +             div = caps->highest_perf;
> > > >       }
> > > >       return (u64)perf * mul / div;
> > > >  }
> > > > @@ -184,7 +184,7 @@ static unsigned int cppc_cpufreq_khz_to_perf(struct cppc_cpudata *cpu,
> > > >       } else {
> > > >               if (!max_khz)
> > > >                       max_khz = cppc_get_dmi_max_khz();
> > > > -             mul = cpu->perf_caps.highest_perf;
> > > > +             mul = caps->highest_perf;
> > > >               div = max_khz;
> > > >       }
> > >
> > > Applied. Thanks.
> >
> > I applied the previous cppc_cpufreq patch, hopefully it will not clash
> > with this one.
> >
> > Are you going to take care of this driver going forward?
>
> I started picking up the patches for this driver as it was mostly ARM
> stuff and FWIW, I picked the previous one as well and because it was
> sent by me, I never replied with the "Applied" message :)

But you could respond to the "applied" message from me. :-)

> Will it be possible for you to drop that one?

Dropped now and I will be assuming that you will pick up cppc_cpufreq
patches from now on.

Thanks!

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01  4:20 Xin Hao
2020-07-01  4:52 ` Viresh Kumar
2020-07-01 12:16   ` Rafael J. Wysocki
2020-07-02  2:37     ` Viresh Kumar
2020-07-02 11:06       ` Rafael J. Wysocki [this message]
2020-07-02 11:09         ` Viresh Kumar
2020-08-04  2:37 ` Xin Hao
2020-08-04  4:37   ` Viresh Kumar
2020-08-04  4:47     ` Xin Hao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJZ5v0jbsinLBZqNiCPH0NFk0b8H4Uxuf8U5y0R5nkxUH8tX8g@mail.gmail.com \
    --to=rafael@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=viresh.kumar@linaro.org \
    --cc=xhao@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-PM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pm/0 linux-pm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pm linux-pm/ https://lore.kernel.org/linux-pm \
		linux-pm@vger.kernel.org
	public-inbox-index linux-pm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git