From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15F7EC433B4 for ; Thu, 8 Apr 2021 16:00:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5BBA610F8 for ; Thu, 8 Apr 2021 16:00:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231923AbhDHQAu (ORCPT ); Thu, 8 Apr 2021 12:00:50 -0400 Received: from mail-ot1-f53.google.com ([209.85.210.53]:34687 "EHLO mail-ot1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231791AbhDHQAu (ORCPT ); Thu, 8 Apr 2021 12:00:50 -0400 Received: by mail-ot1-f53.google.com with SMTP id k14-20020a9d7dce0000b02901b866632f29so2793116otn.1 for ; Thu, 08 Apr 2021 09:00:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dmLOvdI0zsV5U+neZZqzTs4DMkJ1UXpiBzEy9litWBE=; b=a7HkRP5cTpiyQDuqnHCQVF/br8XUXM/+fQQapaNcJxOVCXhcALmDW5ie710x46aHGK mRw2OOzctxcaGkZXdTXxcTdgvZ019Ps7QM0QxKemKbaK/Fsa3uHE2V7OicAITYVPCJLH 17AVjtafuVLem9+G2y8+n+j4AzvsyS+GqtI/IsdwKOs57YQ5Nftzc3UWIqCT/T5PHkwY L3e9edgxCYwktmtCtPli7ubc+dN1pM6gb2tVHYkJn4fgUJKYIsQO6kEqsNl3Nlnz1Z+M y0kqb7nywaVLjusQD+2+tXiaVI+0lSH+2R/1ESAkxVpc5MkoLLGIA22SL1MnpsBAGTvf ekag== X-Gm-Message-State: AOAM531IJATFQjcN968tDoHl3umldJh6008Lrc4whXmxqSGqpeWG7CI0 w9p0+xgqKdT/Jn9cJi8AGv3f7Xq9IQPGo675hig= X-Google-Smtp-Source: ABdhPJxsN2XtRuw+20Awbtf8iwV9qhcPySLgYbKnvLeqcH25R178NSZjZTezwUlJ612/uIQMlLvifprHQ+p6bXzs02A= X-Received: by 2002:a05:6830:1e03:: with SMTP id s3mr8425117otr.321.1617897638739; Thu, 08 Apr 2021 09:00:38 -0700 (PDT) MIME-Version: 1.0 References: <20210408152209.GA1299604@rowland.harvard.edu> In-Reply-To: <20210408152209.GA1299604@rowland.harvard.edu> From: "Rafael J. Wysocki" Date: Thu, 8 Apr 2021 18:00:27 +0200 Message-ID: Subject: Re: [PATCH] PM: Add documentation for pm_runtime_resume_and_get() To: Alan Stern Cc: "Rafael J. Wysocki" , Zhang Qilong , Linux-PM mailing list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, Apr 8, 2021 at 5:22 PM Alan Stern wrote: > > Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to > deal with usage counter") added a new runtime-PM API function without > adding any documentation for it. Well, there is a kerneldoc comment which counts as documentation, so I'd rather say "without updating the documentation in runtime_pm.rst". > This patch adds the missing documentation. But otherwise fair enough. > Signed-off-by: Alan Stern > CC: Zhang Qilong > Fixes: dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") > > --- > > > [as1954] > > > Documentation/power/runtime_pm.rst | 4 ++++ > 1 file changed, 4 insertions(+) > > Index: usb-devel/Documentation/power/runtime_pm.rst > =================================================================== > --- usb-devel.orig/Documentation/power/runtime_pm.rst > +++ usb-devel/Documentation/power/runtime_pm.rst > @@ -339,6 +339,10 @@ drivers/base/power/runtime.c and include > checked additionally, and -EACCES means that 'power.disable_depth' is > different from 0 > > + `int pm_runtime_resume_and_get(struct device *dev);` > + - run pm_runtime_resume(dev) and if successful, increment the device's > + usage counter; return the result of pm_runtime_resume > + > `int pm_request_idle(struct device *dev);` > - submit a request to execute the subsystem-level idle callback for the > device (the request is represented by a work item in pm_wq); returns 0 on