From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24AA0C433E8 for ; Tue, 14 Jul 2020 16:35:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EFD6C22518 for ; Tue, 14 Jul 2020 16:35:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594744534; bh=R9WJikLkWQvHqtvHu+mFYozfwPs9zbuJa310V9wJUL4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=HvSS/ylUkRZw9Ly21oG4vEmqhBJra6cGiNYmy1/z8/iTTLv6+Rx6tjwK/J0rROvLn wVD5OK/8W2LJ171t08GdV/j3NwwTFuVsugztTpKWsUdw27/UVfhhRBwhXttXDT32Sg HP5dMfD21xY1q+Q/5YiGaY6wqfBDL7/MUMbheLLM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728704AbgGNQfd (ORCPT ); Tue, 14 Jul 2020 12:35:33 -0400 Received: from mail-oo1-f68.google.com ([209.85.161.68]:44529 "EHLO mail-oo1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728509AbgGNQfc (ORCPT ); Tue, 14 Jul 2020 12:35:32 -0400 Received: by mail-oo1-f68.google.com with SMTP id o36so3442716ooi.11; Tue, 14 Jul 2020 09:35:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xq4tKGNRH3KriixnxCn9uJFwafu8U4KY8hX/LfJhHus=; b=YiDs65eV485lrt+lW5nub63ID42gtwNLyWQEU1PL09Oyw8qNqgjQB1f26GTBdYNH63 KI1ciMuKYb6BVEih/5QOZC3kiuJENxc5yU7c4axemexASwJanxwD28pXLV+Hq+6sK/ij 4Ye17M4vUHrKmrvvtWpdWt/Y5+rUewW0qZovF/QBBwXbNYor6FsJus0XAdXrLK0ahrs3 cPwPR2uNByIFC6UnJuLRtfswP9fkT5ddhuN/WHBMp58I1Wjhdr052t52GljFmGJe3X/u G+pvQnTM+8NuSZBLCUOz2FqaUJw2UV/v6Pg1SxIeJa2tj7PBMjRKHw3ASXCBsO55enHx jeqw== X-Gm-Message-State: AOAM5304/4XHSClLe3ptCo/WL5szvn/MqOrQ8O8g9Htuv7AmyvzRkwXk nar/+YIkFtqVQrMs2Bdlfe30UBdFRoYK6hWOrYDdYw== X-Google-Smtp-Source: ABdhPJx9jwksQchlp8EzWcp4jDpRaQL5RgS6YS+xhSCdQj4OcOM3zMN5IV/4G0I2X0imPOE8KPCwOaKZyOkoPAp3Hf8= X-Received: by 2002:a4a:3e48:: with SMTP id t69mr5360935oot.38.1594744531359; Tue, 14 Jul 2020 09:35:31 -0700 (PDT) MIME-Version: 1.0 References: <20200714145049.2496163-1-lee.jones@linaro.org> <20200714145049.2496163-13-lee.jones@linaro.org> In-Reply-To: <20200714145049.2496163-13-lee.jones@linaro.org> From: "Rafael J. Wysocki" Date: Tue, 14 Jul 2020 18:35:19 +0200 Message-ID: Subject: Re: [PATCH 12/13] cpufreq: intel_pstate: Supply struct attribute description for get_aperf_mperf_shift() To: Lee Jones Cc: "Rafael J. Wysocki" , Viresh Kumar , Linux ARM , Linux Kernel Mailing List , Linux PM , Srinivas Pandruvada , Len Brown , Dirk Brandewie Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, Jul 14, 2020 at 4:51 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/cpufreq/intel_pstate.c:293: warning: Function parameter or member 'get_aperf_mperf_shift' not described in 'pstate_funcs' > > Cc: Srinivas Pandruvada > Cc: Len Brown > Cc: Dirk Brandewie > Signed-off-by: Lee Jones > --- > drivers/cpufreq/intel_pstate.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > index 44c7b4677675d..f92fc69c87269 100644 > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -275,6 +275,8 @@ static struct cpudata **all_cpu_data; > * @get_min: Callback to get minimum P state > * @get_turbo: Callback to get turbo P state > * @get_scaling: Callback to get frequency scaling factor > + * @get_aperf_mperf_shift: Callback to get the number of clock cycles after > + * aperf, merf is incremented This added description is inaccurate. It should be something like "Callback to get the APERF vs MPERF frequency difference". > * @get_val: Callback to convert P state to actual MSR write value > * @get_vid: Callback to get VID data for Atom platforms > * > --