From: "Rafael J. Wysocki" <rafael@kernel.org>
To: "Kenneth R. Crudup" <kenny@panix.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
Linux PM <linux-pm@vger.kernel.org>
Subject: Re: Help me fix a regression caused by 56b9918490 (PM: sleep: Simplify suspend-to-idle control flow)
Date: Mon, 25 Nov 2019 22:47:08 +0100 [thread overview]
Message-ID: <CAJZ5v0jmQcQJ75W0FCod_=+_EBAVADxZiseNXRM+s9McrNnk1Q@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1911251019100.12067@hp-x360n>
On Mon, Nov 25, 2019 at 7:27 PM Kenneth R. Crudup <kenny@panix.com> wrote:
>
>
> On Mon, 25 Nov 2019, Rafael J. Wysocki wrote:
>
> > > I'll send you a patch to try for that.
>
> > Appended (untested).
>
> This is promising! I've only tested a handful of suspend cycles, but so far:
>
> - Charging events don't wake it up
> - It suspends with the charger connected
> - Suspend current draw consistently gets to the lowest idle point
> - It always comes back from suspend, even after connecting a charger when suspended
>
> ... IOW, everything just seems to work, and better than before. I just
> remembered why I had to use "ec_no_wakeup" (pre suspend-rework) in the first
> place- this is a convertible and accelerometer events would take the laptop
> out of (and immediately back into) suspend and your rework fixed that but then
> I had the issues listed in my original E-mail.
>
> I'll keep testing it (and the best way to get something to break is to proclaim
> it's "fixed" :), but for now I'm pretty happy with the patch.
Well, so with this patch the problem is at least not reproducible
readily it seems?
next prev parent reply other threads:[~2019-11-25 21:47 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 0:11 Help me fix a regression caused by 56b9918490 (PM: sleep: Simplify suspend-to-idle control flow) Kenneth R. Crudup
2019-11-22 10:12 ` Rafael J. Wysocki
2019-11-22 12:45 ` Rafael J. Wysocki
2019-11-22 17:35 ` Kenneth R. Crudup
2019-11-23 10:24 ` Kenneth R. Crudup
2019-11-24 16:02 ` Rafael J. Wysocki
2019-11-25 3:40 ` Kenneth R. Crudup
2019-11-25 13:27 ` Rafael J. Wysocki
2019-11-25 14:14 ` Rafael J. Wysocki
2019-11-25 18:27 ` Kenneth R. Crudup
2019-11-25 20:11 ` Kenneth R. Crudup
2019-11-25 20:19 ` Kenneth R. Crudup
2019-11-25 22:01 ` Rafael J. Wysocki
2019-11-25 23:32 ` Kenneth R. Crudup
2019-11-26 8:50 ` Rafael J. Wysocki
2019-11-26 16:12 ` Rafael J. Wysocki
2019-11-26 16:15 ` Kenneth R. Crudup
2019-11-26 16:27 ` Rafael J. Wysocki
2019-11-26 16:35 ` Kenneth R. Crudup
2019-11-26 18:48 ` Rafael J. Wysocki
2019-11-26 19:03 ` Kenneth R. Crudup
2019-11-26 19:09 ` Rafael J. Wysocki
2019-11-26 19:13 ` Kenneth R. Crudup
2019-11-26 19:45 ` Kenneth R. Crudup
2019-11-26 23:56 ` Kenneth R. Crudup
2019-11-27 2:35 ` Kenneth R. Crudup
2019-11-27 8:31 ` Rafael J. Wysocki
2019-11-27 22:30 ` Kenneth R. Crudup
2019-11-28 16:25 ` Rafael J. Wysocki
2019-11-25 21:47 ` Rafael J. Wysocki [this message]
2019-11-25 16:21 ` Kenneth R. Crudup
2019-11-25 21:46 ` Rafael J. Wysocki
2019-11-25 23:02 ` Kenneth R. Crudup
2019-11-26 8:53 ` Rafael J. Wysocki
2019-11-25 5:50 ` Kenneth R. Crudup
2019-11-25 7:17 ` Kenneth R. Crudup
2019-11-22 17:29 ` Kenneth R. Crudup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0jmQcQJ75W0FCod_=+_EBAVADxZiseNXRM+s9McrNnk1Q@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=kenny@panix.com \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).