From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8236C432C0 for ; Mon, 25 Nov 2019 21:47:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF71B2071A for ; Mon, 25 Nov 2019 21:47:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574718441; bh=lPHCx/sblkspJQGTIlPXyxa/zo6J9XFw5JrT7MglmcM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=tAIEC6awlL3S+vHUTrywgToh1MYiii0tz5qlmdtj1qd9GLfm/cNFB4OVWuIA6cb/B l94epII9ZSb8hDiSH2g7LI6wB1q7zDuGFMy6ra0i37kc7Z9T64qjuuY8ovI5Me4ZZa 6gEwKpmsyMwmj7SMssIB0Ns4uUIQfwfxGJ+QdU50= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726984AbfKYVrV (ORCPT ); Mon, 25 Nov 2019 16:47:21 -0500 Received: from mail-oi1-f171.google.com ([209.85.167.171]:43649 "EHLO mail-oi1-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725912AbfKYVrU (ORCPT ); Mon, 25 Nov 2019 16:47:20 -0500 Received: by mail-oi1-f171.google.com with SMTP id l20so14605616oie.10 for ; Mon, 25 Nov 2019 13:47:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lPHCx/sblkspJQGTIlPXyxa/zo6J9XFw5JrT7MglmcM=; b=bPShaGJFZz+kXUyWRLuRwFZ0VWbWAPaLJCXIf4ApRKc02rffyteKVtFUFLQLnEdk2p oRYhpj2LhI1pcIFNd5TEtquIPrf+NrhBmFw7qEhhi6aOHyP4kQr1a+6Tmf4lcR5/cqXP aCSMRCWPa+3tyFpzPsHO/xWKcSECvvKZBh65XJ3o+4/bRqCXeaChm5rLUKerpnqyLDzg bM7HbNPz194FYkSREwCQtcwHPSeUzg75zpb26W22Oa8YIMw9eVq0FHhYer6DNAljRvg+ uM2uud3hqiLrebIb2Lfuf4TgHhQMqqC5m5U7m3ulx2R4i33KDF8XS2pXrRZvKOocQ6Nb lLuQ== X-Gm-Message-State: APjAAAX/KmNP2PvIx5Ym1vqE8j4r7vbTPsJ/jzr2snn8mEG80CEUbMRH OODu/W6VBCybFFkuPi1E9tvs0b97HO4Nctjlrec= X-Google-Smtp-Source: APXvYqwktxIlZzSWtDhbsbNizq7IHo9PW0gyvx81LrnR4xysTcDI3qo/iAFMdfSaiq9Cgf/i4sVzn7tbEwvy6VQT/tI= X-Received: by 2002:a05:6808:901:: with SMTP id w1mr849434oih.57.1574718439912; Mon, 25 Nov 2019 13:47:19 -0800 (PST) MIME-Version: 1.0 References: <2977390.9qzeJo7xji@kreacher> In-Reply-To: From: "Rafael J. Wysocki" Date: Mon, 25 Nov 2019 22:47:08 +0100 Message-ID: Subject: Re: Help me fix a regression caused by 56b9918490 (PM: sleep: Simplify suspend-to-idle control flow) To: "Kenneth R. Crudup" Cc: "Rafael J. Wysocki" , "Rafael J. Wysocki" , Rafael Wysocki , Linux PM Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Nov 25, 2019 at 7:27 PM Kenneth R. Crudup wrote: > > > On Mon, 25 Nov 2019, Rafael J. Wysocki wrote: > > > > I'll send you a patch to try for that. > > > Appended (untested). > > This is promising! I've only tested a handful of suspend cycles, but so far: > > - Charging events don't wake it up > - It suspends with the charger connected > - Suspend current draw consistently gets to the lowest idle point > - It always comes back from suspend, even after connecting a charger when suspended > > ... IOW, everything just seems to work, and better than before. I just > remembered why I had to use "ec_no_wakeup" (pre suspend-rework) in the first > place- this is a convertible and accelerometer events would take the laptop > out of (and immediately back into) suspend and your rework fixed that but then > I had the issues listed in my original E-mail. > > I'll keep testing it (and the best way to get something to break is to proclaim > it's "fixed" :), but for now I'm pretty happy with the patch. Well, so with this patch the problem is at least not reproducible readily it seems?