From: "Rafael J. Wysocki" <rafael@kernel.org>
To: "Bhardwaj, Rajneesh" <rajneesh.bhardwaj@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Len Brown <len.brown@intel.com>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 2/2] powercap/rapl: Add Ice Lake NNPI support to RAPL driver
Date: Thu, 25 Jul 2019 10:25:36 +0200 [thread overview]
Message-ID: <CAJZ5v0jticmMH_txuYgDzXU9K1FYfHLB7PFmBAuvz9DEvz5=5Q@mail.gmail.com> (raw)
In-Reply-To: <23df19ca-1ec5-ce9b-9862-29d33008e581@linux.intel.com>
On Thu, Jul 25, 2019 at 10:03 AM Bhardwaj, Rajneesh
<rajneesh.bhardwaj@linux.intel.com> wrote:
>
> Hi Rafael
>
> On 28-Jun-19 3:32 AM, Rafael J. Wysocki wrote:
> > On Friday, June 14, 2019 10:05:23 AM CEST Rajneesh Bhardwaj wrote:
> >> Enables support for ICL-NNPI, which is a neural network processor for deep
> >> learning inference. From RAPL point of view it is same as Ice Lake Mobile
> >> processor.
> >>
> >> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> >> Cc: linux-pm@vger.kernel.org
> >> Link: https://lkml.org/lkml/2019/6/5/1034
> >> Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
> >> ---
> >> drivers/powercap/intel_rapl.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
> >> index 4347f15165f8..431c8c8bdf07 100644
> >> --- a/drivers/powercap/intel_rapl.c
> >> +++ b/drivers/powercap/intel_rapl.c
> >> @@ -1157,6 +1157,7 @@ static const struct x86_cpu_id rapl_ids[] __initconst = {
> >> INTEL_CPU_FAM6(KABYLAKE_DESKTOP, rapl_defaults_core),
> >> INTEL_CPU_FAM6(CANNONLAKE_MOBILE, rapl_defaults_core),
> >> INTEL_CPU_FAM6(ICELAKE_MOBILE, rapl_defaults_core),
> >> + INTEL_CPU_FAM6(ICELAKE_NNPI, rapl_defaults_core),
> >>
> >> INTEL_CPU_FAM6(ATOM_SILVERMONT, rapl_defaults_byt),
> >> INTEL_CPU_FAM6(ATOM_AIRMONT, rapl_defaults_cht),
> >>
> > It is in my queue, but I get build errors when I try to apply it.
> >
> > I guess the definition of ICELAKE_NNPI is not there in the Linus' tree yet.
>
> The dependent patch is now available in mainline, so can you please
> apply this one?
>
> https://github.com/torvalds/linux/blob/bed38c3e2dca01b358a62b5e73b46e875742fd75/arch/x86/include/asm/intel-family.h#L59
It's already been applied along with the Rui's series.
next prev parent reply other threads:[~2019-07-25 8:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 8:05 [PATCH 2/2] powercap/rapl: Add Ice Lake NNPI support to RAPL driver Rajneesh Bhardwaj
2019-06-27 22:02 ` Rafael J. Wysocki
2019-06-28 8:21 ` Bhardwaj, Rajneesh
2019-07-05 10:13 ` Rafael J. Wysocki
2019-07-25 8:01 ` Bhardwaj, Rajneesh
2019-07-25 8:03 ` Bhardwaj, Rajneesh
2019-07-25 8:25 ` Rafael J. Wysocki [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-06-14 7:39 [PATCH 1/2] tools/power turbostat: Add Ice Lake NNPI support Rajneesh Bhardwaj
2019-06-14 7:39 ` [PATCH 2/2] powercap/rapl: Add Ice Lake NNPI support to RAPL driver Rajneesh Bhardwaj
2019-06-14 7:49 ` Bhardwaj, Rajneesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0jticmMH_txuYgDzXU9K1FYfHLB7PFmBAuvz9DEvz5=5Q@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rajneesh.bhardwaj@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).