From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 048CAC33C99 for ; Tue, 7 Jan 2020 10:59:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CFB5F2087F for ; Tue, 7 Jan 2020 10:59:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578394761; bh=zay0kHk1hg35/KhGM7JyWLhD1jYmM955T6QYMkMBH0M=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=cHWyNRjqPjud4s/iY5VmqN4NE6alSqFXS5dl0DWXgdSKNfZoeTpIfw5vMdUeb4jV7 sPgXRixhcFy9uByUpYpGxNlCa27oOMb9jRI08OPGvMJ4quvGkbt4t749MoXJ4zOxDe D08tAV2+fMEmmObSGbA0b2cQyMKKZakk/aMLtx/Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727273AbgAGK7S (ORCPT ); Tue, 7 Jan 2020 05:59:18 -0500 Received: from mail-ot1-f66.google.com ([209.85.210.66]:41979 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727177AbgAGK7R (ORCPT ); Tue, 7 Jan 2020 05:59:17 -0500 Received: by mail-ot1-f66.google.com with SMTP id r27so75933016otc.8; Tue, 07 Jan 2020 02:59:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TzQpxAWpBjjHGr3KKrvvbrwcil+/kjftdWNGOuYtDAI=; b=ckSDLWvXjqH+BkAbu/8h/nMInKjjHV1uCp0oQXsOIx0YIH9kmf0PtOpuPwYmJKMsEZ hqgy8zmliCvevGi6KHDq0zl34NQaf61KlgjJkEKZrNWu7CI2ZURAGQ6TCNJtrDJHGpdY DBkqrpAWpuxjThy1XIdYUpeVlVDoYS4YK7HAVMNxTu6y2EG50NN+YPBNPq3W8JsE+SbA mtB3UoLFDT9+pcXMzG2FKwbMSejZxfn5wE/dF4jFVERRXSZj8JVK8Bv9dyk0YVBY1h7U /Kgpt5hWlUNMNaBVQEOE3H5TZpX4ZEFviAr1Sje0ujcmkbuVxl7+/iACv14Mwfm4bNGO e4Jw== X-Gm-Message-State: APjAAAXRv04VdjkwQRvsrCyOrTRUNJZtmhfGwBVDp3jxwwEO9Fc0B+Te eomv/o5w4uH7UDqF8eMb7QyFvyNzeNOrvFjQMqg= X-Google-Smtp-Source: APXvYqxDfK07U/wMncRfQCZHxtfHO04TlLY8Ae2d+UTpTfFq86JlFtKF5/CqpNnccY1AB/fvpOWFP/U/y2yLWMZ29KM= X-Received: by 2002:a05:6830:1651:: with SMTP id h17mr114709103otr.167.1578394756732; Tue, 07 Jan 2020 02:59:16 -0800 (PST) MIME-Version: 1.0 References: <20200106120558.37758-1-colin.king@canonical.com> <20200106191458.GV3755841@builder> In-Reply-To: <20200106191458.GV3755841@builder> From: "Rafael J. Wysocki" Date: Tue, 7 Jan 2020 11:59:05 +0100 Message-ID: Subject: Re: [PATCH][next] power: avs: fix uninitialized error return on failed cpr_read_fuse_uV call To: Bjorn Andersson , Colin King Cc: Andy Gross , Niklas Cassel , Kevin Hilman , Nishanth Menon , "Rafael J . Wysocki" , Jorge Ramirez-Ortiz , Ulf Hansson , linux-arm-msm , Linux PM , kernel-janitors@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Jan 6, 2020 at 8:15 PM Bjorn Andersson wrote: > > On Mon 06 Jan 04:05 PST 2020, Colin King wrote: > > > From: Colin Ian King > > > > Currently when the call cpr_read_fuse_uV returns an error the value in the > > uninitialized variable ret is returned. Fix this by instread returning the > > error value in the variable uV. > > > > Reviewed-by: Bjorn Andersson Applied, thanks! > > Addresses-Coverity: ("Uninitialized scalar variable") > > Fixes: bf6910abf548 ("power: avs: Add support for CPR (Core Power Reduction)") > > Signed-off-by: Colin Ian King > > --- > > drivers/power/avs/qcom-cpr.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c > > index 9247f53550b3..0321729431a5 100644 > > --- a/drivers/power/avs/qcom-cpr.c > > +++ b/drivers/power/avs/qcom-cpr.c > > @@ -922,7 +922,7 @@ static int cpr_fuse_corner_init(struct cpr_drv *drv) > > uV = cpr_read_fuse_uV(desc, fdata, fuses->init_voltage, > > step_volt, drv); > > if (uV < 0) > > - return ret; > > + return uV; > > > > fuse->min_uV = fdata->min_uV; > > fuse->max_uV = fdata->max_uV; > > --