From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ADD0C433E0 for ; Thu, 21 May 2020 12:23:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 35BEB2070A for ; Thu, 21 May 2020 12:23:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DfOg8Qx/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727983AbgEUMXM (ORCPT ); Thu, 21 May 2020 08:23:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727969AbgEUMXM (ORCPT ); Thu, 21 May 2020 08:23:12 -0400 Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39CA3C061A0E; Thu, 21 May 2020 05:23:12 -0700 (PDT) Received: by mail-io1-xd42.google.com with SMTP id c16so7205254iol.3; Thu, 21 May 2020 05:23:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=dLRlXkQKfLYkmmwJc2IRcOiGHBn9i2amIFILrmeGCPA=; b=DfOg8Qx/GufnehWDt+lldTEiy0PT1YFGmMI0o0T6PYZezyt5e8QPWegcsRaT1sBEQz Z+8nlQHyvtRQKn4elyeRBmfdUxZfkCapBnyKlCCZzz5DIUgnPm4kebeJbsWBCBpY7hYB WpMMlmKcX/K6IMjT4u6pdGOc/ewXtu4OZxLiUwNmZA1xc/SNzTDljD6+E7SWwM5NgHAV TZFGdZrdWaI9S6s+qmRlMGQbLqpJqEqcBaFh/Fp3dztYb4+OfoiiKSPPSIBQX/BKlPak f42zgIaY6uWY9xWffR4WGtv2dXC3K/Xhab2VcgWIT4j+rZrtD09pwwXfV+DAf7Hvvv9n oUTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=dLRlXkQKfLYkmmwJc2IRcOiGHBn9i2amIFILrmeGCPA=; b=oOZxhu9CC9m4mCqLjQZDYLBa4UeFb16KOMfmvY6kir/63zjEZBPBzAzdsJ/+RtUTb7 arJfK18m8KjFdxK1znu9L/Xi+pCl67ft9tqtn/PfUT+8UWiAIBGSG/hQaEBjO+syMCgY K/IhJxA0QDCMw1z7fM+U0UfMYdbmwCrXeBV4ZZ6gmMt32DDWKPneqKoDbqw4OE93PTEG qEwhuAJsqMCiTkFVJEi1QktM3hthmcIZtOaKCwji59/KEyGPZQ89GK4skA9ces2vfhIG j21N++CDSZnBfiQ/MXsN4aUulHIzOZy/NK0WVASNOHGevtDryL7U53gFu+pj2/2bwJeE 4asQ== X-Gm-Message-State: AOAM530XWcZXgv9LdwTxfnIcu1NVzT+6CDC8jGA1w30iEcDZRyfKnxLA VO9ITZ2n57FJBzk35mLpI6lB8ciEVS6z8Wl5OtUGFpW/QsI= X-Google-Smtp-Source: ABdhPJxywRNWuEXqqJHmt35W0FgGHaOdScBGeQjIVzBw0Z3F5o/E5GG+U12fvQC0HIN/IrZPLnupCYcFH2Y5OJ9GrQI= X-Received: by 2002:a02:ccd6:: with SMTP id k22mr3488037jaq.18.1590063791246; Thu, 21 May 2020 05:23:11 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Thu, 21 May 2020 14:23:00 +0200 Message-ID: Subject: Re: [PATCH 0/2] opp: core: add regulators enable and disable To: Viresh Kumar Cc: k.konieczny@samsung.com, Marek Szyprowski , Nishanth Menon , Stephen Boyd , Viresh Kumar , "open list:ALLWINNER CPUFREQ DRIVER" , Vincent Guittot , Rafael Wysocki , Mark Brown , linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi, On Fri, 15 May 2020 at 14:00, Cl=C3=A9ment P=C3=A9ron wrote: > > Hi Viresh, > > On Fri, 15 May 2020 at 09:57, Viresh Kumar wrot= e: > > > > Hi, > > > > This series reintroduces the usage of regulator_enable/disable() to the > > OPP core after the previous attempt was reverted [1] shortly after gett= ing > > applied. This time the regulator is enabled only after it is configured > > by the OPP core. > > > > Marek, Kamil and Cl=C3=A9ment: Can you guys please test this out and re= port > > if this doesn't work as expected ? > > I have reviewed the patch and it seems fine for my use case. > Unfortunately I can't test it until next week. Ok, before the patch the regulator was released by regulator_late_cleanup()= : [ 33.756849] vdd-gpu: disabling Now it works fine and the vdd-gpu is no more disabled. Tested-by: Cl=C3=A9ment P=C3=A9ron Regards, Clement > > Acked-by: Cl=C3=A9ment P=C3=A9ron > > Regards, > Clement > > > > > > -- > > viresh > > > > [1] https://lore.kernel.org/lkml/20191017102758.8104-1-m.szyprowski@sam= sung.com/ > > > > Kamil Konieczny (1): > > opp: core: add regulators enable and disable > > > > Viresh Kumar (1): > > opp: Reorder the code for !target_freq case > > > > drivers/opp/core.c | 39 ++++++++++++++++++++++++++++++++++----- > > drivers/opp/opp.h | 2 ++ > > 2 files changed, 36 insertions(+), 5 deletions(-) > > > > -- > > 2.25.0.rc1.19.g042ed3e048af > >