From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2C14C3F2CD for ; Mon, 2 Mar 2020 17:46:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD3BD214DB for ; Mon, 2 Mar 2020 17:46:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bhPvEOjm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727231AbgCBRqt (ORCPT ); Mon, 2 Mar 2020 12:46:49 -0500 Received: from mail-vk1-f195.google.com ([209.85.221.195]:43029 "EHLO mail-vk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727126AbgCBRqt (ORCPT ); Mon, 2 Mar 2020 12:46:49 -0500 Received: by mail-vk1-f195.google.com with SMTP id o2so44587vka.10 for ; Mon, 02 Mar 2020 09:46:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wRqcBb5NeC8MFmcr1zGXioEPHZAa7v+ogkQOpmNZPmY=; b=bhPvEOjmCSdagKL7wbSNn+LctUqd1mSHmEn2xDEvGzkuiK6UcHtyC+lxQPBpQlis9b MH79TeTlsFO7qPTBa6z4411JqMqW02pV/UZzr7nzeLdlB06ZAyi+pqcIdU9APksPYo90 nUEWiNOWR0xD7j7ZSZMY7pDlZNRy4e+PnpIbfx6SKAz25tzKMc0nQ5KgTJhLyI0UbjFR H3wO7m6+wqBA2WjrG8+3fwWwHTSsGKwniZhDKBbmB9ntCpx4qOEDeojx6XTsRw3deXyz rGSuijN9djreVn1bWwoVZMSunjpo6Cp14oV/CsDb92SZz4nWSLWY6P94qaqIttgdND+9 GVoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wRqcBb5NeC8MFmcr1zGXioEPHZAa7v+ogkQOpmNZPmY=; b=CnTjyWP/Kh3s5srW+1VJSrueJeyK7zTV1XEgbX84vTO7MRhNeC6UWScoIsU62/l6yv ta9wWxRsxk4vyWoAkSrVBgyuYi5P6Z7EoahkgxIQj0zAZrTJA8O6J4b6jNUCK5X0FJbi 6NgYcrkSjRINvWBmYb7dElGVGdJKmWjy6tTT0Ma/fylj3BNMJX3iBcI+FyL2sti6H/7+ nNsUVA/8V9Zm5clbukerMWHTcYzcaR9VNChwadgp9jLOqap/d+RmELn41BzCWjSQ5rHu 6PU/nA8OsbVj6+DAsbIYx2rRcU65Aa6ieeqRUlkJFzzpcgJrO2eIKwFqCL984gFezsil f+qQ== X-Gm-Message-State: ANhLgQ3sK+Z8kIuKGwosB+sl9AhsVLQRe0TIultMWlUYrG6lgJzjpEZg tjLy73S2zPy5DmoCOzTQ7B0fJCsjs0QHouJf7xURVA== X-Google-Smtp-Source: ADFU+vvI4v1XSZF009wAi9uAcVVON3h+bKuIxN4MJslrz6LFmkBZ04IXzw5whl+Td9/Njl7w5J59jkiRYYRU3oMTDDU= X-Received: by 2002:a1f:5385:: with SMTP id h127mr542849vkb.56.1583171207966; Mon, 02 Mar 2020 09:46:47 -0800 (PST) MIME-Version: 1.0 References: <20200219183231.50985-1-balejs@google.com> <20200229005131.GB9813@google.com> <20200229184300.GA484762@carbon.DHCP.thefacebook.com> <20200301162003.GA186618@google.com> <20200302165330.GA505299@carbon.DHCP.thefacebook.com> In-Reply-To: <20200302165330.GA505299@carbon.DHCP.thefacebook.com> From: Suren Baghdasaryan Date: Mon, 2 Mar 2020 09:46:36 -0800 Message-ID: Subject: Re: [PATCH] cgroup-v1: freezer: optionally killable freezer To: Roman Gushchin Cc: Marco Ballesio , Tejun Heo , cgroups mailinglist , LKML , Li Zefan , Johannes Weiner , Jonathan Corbet , rjw@rjwysocki.net, pavel@ucw.cz, len.brown@intel.com, linux-doc@vger.kernel.org, linux-pm@vger.kernel.org, Minchan Kim , Daniel Colascione Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Mar 2, 2020 at 8:53 AM Roman Gushchin wrote: > > On Sun, Mar 01, 2020 at 08:20:03AM -0800, Marco Ballesio wrote: > > On Sat, Feb 29, 2020 at 10:43:00AM -0800, Roman Gushchin wrote: > > > On Fri, Feb 28, 2020 at 04:51:31PM -0800, Marco Ballesio wrote: > > > > Hi all, > > > > > > > > did anyone have time to look into my proposal and, in case, are there > > > > any suggestions, ideas or comments about it? > > > > > > Hello, Marco! > > > > > > I'm sorry, somehow I missed the original letter. > > > > > > In general the cgroup v1 interface is considered frozen. Are there any particular > > > reasons why you want to extend the v1 freezer rather than use the v2 version of it? > > > > > > You don't even need to fully convert to cgroup v2 in order to do it, some v1 > > > controllers can still be used. > > > > > > Thanks! > > > > > > Roman > > > > Hi Roman, > > > > When compared with backports of v2 features and their dependency chains, this > > patch would be easier to carry in Android common. The potential is to have > > killability for frozen processes on hw currently in use. > Hi Roman, > I see... > > The implementation looks good to me, but I really not sure if adding new control files > to cgroup v1 is a good idea at this point. Are there any plans in the Android world > to move forward to cgroup v2? If not, why not? There are plans to prototype that and gradually move from cgroups v1 to v2 at least for some cgroup controllers (the ones that can use unified hierarchy). Creating an additional per-process cgroup v2 hierarchy only for freezer would be a high price to pay today. In the future when we migrate some controllers to v2 the price will be amortized and we will probably be able to do that. > If there are any specific issues/dependencies, let's discuss and resolve them. > > Thanks! > > Roman Thanks, Suren.