From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6185C48BE5 for ; Wed, 16 Jun 2021 10:03:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AEB06613C1 for ; Wed, 16 Jun 2021 10:03:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232418AbhFPKFM (ORCPT ); Wed, 16 Jun 2021 06:05:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232331AbhFPKFA (ORCPT ); Wed, 16 Jun 2021 06:05:00 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F56DC061768 for ; Wed, 16 Jun 2021 03:02:50 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id r198so3316380lff.11 for ; Wed, 16 Jun 2021 03:02:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/4RwAjXPtC218FslHiEhUYGCqGEWToA3TK5+6fZBZNA=; b=W++LxgSclajmCz1OuVwxJUxeVJT7cnBxMNmegT+m+GtL1a9J+QwnCek7Wrmt9I5xVg niE41/CBGR0oZBqLdovyjpzPVSI5b0RVpb2ofDNdHJQZ/r4N7xhPTtI2lhbdbPN1TmyP 9G8lykpjuFl4zqYrSEwOtuc8L7tLkx4d/YeNTAEXeLi/p2Ldw+jP+KGeZRauthCkV7hq L1P4cvdGnrJDcjP4w3Cm+IKV4sDY/QZ44MRhlKIbHDts9bW7TM43Z3qGGT560hDmkmOC e8JcLVHzA/ymO30I74Kpns7R20UJOnEeaGWucvQxbQSYqUGEXbbdavchN+Om91HCGjqK /Dyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/4RwAjXPtC218FslHiEhUYGCqGEWToA3TK5+6fZBZNA=; b=VyGyGmfFoLc1rYGKPdGWNDpyagZNsbLTHaqX88cFnYvwkQzObLOBXf25KTzzmqj0Nl WpICd/CoRfPwhbOv+0wf1epq7uLHnzOlyHiiJKsLW1SLhYVl7bfC3p4BgNt2KotSdO2c iiJBvfxRo4qA2ObVAeJgCxqz1eSx0kJvhTJ6sRPjdU9vDCfbRy/EsX/TS0BLmiC8wchI ZPP2eL5AXTBxRjJhigCRazgynkR0C7RNl7rRJgMISlu/qqhYK8aAdAfr0Xe3UbcNW2im o1feDw+Fikac9KlK7VeTrGQCSeKWV9NoNNt6IZ/zHEU6KPm6CaV77bQ5zA2eeBY6B2OG 3kCw== X-Gm-Message-State: AOAM532DBi6aFuuZJkef5TgH8ftqejK1t9MtePm25HsKHDwx1ga6jAY+ qI8YfSCSM6vc0xxH9INaS4+6xjkbvR6MXKucg7nI+w== X-Google-Smtp-Source: ABdhPJyCVESb+FOlmMl5dPAf4Gco8QkFh0ii+imiXjgleMjODWaRGNA06Nxj08O7M4Hur+hzj8u2fz+G5MBr5Z14Ri4= X-Received: by 2002:a19:4810:: with SMTP id v16mr3052847lfa.254.1623837768679; Wed, 16 Jun 2021 03:02:48 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Vincent Guittot Date: Wed, 16 Jun 2021 12:02:37 +0200 Message-ID: Subject: Re: [PATCH V2 0/3] cpufreq: cppc: Add support for frequency invariance To: Viresh Kumar Cc: Rafael Wysocki , Ionela Voinescu , Ben Segall , Daniel Bristot de Oliveira , Dietmar Eggemann , Greg Kroah-Hartman , Ingo Molnar , Jonathan Corbet , Juri Lelli , Mel Gorman , Peter Zijlstra , "Rafael J. Wysocki" , Steven Rostedt , Sudeep Holla , "open list:THERMAL" , Qian Cai , ACPI Devel Maling List , Linux Doc Mailing List , linux-kernel , "Paul E. McKenney" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Wed, 16 Jun 2021 at 08:48, Viresh Kumar wrote: > > Hello, > > Changes since V1: > > - Few of the patches migrating users to ->exit() callback are posted separately. > > - The CPPC patch was completely reverted and so the support for FIE is again > added here from scratch. > > - The start_cpu() and stop_cpu() interface is reworked a little so stop_cpu() is > only ever called for a CPU if start_cpu() was called for it earlier. > > - A new patch to implement RCU locking in arch_topology core to avoid some > races. > > - Some cleanup and very clear/separate paths for FIE in cppc driver now. > > > -------------------------8<------------------------- > > CPPC cpufreq driver is used for ARM servers and this patch series tries to > provide counter-based frequency invariance support for them in the absence for > architecture specific counters (like AMUs). > > This was reverted earlier for the 5.13 kernel after Qian Cai reported kernel > oops during suspend/resume. > > This is based of pm/linux-next + a cleanup patchset: > > https://lore.kernel.org/linux-pm/cover.1623825358.git.viresh.kumar@linaro.org/ > > All the patches are pushed here together for people to run. > > https://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git/log/?h=cpufreq/cppc > > This is tested on my Hikey platform (without the actual read/write to > performance counters), with this script for over an hour: > > while true; do > for i in `seq 1 7`; > do > echo 0 > /sys/devices/system/cpu/cpu$i/online; > done; > > for i in `seq 1 7`; > do > echo 1 > /sys/devices/system/cpu/cpu$i/online; > done; > done > > > Vincent will be giving this patchset a try on ThunderX2. I tested your branch and got the following while booting: [ 24.454543] zswap: loaded using pool lzo/zbud [ 24.454753] pstore: Using crash dump compression: deflate [ 24.454776] AppArmor: AppArmor sha1 policy hashing enabled [ 24.454784] ima: No TPM chip found, activating TPM-bypass! [ 24.454789] ima: Allocated hash algorithm: sha256 [ 24.454801] ima: No architecture policies found [ 24.455750] pcieport 0000:0f:00.0: Adding to iommu group 0 [ 24.893888] ------------[ cut here ]------------ [ 24.893891] WARNING: CPU: 95 PID: 1442 at drivers/cpufreq/cppc_cpufreq.c:123 cppc_scale_freq_workfn+0xc8/0xf8 [ 24.893901] Modules linked in: [ 24.893906] CPU: 95 PID: 1442 Comm: cppc_fie Not tainted 5.13.0-rc6+ #359 [ 24.893910] Hardware name: To be filled by O.E.M. Saber/Saber, BIOS 0ACKL026 03/19/2019 [ 24.893912] pstate: 20400009 (nzCv daif +PAN -UAO -TCO BTYPE=--) [ 24.893915] pc : cppc_scale_freq_workfn+0xc8/0xf8 [ 24.893918] lr : cppc_scale_freq_workfn+0x5c/0xf8 [ 24.893921] sp : ffff80003727bd90 [ 24.893922] x29: ffff80003727bd90 x28: 0000000000000000 x27: ffff800010ec2000 [ 24.893928] x26: ffff800010ec2000 x25: ffff8000107c3d90 x24: 0000000000000001 [ 24.893932] x23: ffff000816244880 x22: ffff8000113f9000 x21: ffff009f825a0a80 [ 24.893935] x20: ffff009efc394220 x19: ffff800011199000 x18: 000000000000001b [ 24.893939] x17: 0000000000000007 x16: 0000000000000001 x15: 00000000000000bf [ 24.893943] x14: 0000000000000016 x13: 000000000000029b x12: 0000000000000016 [ 24.893946] x11: 0000000000000000 x10: 0000000000000000 x9 : ffff009efc6958c0 [ 24.893950] x8 : ffff009efc394248 x7 : 0000000002bde780 x6 : 00000000ffffffff [ 24.893954] x5 : 00000000916e502a x4 : 00000000d9730e80 x3 : ffffffffffffffff [ 24.893958] x2 : 00000000001e8480 x1 : 00000000002625a0 x0 : 0000000000000401 [ 24.893962] Call trace: [ 24.893964] cppc_scale_freq_workfn+0xc8/0xf8 [ 24.893967] kthread_worker_fn+0x110/0x318 [ 24.893971] kthread+0xf4/0x120 [ 24.893973] ret_from_fork+0x10/0x18 [ 24.893977] ---[ end trace ea6dbaf832bce3e4 ]--- > > Meanwhile it is up for review. Ideally I would like to get this merged for 5.14, > but lets see how it goes. > > Thanks. > > -- > Viresh > > Viresh Kumar (3): > cpufreq: Add start_cpu() and stop_cpu() callbacks > arch_topology: Avoid use-after-free for scale_freq_data > cpufreq: CPPC: Add support for frequency invariance > > Documentation/cpu-freq/cpu-drivers.rst | 7 +- > drivers/base/arch_topology.c | 27 ++- > drivers/cpufreq/Kconfig.arm | 10 ++ > drivers/cpufreq/cppc_cpufreq.c | 232 +++++++++++++++++++++++-- > drivers/cpufreq/cpufreq.c | 19 +- > include/linux/arch_topology.h | 1 + > include/linux/cpufreq.h | 5 +- > kernel/sched/core.c | 1 + > 8 files changed, 272 insertions(+), 30 deletions(-) > > -- > 2.31.1.272.g89b43f80a514 >