From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH v5 7/7] Documentation:cpufreq:boost: Update BOOST documentation Date: Wed, 17 Jul 2013 13:29:26 +0530 Message-ID: References: <1370502472-7249-1-git-send-email-l.majewski@samsung.com> <1372927830-2949-1-git-send-email-l.majewski@samsung.com> <1372927830-2949-8-git-send-email-l.majewski@samsung.com> <20130716133319.49ed0838@amdc308.digital.local> <20130717093614.1ee4839e@amdc308.digital.local> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <20130717093614.1ee4839e@amdc308.digital.local> Sender: cpufreq-owner@vger.kernel.org To: Lukasz Majewski Cc: "Rafael J. Wysocki" , Zhang Rui , Eduardo Valentin , "cpufreq@vger.kernel.org" , Linux PM list , Jonghwa Lee , l.majewski@majess.pl, linux-kernel , Andre Przywara , Daniel Lezcano , Kukjin Kim , Myungjoo Ham List-Id: linux-pm@vger.kernel.org On 17 July 2013 13:06, Lukasz Majewski wrote: > At v4 there was the old acpi-cpufreq.c behaviour preserved (with always > exporting boost - when not supported ro, when supported rw). > > Due to Rafael and Dirk comments it has been rewritten at v5: > > http://thread.gmane.org/gmane.linux.kernel/1511831/match=patch+v4+2+7+cpufreq+add+boost+frequency+support+core > > >> >> Rafael Said: >> "Simple: Export it only when supported." > [*] > >> >> AND >> >> "Don't change behavior of acpi-cpufreq driver" > [**] >> >> If you see acpi-cpufreq driver carefully, it always creates "boost" >> sysfs entry. If its not supported then it creates a read only entry. > > For me those two statements [*] and [**] contradict: > > At v5: > 1. ARM - export "boost" only when supported (rw) > 2. x86 - export boost only when x86 supports it (as rw). When x86 > doesn't support HW boost - DO NOT export it at all. > > At v4: > 1. ARM - export "boost" only when supported (rw) > 2. x86 - always export boost - no matter if supported or not. If not > supported, then export it as ro only. Okay, there is some confusion.. I have raised a query on your v4 mail.. lets see what people have to say.