From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88634C433E1 for ; Tue, 14 Jul 2020 14:26:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5DF4422516 for ; Tue, 14 Jul 2020 14:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594736795; bh=S3wLIXMLvW4hWE0k9kaLD27dt6WY9VJU7X1n3XEPPEI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=K4vNrtQtc/Uh3V8RiTUqLlz26oq2XDjiZy13G4BcYKOYY0N5kEeAuHzbpg/DeBM65 7eWkROXM4bH9s3uDNc5ou0T41ytnfbCPOQSIdVKud8WSqFkxsyGYB8oOI3YQJMMvX6 /CTVV9YYwTNYFtPWlgLfVSR9Mqu6nK5cFLfQzJJI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726062AbgGNO0e (ORCPT ); Tue, 14 Jul 2020 10:26:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:49290 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725890AbgGNO0e (ORCPT ); Tue, 14 Jul 2020 10:26:34 -0400 Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4A2C822516; Tue, 14 Jul 2020 14:26:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594736793; bh=S3wLIXMLvW4hWE0k9kaLD27dt6WY9VJU7X1n3XEPPEI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=GZKQS7l+v7huDhLmjre/t0kJSh4fLGZXnxIGOz8xnJYJsjKtyUc3hg5uM5w4/uSTP eyUoZi4km+sze9KRrIiGzk3/vjRqI9Ua4hd4CkgZLG2dq/ro+daGh4CPuw3k+NpK/O P8JmTQXzjye8F4gLH+1Dg+XqZUrpxVWAD+3q5kqo= Received: by mail-ot1-f49.google.com with SMTP id 18so13148114otv.6; Tue, 14 Jul 2020 07:26:33 -0700 (PDT) X-Gm-Message-State: AOAM531LpGbzxpDkZ3ZfpPwjK2EGXeFKmxQ2ATumZA/cyKRyAyvjiSL3 okCXaYxYZ1pmNeEL3oprheCk/8QhDxfhktJG0g== X-Google-Smtp-Source: ABdhPJyuvjA8JGPnMGdzGxe+pkPemV2r5WuflfIGWMOBeMYBaIts3muiUvAU/L9AW1tNJurH/prAJoPR1eJXtPrSD+o= X-Received: by 2002:a9d:2646:: with SMTP id a64mr4051084otb.107.1594736792668; Tue, 14 Jul 2020 07:26:32 -0700 (PDT) MIME-Version: 1.0 References: <20200709215136.28044-1-ansuelsmth@gmail.com> <20200709215136.28044-4-ansuelsmth@gmail.com> <20200710162657.GB2743639@bogus> <0ef601d656f5$b9f8e0c0$2deaa240$@gmail.com> In-Reply-To: <0ef601d656f5$b9f8e0c0$2deaa240$@gmail.com> From: Rob Herring Date: Tue, 14 Jul 2020 08:26:21 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/6] dt-bindings: thermal: tsens: document ipq8064 bindings To: Ansuel Smith Cc: Amit Kucheria , Andy Gross , Bjorn Andersson , Zhang Rui , Daniel Lezcano , "open list:THERMAL" , linux-arm-msm , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Fri, Jul 10, 2020 at 2:07 PM wrote: > > > > > -----Messaggio originale----- > > Da: Rob Herring > > Inviato: venerd=C3=AC 10 luglio 2020 18:27 > > A: Ansuel Smith > > Cc: Amit Kucheria ; Andy Gross > > ; Bjorn Andersson ; > > Zhang Rui ; Daniel Lezcano > > ; linux-pm@vger.kernel.org; linux-arm- > > msm@vger.kernel.org; devicetree@vger.kernel.org; linux- > > kernel@vger.kernel.org > > Oggetto: Re: [PATCH 3/6] dt-bindings: thermal: tsens: document ipq8064 > > bindings > > > > On Thu, Jul 09, 2020 at 11:51:33PM +0200, Ansuel Smith wrote: > > > Document the use of regmap phandle for ipq8064 SoCs > > > > > > Signed-off-by: Ansuel Smith > > > --- > > > .../bindings/thermal/qcom-tsens.yaml | 51 ++++++++++++++++-= -- > > > 1 file changed, 44 insertions(+), 7 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yam= l > > b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > > > index d7be931b42d2..5ceb5d720e16 100644 > > > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > > > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > > > @@ -24,6 +24,7 @@ properties: > > > - enum: > > > - qcom,msm8916-tsens > > > - qcom,msm8974-tsens > > > + - qcom,ipq8064-tsens > > > - const: qcom,tsens-v0_1 > > > > > > - description: v1 of TSENS > > > @@ -47,6 +48,11 @@ properties: > > > - description: TM registers > > > - description: SROT registers > > > > > > + regmap: > > > + description: > > > + Phandle to the gcc. On ipq8064 SoCs gcc and tsense share the s= ame > > regs. > > > + $ref: /schemas/types.yaml#/definitions/phandle > > > > Can't you make this a child of the gcc and drop this property? > > > > Make the thermal a child of the gcc would be a little confusing. Anyway > making this > a child of gcc cause the not probing of the thermal driver as it's ignore= d > any child of > gcc. I pushed v2 with the fixed problem. Structure the DT as the h/w is structured, not what's convenient for the OS= . Either the GCC driver has to call of_platform_populate on the child nodes or you can perhaps use 'simple-mfd'. Rob