From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8626EC433EA for ; Fri, 14 Aug 2020 14:51:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66BEB22B4B for ; Fri, 14 Aug 2020 14:51:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597416702; bh=2azDCJAW0WmwzjFoNP1+Xf1baXp64Ykp/VUpBlKju0s=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=j4ioMzpzKZL6a8aWTfgSIxDbY6VQN+JmJ1dPymPCDdSEO1Djt7zG+0m5mW0vUWObR IYWItNfI3BRQrl6RYZWFN6x5+XyLU28V18unECigTxqm0+HZgjF2KscR7hQyKqloIQ WxVIHedTV9JX/b03w3YEyaSRe5YOqJ+lu1KGAlq0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728257AbgHNOvk (ORCPT ); Fri, 14 Aug 2020 10:51:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:43326 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726193AbgHNOvi (ORCPT ); Fri, 14 Aug 2020 10:51:38 -0400 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E2C6E208B3; Fri, 14 Aug 2020 14:51:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597416697; bh=2azDCJAW0WmwzjFoNP1+Xf1baXp64Ykp/VUpBlKju0s=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bjfRL+mBKQdeXNIPuXX+sib3fYs2/XZWJHPOjPd4x196xwXtWkEnxkwGCGKCP+vXy CxGeqKP68MgYI300g+hNTJd4uQCvZb/zOsnBdJ/cEKlyynKbLGyhuMbkA+R9Y9MLDY rajai6Sqx8HGb8L035zTD4t0BSpxCLooD+BQeHTA= Received: by mail-ot1-f54.google.com with SMTP id t7so7776444otp.0; Fri, 14 Aug 2020 07:51:36 -0700 (PDT) X-Gm-Message-State: AOAM531YqcS4MUxvcGOYChGHRoRMcVsEFsDHYR5LbkHA90TiOSl6Dmh8 R/b9TCtT0vzAo6TEwQr7L0CGI1coatN8YZannA== X-Google-Smtp-Source: ABdhPJzAQOVgwIRLTeJz+4kS8jI7uSM4yy2bV/QUkiEz2152JH8sgfiQxJMSY+wk4abg95jsoFr6h5Ymz6ZJoeFhB2g= X-Received: by 2002:a05:6830:1b79:: with SMTP id d25mr1995774ote.107.1597416696235; Fri, 14 Aug 2020 07:51:36 -0700 (PDT) MIME-Version: 1.0 References: <20200812203618.2656699-1-robh@kernel.org> In-Reply-To: From: Rob Herring Date: Fri, 14 Aug 2020 08:51:24 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files To: Luca Ceresoli Cc: devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-clk , dri-devel , linux-spi , "open list:GPIO SUBSYSTEM" , "open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM" , Linux HWMON List , Linux I2C , Linux Fbdev development list , "open list:IIO SUBSYSTEM AND DRIVERS" , Linux Input , "open list:THERMAL" , Linux Media Mailing List , Linux-ALSA , linux-mmc , MTD Maling List , netdev , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" , "open list:SERIAL DRIVERS" , Linux USB List Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, Aug 13, 2020 at 4:31 AM Luca Ceresoli wrote: > > Hi Rob, > > On 12/08/20 22:36, Rob Herring wrote: > > Clean-up incorrect indentation, extra spaces, long lines, and missing > > EOF newline in schema files. Most of the clean-ups are for list > > indentation which should always be 2 spaces more than the preceding > > keyword. > > > > Found with yamllint (which I plan to integrate into the checks). > > [...] > > > diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml > > index 3d4e1685cc55..28c6461b9a9a 100644 > > --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml > > +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml > > @@ -95,10 +95,10 @@ allOf: > > # Devices without builtin crystal > > properties: > > clock-names: > > - minItems: 1 > > - maxItems: 2 > > - items: > > - enum: [ xin, clkin ] > > + minItems: 1 > > + maxItems: 2 > > + items: > > + enum: [ xin, clkin ] > > clocks: > > minItems: 1 > > maxItems: 2 > > Thanks for noticing, LGTM. > > [...] > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml > > index d7dac16a3960..36dc7b56a453 100644 > > --- a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml > > +++ b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml > > @@ -33,8 +33,8 @@ properties: > > $ref: /schemas/types.yaml#/definitions/uint32 > > > > touchscreen-min-pressure: > > - description: minimum pressure on the touchscreen to be achieved in order for the > > - touchscreen driver to report a touch event. > > + description: minimum pressure on the touchscreen to be achieved in order > > + for the touchscreen driver to report a touch event. > > Out of personal taste, I find the original layout more pleasant and > readable. This third option is also good, especially for long descriptions: > > description: > minimum pressure on the touchscreen to be achieved in order for the > touchscreen driver to report a touch event. > > At first glance yamllint seems to support exactly these two by default: > > > With indentation: {spaces: 4, check-multi-line-strings: true} Turning on check-multi-line-strings results in 10K+ warnings, so no. The other issue is the style ruamel.yaml wants to write out is as the patch does above. This matters when doing some scripted transformations where we read in the files and write them back out. I can somewhat work around that by first doing a pass with no changes and then another pass with the actual changes, but that's completely scriptable. Hopefully, ruamel learns to preserve the style better. Rob