From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61A93C3A5A3 for ; Fri, 23 Aug 2019 09:08:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 40880233A0 for ; Fri, 23 Aug 2019 09:08:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726515AbfHWJIW (ORCPT ); Fri, 23 Aug 2019 05:08:22 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:45772 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725857AbfHWJIW (ORCPT ); Fri, 23 Aug 2019 05:08:22 -0400 Received: by mail-oi1-f193.google.com with SMTP id v12so6493263oic.12; Fri, 23 Aug 2019 02:08:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vv7AIXHXpjyqYAZ2S7B2OmOZt6qGKJgxmRiKB2RUIlY=; b=q1ecNwF83ugVXJcnCqUmw/sMQAcklHIIy1ruHkVb3ClLaE8GluNTHPWaKkH8293NpW 2nmQsDUZnESviYaZ7laWuPWiyzkwiFl5Pfs0bk1/REGnB6cqFcEV6ASZyaa+rPu2G/IF 1WpANIUAlRlXMaSBXkqOvWOiYPRFCNASGoxmvKsBsioJRO13zz54xXKAULAI+1Jc/X+S 5BPuxWSO3x512mmQHtAjsaa5bnIZ0cZGTOZYmkmHTY9ZAcvLI20kkhOXopiNJy9o7EMz fdUpTht5jdNmax5U2EnUhgBSuBubBjwf4UhYrlZJ8XFMWdF58z1EnGeCC5dM1xTd2aGv Fjhg== X-Gm-Message-State: APjAAAWprP0wlO6Pn+n2koiGgqMPFPiYVdzlz6cirf8VmXNsaeKhQcNh otBl69vW3V0G42WRwA162oZOjyKeWaenZ7Gxa30= X-Google-Smtp-Source: APXvYqyEnIDhJoxsBgSVUV558kban19R/tfa1+VWnxVQTBEbq2Dh73GIhYgK4nIksCgA8MMkTXFHDJckp5fokG8Tdzw= X-Received: by 2002:aca:b154:: with SMTP id a81mr2283349oif.148.1566551301228; Fri, 23 Aug 2019 02:08:21 -0700 (PDT) MIME-Version: 1.0 References: <20190816125225.16061-1-geert+renesas@glider.be> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 23 Aug 2019 11:08:10 +0200 Message-ID: Subject: Re: [PATCH 0/3] clk: renesas: Set GENPD_FLAG_ALWAYS_ON for clock domain To: Ulf Hansson Cc: Geert Uytterhoeven , Michael Turquette , Stephen Boyd , "Rafael J . Wysocki" , Kevin Hilman , Linux-Renesas , linux-clk , Linux PM Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, Aug 22, 2019 at 4:09 PM Ulf Hansson wrote: > On Fri, 16 Aug 2019 at 14:52, Geert Uytterhoeven > wrote: > > The Renesas Clock Domain drivers do not implement the > > generic_pm_domain.power_{on,off}() callbacks, as the domains themselves > > cannot be powered down. Hence the domains should be marked as always-on > > by setting the GENPD_FLAG_ALWAYS_ON flag. > > > > This patch series that issue for R-Car M1A, RZ/A1, RZ/A2, and > > RZ/N1 SoCs. > > SH/R-Mobile SoCs are fixed in "[PATCH] soc: renesas: rmobile-sysc: Set > > GENPD_FLAG_ALWAYS_ON for always-on domain" > > (https://lore.kernel.org/linux-renesas-soc/20190816124106.15383-1-geert+renesas@glider.be/T/#u). > > R-Car H1, Gen2, and Gen3 SoCs do not need a fix, as these SoCS use the > > R-Car SYSC driver for Clock Domain creation, which already sets the > > flag. > > > > To be queued in clk-renesas for v5.4. > > > > Thanks! > > > > Geert Uytterhoeven (3): > > clk: renesas: mstp: Set GENPD_FLAG_ALWAYS_ON for clock domain > > clk: renesas: r9a06g032: Set GENPD_FLAG_ALWAYS_ON for clock domain > > clk: renesas: cpg-mssr: Set GENPD_FLAG_ALWAYS_ON for clock domain > > > > drivers/clk/renesas/clk-mstp.c | 3 ++- > > drivers/clk/renesas/r9a06g032-clocks.c | 3 ++- > > drivers/clk/renesas/renesas-cpg-mssr.c | 3 ++- > > 3 files changed, 6 insertions(+), 3 deletions(-) > > > > Feel free to add: > > Reviewed-by: Ulf Hansson Thanks, queuing in clk-renesas-for-v5.4, with enhanced commit description: ... to prevent the core PM Domain code from considering it for power-off, and doing unnessary processing. for all three of them, and This also gets rid of a boot warning when the Clock Domain contains an IRQ-safe device, e.g. on RZ/A1: for the first patch. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds