[PATCH 0/4] qoriq: Add platform dependencies

[PATCH 0/4] qoriq: Add platform dependencies

[Geert Uytterhoeven]

	Hi all,

Several QorIQ blocks are only present on Freescale or NXP SoCs.
This series adds platform dependencies to the corresponding config
ymbols, to avoid asking the user about them when configuring a kernel
without support for these SoCs.

Most patches in this series are independent, but the third patch may
cause some Kconfig warnings when applied before the second patch, and
enabling the QorIQ CPU frequency scaling driver in a non-Layerscape
kernel.

Thanks for your comments!

Geert Uytterhoeven (4):
  ahci: qoriq: Add platform dependencies
  cpufreq: qoriq: Add platform dependencies
  clk: qoriq: Add platform dependencies
  thermal: qoriq: Add platform dependencies

 drivers/ata/Kconfig     | 1 +
 drivers/clk/Kconfig     | 3 ++-
 drivers/cpufreq/Kconfig | 3 ++-
 drivers/thermal/Kconfig | 4 ++--
 4 files changed, 7 insertions(+), 4 deletions(-)

-- 
2.17.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

[PATCH 1/4] ahci: qoriq: Add platform dependencies

[Geert Uytterhoeven]

The Freescale QorIQ AHCI SATA controller is only present on Freescale
Layerscape SoCs.  Add platform dependencies to the AHCI_QORIQ config
symbol, to avoid asking the user about it when configuring a kernel
without Layerscape support.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/ata/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 05ecdce1b702cf8b..d9e66b37acd1862a 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -264,6 +264,7 @@ config AHCI_XGENE
 config AHCI_QORIQ
 	tristate "Freescale QorIQ AHCI SATA support"
 	depends on OF
+	depends on SOC_LS1021A || ARCH_LAYERSCAPE || COMPILE_TEST
 	select SATA_HOST
 	help
 	  This option enables support for the Freescale QorIQ AHCI SoC's
-- 
2.17.1

[PATCH 2/4] cpufreq: qoriq: Add platform dependencies

[Geert Uytterhoeven]

The Freescale QorIQ clock controller is only present on Freescale E500MC
and Layerscape SoCs.  Add platform dependencies to the QORIQ_CPUFREQ
config symbol, to avoid asking the user about it when configuring a
kernel without E500MC or Layerscape support.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/cpufreq/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
index c3e6bd59e9208822..e917501325525f16 100644
--- a/drivers/cpufreq/Kconfig
+++ b/drivers/cpufreq/Kconfig
@@ -323,7 +323,8 @@ endif
 
 config QORIQ_CPUFREQ
 	tristate "CPU frequency scaling driver for Freescale QorIQ SoCs"
-	depends on OF && COMMON_CLK && (PPC_E500MC || ARM || ARM64)
+	depends on OF && COMMON_CLK
+	depends on PPC_E500MC || SOC_LS1021A || ARCH_LAYERSCAPE || COMPILE_TEST
 	select CLK_QORIQ
 	help
 	  This adds the CPUFreq driver support for Freescale QorIQ SoCs
-- 
2.17.1

[PATCH 3/4] clk: qoriq: Add platform dependencies

[Geert Uytterhoeven]

The Freescale QorIQ clock controller is only present on Freescale E500MC
and Layerscape SoCs.  Add platform dependencies to the CLK_QORIQ config
symbol, to avoid asking the user about it when configuring a kernel
without E500MC or Layerscape support.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/clk/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index bcb257baed06daa0..22bf015610d1724c 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -232,7 +232,8 @@ config COMMON_CLK_AXI_CLKGEN
 
 config CLK_QORIQ
 	bool "Clock driver for Freescale QorIQ platforms"
-	depends on (PPC_E500MC || ARM || ARM64 || COMPILE_TEST) && OF
+	depends on OF
+	depends on PPC_E500MC || SOC_LS1021A || ARCH_LAYERSCAPE || COMPILE_TEST
 	---help---
 	  This adds the clock driver support for Freescale QorIQ platforms
 	  using common clock framework.
-- 
2.17.1

[PATCH 4/4] thermal: qoriq: Add platform dependencies

[Geert Uytterhoeven]

The QorIQ Thermal Monitoring Unit is only present on Freescale E500MC
and Layerscape SoCs, and on NXP i.MX8 SoCs.  Add platform dependencies
to the QORIQ_THERMAL config symbol, to avoid asking the user about it
when configuring a kernel without support for any of the aforementioned
SoCs.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/thermal/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 91af271e9bb02475..61a994e1e7824ff6 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -285,8 +285,8 @@ config MAX77620_THERMAL
 
 config QORIQ_THERMAL
 	tristate "QorIQ Thermal Monitoring Unit"
-	depends on THERMAL_OF
-	depends on HAS_IOMEM
+	depends on THERMAL_OF && HAS_IOMEM
+	depends on PPC_E500MC || SOC_LS1021A || ARCH_LAYERSCAPE || (ARCH_MXC && ARM64) || COMPILE_TEST
 	select REGMAP_MMIO
 	help
 	  Support for Thermal Monitoring Unit (TMU) found on QorIQ platforms.
-- 
2.17.1

Re: [PATCH 0/4] qoriq: Add platform dependencies

[Arnd Bergmann]

On Thu, May 7, 2020 at 1:30 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
>         Hi all,
>
> Several QorIQ blocks are only present on Freescale or NXP SoCs.
> This series adds platform dependencies to the corresponding config
> ymbols, to avoid asking the user about them when configuring a kernel
> without support for these SoCs.
>
> Most patches in this series are independent, but the third patch may
> cause some Kconfig warnings when applied before the second patch, and
> enabling the QorIQ CPU frequency scaling driver in a non-Layerscape
> kernel.
>
> Thanks for your comments!

These all look good to me, thank you for the improvements!

Acked-by: Arnd Bergmann <arnd@arndb.de>

Re: [PATCH 0/4] qoriq: Add platform dependencies

[Li Yang]

On Thu, May 7, 2020 at 6:31 AM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
>         Hi all,
>
> Several QorIQ blocks are only present on Freescale or NXP SoCs.
> This series adds platform dependencies to the corresponding config
> ymbols, to avoid asking the user about them when configuring a kernel
> without support for these SoCs.
>
> Most patches in this series are independent, but the third patch may
> cause some Kconfig warnings when applied before the second patch, and
> enabling the QorIQ CPU frequency scaling driver in a non-Layerscape
> kernel.
>
> Thanks for your comments!

Thanks.  The series looks good to me.

Are we trying to merge them through the various driver subsystems or I
can also pull them in through the fsl-soc tree.  If we want to go
through driver subsystems:

Acked-by: Li Yang <leoyang.li@nxp.com>

>
> Geert Uytterhoeven (4):
>   ahci: qoriq: Add platform dependencies
>   cpufreq: qoriq: Add platform dependencies
>   clk: qoriq: Add platform dependencies
>   thermal: qoriq: Add platform dependencies
>
>  drivers/ata/Kconfig     | 1 +
>  drivers/clk/Kconfig     | 3 ++-
>  drivers/cpufreq/Kconfig | 3 ++-
>  drivers/thermal/Kconfig | 4 ++--
>  4 files changed, 7 insertions(+), 4 deletions(-)
>
> --
> 2.17.1
>
> Gr{oetje,eeting}s,
>
>                                                 Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                                             -- Linus Torvalds

Re: [PATCH 2/4] cpufreq: qoriq: Add platform dependencies

[Viresh Kumar]

On 07-05-20, 13:29, Geert Uytterhoeven wrote:
> The Freescale QorIQ clock controller is only present on Freescale E500MC
> and Layerscape SoCs.  Add platform dependencies to the QORIQ_CPUFREQ
> config symbol, to avoid asking the user about it when configuring a
> kernel without E500MC or Layerscape support.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/cpufreq/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index c3e6bd59e9208822..e917501325525f16 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -323,7 +323,8 @@ endif
>  
>  config QORIQ_CPUFREQ
>  	tristate "CPU frequency scaling driver for Freescale QorIQ SoCs"
> -	depends on OF && COMMON_CLK && (PPC_E500MC || ARM || ARM64)
> +	depends on OF && COMMON_CLK
> +	depends on PPC_E500MC || SOC_LS1021A || ARCH_LAYERSCAPE || COMPILE_TEST
>  	select CLK_QORIQ
>  	help
>  	  This adds the CPUFreq driver support for Freescale QorIQ SoCs

Applied. Thanks.

-- 
viresh

Re: [PATCH 0/4] qoriq: Add platform dependencies

[Geert Uytterhoeven]

Hi Li,

On Thu, May 7, 2020 at 11:58 PM Li Yang <leoyang.li@nxp.com> wrote:
> On Thu, May 7, 2020 at 6:31 AM Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
> > Several QorIQ blocks are only present on Freescale or NXP SoCs.
> > This series adds platform dependencies to the corresponding config
> > ymbols, to avoid asking the user about them when configuring a kernel
> > without support for these SoCs.
> >
> > Most patches in this series are independent, but the third patch may
> > cause some Kconfig warnings when applied before the second patch, and
> > enabling the QorIQ CPU frequency scaling driver in a non-Layerscape
> > kernel.
> >
> > Thanks for your comments!
>
> Thanks.  The series looks good to me.
>
> Are we trying to merge them through the various driver subsystems or I
> can also pull them in through the fsl-soc tree.  If we want to go
> through driver subsystems:

"fsl-soc" is safest, if maintainers agree, due to the weak dependency the
randconfig people may notice.
Note that Viresh already applied the 2nd patch to the cpufreq tree.

> Acked-by: Li Yang <leoyang.li@nxp.com>

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 4/4] thermal: qoriq: Add platform dependencies

[Daniel Lezcano]

On 07/05/2020 13:29, Geert Uytterhoeven wrote:
> The QorIQ Thermal Monitoring Unit is only present on Freescale E500MC
> and Layerscape SoCs, and on NXP i.MX8 SoCs.  Add platform dependencies
> to the QORIQ_THERMAL config symbol, to avoid asking the user about it
> when configuring a kernel without support for any of the aforementioned
> SoCs.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Applied, thanks



-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH 3/4] clk: qoriq: Add platform dependencies

[Li Yang]

On Thu, May 7, 2020 at 6:31 AM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> The Freescale QorIQ clock controller is only present on Freescale E500MC
> and Layerscape SoCs.  Add platform dependencies to the CLK_QORIQ config
> symbol, to avoid asking the user about it when configuring a kernel
> without E500MC or Layerscape support.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Hi Michael/Stephen,

Are you applying this patch?  If not I can apply it with your ACK.

Regards,
Leo

> ---
>  drivers/clk/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index bcb257baed06daa0..22bf015610d1724c 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -232,7 +232,8 @@ config COMMON_CLK_AXI_CLKGEN
>
>  config CLK_QORIQ
>         bool "Clock driver for Freescale QorIQ platforms"
> -       depends on (PPC_E500MC || ARM || ARM64 || COMPILE_TEST) && OF
> +       depends on OF
> +       depends on PPC_E500MC || SOC_LS1021A || ARCH_LAYERSCAPE || COMPILE_TEST
>         ---help---
>           This adds the clock driver support for Freescale QorIQ platforms
>           using common clock framework.
> --
> 2.17.1
>

Re: [PATCH 1/4] ahci: qoriq: Add platform dependencies

[Li Yang]

On Thu, May 7, 2020 at 6:30 AM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> The Freescale QorIQ AHCI SATA controller is only present on Freescale
> Layerscape SoCs.  Add platform dependencies to the AHCI_QORIQ config
> symbol, to avoid asking the user about it when configuring a kernel
> without Layerscape support.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Hi Jens,

Are you applying this patches?  I can also apply it with your ACK.

Regards,
Leo
> ---
>  drivers/ata/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 05ecdce1b702cf8b..d9e66b37acd1862a 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -264,6 +264,7 @@ config AHCI_XGENE
>  config AHCI_QORIQ
>         tristate "Freescale QorIQ AHCI SATA support"
>         depends on OF
> +       depends on SOC_LS1021A || ARCH_LAYERSCAPE || COMPILE_TEST
>         select SATA_HOST
>         help
>           This option enables support for the Freescale QorIQ AHCI SoC's
> --
> 2.17.1
>