From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BD91C32753 for ; Tue, 13 Aug 2019 23:04:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20AD0206C2 for ; Tue, 13 Aug 2019 23:04:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=android.com header.i=@android.com header.b="jXcIcld8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727477AbfHMXEt (ORCPT ); Tue, 13 Aug 2019 19:04:49 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:39196 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726878AbfHMXEt (ORCPT ); Tue, 13 Aug 2019 19:04:49 -0400 Received: by mail-ot1-f66.google.com with SMTP id b1so9915328otp.6 for ; Tue, 13 Aug 2019 16:04:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rUNzvroLFC8do+wMufMXyTxQgZ8KjnrEVE4dV3+vp2M=; b=jXcIcld86cvD6MQslPUN0PNbwTaVDhfv2eh/5XGDrNNg/i5VMWQqHfk0gafXKJ0uFE rNixph/5EQLNKQlxsdMsh5RFzo4xPseL3sD7kBWWwTGJ7W8BERYC6tY8rHU3nPqCf92A k7n7ADkRmbBX6E4ChcANbtKk9Q9pIkFeEDBAfcpBc0h8D4zst4e88YN2yT/2XXZx+Fuj ijqmqfywab0ETun+19+AD+8Ig1iaFLaIQxau43wfejtZNsX1dkdoUAK1WQNm8nUzMr0m 97+i4UKsMrw9eUARYWbImV6TS7bRQThe9oFlntsS5hip3KW08RenIgq45YVoO0HEShE8 xKtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rUNzvroLFC8do+wMufMXyTxQgZ8KjnrEVE4dV3+vp2M=; b=M35S+hcgocjx5Xd8+Zmbj4duq4Sdnwfj5Wft2Eu5FhdkiBEkCbgBjLPs2/yKlD2RBZ RLy88i+OgX08BW4HUxI/G5WBWg1hblqo/iAAREtcyHpuaJVy9p0wyz+0YEmDFIh8W4Av RF+QkPvc0YOQecXbqdW7yuFPNzocTZSVcvYOSaNpeMYHVJmL8jiWDfvCKK/O+Io7DmXd dbp9N+PJ7klZXwAeXTNWXmwNLJYN1yD5epm8Zb8i+a+GlYVCjChr2NyJsHU6ZsM+54NP WxGNUVuul72DA11JOCQYSp2kyGs2hKcjxpZpvCJHNsHuIvIC/I76sn7Po8eWZKK+2InE e2ow== X-Gm-Message-State: APjAAAWB6zeTp5wHKMIKdOxE4+aqqHy/i/rL39FiX+yjJaFeFrz4ixPp 59sVX/rhtYBEB7bUBB2KHZMiPA5XNX/WDuTR9cmj2A== X-Google-Smtp-Source: APXvYqwmh3ulgn0EABQHYB0AM8fCIBo5cQgjBqcE8IZGhxeYY1z6j4rys4fhwfTs5bwchYNQT+/bNXfyQ5AyV1tD6I8= X-Received: by 2002:a9d:3466:: with SMTP id v93mr17829216otb.312.1565737487864; Tue, 13 Aug 2019 16:04:47 -0700 (PDT) MIME-Version: 1.0 References: <1565731976.8572.16.camel@lca.pw> <5d533b43.1c69fb81.5729.a6bc@mx.google.com> In-Reply-To: <5d533b43.1c69fb81.5729.a6bc@mx.google.com> From: Tri Vo Date: Tue, 13 Aug 2019 16:04:37 -0700 Message-ID: Subject: Re: "PM / wakeup: Show wakeup sources stats in sysfs" causes boot warnings To: Stephen Boyd Cc: Qian Cai , Peter Zijlstra , Greg Kroah-Hartman , "Rafael J. Wysocki" , Linux PM , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, Aug 13, 2019 at 3:35 PM Stephen Boyd wrote: > > Quoting Qian Cai (2019-08-13 14:32:56) > > The linux-next commit "PM / wakeup: Show wakeup sources stats in sysfs" [1] > > introduced some baddies during boot on several x86 servers. Reverted the commit > > fixed the issue. > > > > [1] https://lore.kernel.org/lkml/20190807014846.143949-4-trong@android.com/ > > > > [ 39.195053][ T1] serio: i8042 KBD port at 0x60,0x64 irq 1 > > [ 39.197347][ T1] kobject_add_internal failed for wakeup (error: -2 parent: > > serio0) > > [ 39.199845][ T1] INFO: trying to register non-static key. > > [ 39.201582][ T1] the code is fine but needs lockdep annotation. > > [ 39.203477][ T1] turning off the locking correctness validator. > > [ 39.205399][ T1] CPU: 12 PID: 1 Comm: swapper/0 Not tainted 5.3.0-rc4- > > next-20190813 #3 > > [ 39.207938][ T1] Hardware name: HP ProLiant XL420 Gen9/ProLiant XL420 > > Gen9, BIOS U19 12/27/2015 > > [ 39.210606][ T1] Call Trace: > > [ 39.210606][ T1] dump_stack+0x62/0x9a > > [ 39.210606][ T1] register_lock_class+0x95a/0x960 > > [ 39.210606][ T1] ? __platform_driver_probe+0xcd/0x230 > > [ 39.210606][ T1] ? __platform_create_bundle+0xc0/0xe0 > > [ 39.210606][ T1] ? i8042_init+0x4ec/0x578 > > [ 39.210606][ T1] ? do_one_initcall+0xfe/0x45a > > [ 39.219571][ T1] ? kernel_init_freeable+0x614/0x6a7 > > [ 39.219571][ T1] ? kernel_init+0x11/0x138 > > [ 39.219571][ T1] ? ret_from_fork+0x35/0x40 > > [ 39.219571][ T1] ? is_dynamic_key+0xf0/0xf0 > > [ 39.219571][ T1] ? rwlock_bug.part.0+0x60/0x60 > > [ 39.219571][ T1] ? __debug_check_no_obj_freed+0x8e/0x250 > > [ 39.219571][ T1] __lock_acquire.isra.13+0x5f/0x830 > > [ 39.229491][ T1] ? __debug_check_no_obj_freed+0x152/0x250 > > [ 39.229491][ T1] lock_acquire+0x107/0x220 > > [ 39.229491][ T1] ? __pm_relax.part.2+0x21/0xa0 > > [ 39.229491][ T1] _raw_spin_lock_irqsave+0x35/0x50 > > [ 39.229491][ T1] ? __pm_relax.part.2+0x21/0xa0 > > [ 39.229491][ T1] __pm_relax.part.2+0x21/0xa0 > > [ 39.239588][ T1] wakeup_source_destroy.part.3+0x18/0x190 > > [ 39.239588][ T1] wakeup_source_register+0x43/0x50 > > We shouldn't call wakeup_source_destroy() from the error path in > wakeup_source_register() because that calls __pm_relax() and that takes > a lock that isn't initialized until wakeup_source_add() is called. Can > you try this patch? Right, that makes sense. Thanks for sending a fix, Stephen! What's the preferred procedure for merging this fix? Should we apply this commit on top of pm tree? Or should I resend a new version of the offending patch? Sorry, I'm still new to this.