From: Emil Renner Berthing <kernel@esmil.dk>
To: Lee Jones <lee.jones@linaro.org>
Cc: Rob Herring <robh@kernel.org>, Sebastian Reichel <sre@kernel.org>,
"Andrew F. Davis" <afd@ti.com>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 2/3] mfd: tps65086: Make interrupt line optional
Date: Thu, 15 Jul 2021 13:27:29 +0200 [thread overview]
Message-ID: <CANBLGcwTtHZgJ3XakANOvB6-kiuf7W3igLKzBKW2ZfQ5zN_Y0w@mail.gmail.com> (raw)
In-Reply-To: <YPAYQvhHwPOrnyik@google.com>
On Thu, 15 Jul 2021 at 13:13, Lee Jones <lee.jones@linaro.org> wrote:
> On Wed, 14 Jul 2021, Rob Herring wrote:
> > On Tue, Jul 13, 2021 at 10:18:01AM +0100, Lee Jones wrote:
> > > On Sat, 26 Jun 2021, Emil Renner Berthing wrote:
> > >
> > > > The BeagleV Starlight v0.9 board[1] doesn't have the IRQB line routed to
> > > > the SoC, but it is still useful to be able to reach the PMIC over I2C
> > >
> > > What is still useful?
> > >
> > > The GPIO and Regulator drivers?
> > >
> > > > for the other functionality it provides.
> > > >
> > > > [1] https://github.com/beagleboard/beaglev-starlight
> > > >
> > > > Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
> > > > ---
> > > > .../devicetree/bindings/mfd/ti,tps65086.yaml | 3 ---
> > > > drivers/mfd/tps65086.c | 21 ++++++++++---------
> > > > 2 files changed, 11 insertions(+), 13 deletions(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/mfd/ti,tps65086.yaml b/Documentation/devicetree/bindings/mfd/ti,tps65086.yaml
> > > > index ba638bd10a58..4b629fcc0df9 100644
> > > > --- a/Documentation/devicetree/bindings/mfd/ti,tps65086.yaml
> > > > +++ b/Documentation/devicetree/bindings/mfd/ti,tps65086.yaml
> > > > @@ -87,9 +87,6 @@ additionalProperties: false
> > > > required:
> > > > - compatible
> > > > - reg
> > > > - - interrupts
> > > > - - interrupt-controller
> > > > - - '#interrupt-cells'
> > >
> > > I can't say that I've been keeping up with the latest DT binding
> > > changes, but shouldn't these lines be relocated into some kind of
> > > optional listing?
> > >
> > > Or are optional properties omitted from documentation?
> >
> > Optional properties are the ones not listed in the 'required' list.
>
> Ah, so they are already documented somewhere else in the file?
Yes, just a few lines above.
next prev parent reply other threads:[~2021-07-15 11:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 22:47 [PATCH v1 0/3] BeagleV Starlight reset support Emil Renner Berthing
2021-06-25 22:47 ` [PATCH v1 1/3] dt-bindings: mfd: convert tps65086.txt to YAML Emil Renner Berthing
2021-07-14 20:44 ` Rob Herring
2021-07-14 20:59 ` Emil Renner Berthing
2021-06-25 22:47 ` [PATCH v1 2/3] mfd: tps65086: Make interrupt line optional Emil Renner Berthing
2021-07-13 9:18 ` Lee Jones
2021-07-14 20:38 ` Rob Herring
2021-07-15 11:13 ` Lee Jones
2021-07-15 11:27 ` Emil Renner Berthing [this message]
2021-07-14 20:44 ` Rob Herring
2021-07-20 15:07 ` Lee Jones
2021-07-20 15:09 ` Emil Renner Berthing
2021-07-20 15:32 ` Lee Jones
2021-07-20 15:36 ` Emil Renner Berthing
2021-07-20 16:07 ` Lee Jones
2021-07-20 16:18 ` Emil Renner Berthing
2021-07-20 16:29 ` Lee Jones
2021-06-25 22:47 ` [PATCH v1 3/3] power: reset: Add TPS65086 restart driver Emil Renner Berthing
2021-07-20 16:12 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANBLGcwTtHZgJ3XakANOvB6-kiuf7W3igLKzBKW2ZfQ5zN_Y0w@mail.gmail.com \
--to=kernel@esmil.dk \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).