From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6AF1C3A59F for ; Thu, 29 Aug 2019 16:34:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC07E2339E for ; Thu, 29 Aug 2019 16:34:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wrKlAklp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727946AbfH2QeP (ORCPT ); Thu, 29 Aug 2019 12:34:15 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:32917 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726973AbfH2QeO (ORCPT ); Thu, 29 Aug 2019 12:34:14 -0400 Received: by mail-qt1-f193.google.com with SMTP id v38so4401087qtb.0 for ; Thu, 29 Aug 2019 09:34:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n9l5S2KbsRERhGgBhP1Pu1DL1JLpghBBG1KctWMbhPY=; b=wrKlAklpDzCaK9bitOGvsiE1iRls1xkKTHr1uVj6ML6++yzsbIy4Ss6lHKR/4t+kWB kBWFsevMQv+AgM/3QUQZMUuLjWg5OTvBgfxqQiHHHX66tW4HQ0cbyJdw6Z7A+bvdNRbr zzSU6odPMrenQU/WFUgNqhIZzotjT1I5eoV05DepZXWhc6zk/N4nzQiCscWRFAsp83f5 2mCCoPEUzklIvPUTCncScdjggNIqgZ5lAVE0A/GQ2YfQD/jm7+CBxdARj37Wj589cCgt 8JKM1lQw79QAQpsOnSqj0AI/1GmG00Z5SoJni7fKTOlQKVKf47/4TAlFHKd1YRmsV2lR fxDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n9l5S2KbsRERhGgBhP1Pu1DL1JLpghBBG1KctWMbhPY=; b=qmP2XkVERwGdH5D4vhZZ9OzHddI3HXL6jXpSEylUYyhwcTgOWRy0wMGZx8my/wGPpo UXG8rrPx3pljGNiQhI/LnhBmf6gc8kg5cO055TfVQqUl0iLvR2XYje0gWN2Ranye3l5D 40DBhMSujpgtkfL5WkR2M1y6XFP0oOR28jPjyyJcl81WFt+iuEDpaTWP5lAAffVaQepf 4k3ZXbg4iB+imh2/2NoBwq7t/QaLM9UVHIbmE9+uY3uEc3tCAAC1sqLNmZkq4KaBaiDu 25XVvjURgotctKbEykGr35cHybuSlEIv4KbdgkhQ0yt/ADv2zQQ7UUTx80Uxdd8QND4c AKiQ== X-Gm-Message-State: APjAAAWA58BZpVV8yvPkiFTQ7MczswaO7GYT0owiBjgwfD7I8YI/CsPc cgZUE4izvR2L6wC8ZEmDdsZtam1Tk9ztfTejSu7QIw== X-Google-Smtp-Source: APXvYqybIZXqTwDDQ5W+o0WnOsb/6yXiPOlEJ24WuiGolNzJDgN+eYlJS9toAhvqvDTFL41byEJ0HGyvQWDJPto49aU= X-Received: by 2002:aed:3f47:: with SMTP id q7mr10718052qtf.209.1567096453696; Thu, 29 Aug 2019 09:34:13 -0700 (PDT) MIME-Version: 1.0 References: <66ac3d3707d6296ef85bf1fa321f7f1ee0c02131.1566907161.git.amit.kucheria@linaro.org> <5d65cbe9.1c69fb81.1ceb.2374@mx.google.com> <5d67e6cf.1c69fb81.5aec9.3b71@mx.google.com> In-Reply-To: <5d67e6cf.1c69fb81.5aec9.3b71@mx.google.com> From: Amit Kucheria Date: Thu, 29 Aug 2019 22:04:02 +0530 Message-ID: Subject: Re: [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver To: Stephen Boyd Cc: Daniel Lezcano , Mark Rutland , Rob Herring , Zhang Rui , Andy Gross , Bjorn Andersson , Eduardo Valentin , linux-arm-msm , Linux Kernel Mailing List , Marc Gonzalez , Brian Masney , Linux PM list , DTML Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, Aug 29, 2019 at 8:23 PM Stephen Boyd wrote: > > Quoting Amit Kucheria (2019-08-29 01:48:27) > > On Wed, Aug 28, 2019 at 6:03 AM Stephen Boyd wrote: > > > > > > Quoting Amit Kucheria (2019-08-27 05:14:03) > > > > Define two new required properties to define interrupts and > > > > interrupt-names for tsens. > > > > > > > > Signed-off-by: Amit Kucheria > > > > --- > > > > Documentation/devicetree/bindings/thermal/qcom-tsens.txt | 8 ++++++++ > > > > 1 file changed, 8 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt b/Documentation/devicetree/bindings/thermal/qcom-tsens.txt > > > > index 673cc1831ee9d..686bede72f846 100644 > > > > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt > > > > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.txt > > > > @@ -22,6 +22,8 @@ Required properties: > > > > > > > > - #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. > > > > - #qcom,sensors: Number of sensors in tsens block > > > > +- interrupts: Interrupts generated from Always-On subsystem (AOSS) > > > > > > Is it always one? interrupt-names makes it sound like it. > > > > > > > +- interrupt-names: Must be one of the following: "uplow", "critical" > > > > Will fix to "one or more of the following" > > > > Can we get a known quantity of interrupts for a particular compatible > string instead? Let's be as specific as possible. The index matters too, > so please list them in the order that is desired. I *think* we can predict what platforms have uplow and critical interrupts based on IP version currently[1]. For newer interrupt types, we might need more fine-grained platform compatibles. [1] Caveat: this is based only on the list of platforms I've currently looked at, there might be something internally that breaks these rules.