From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEE9AC31E57 for ; Mon, 17 Jun 2019 09:24:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8F1B820657 for ; Mon, 17 Jun 2019 09:24:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OXa+q3W8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728082AbfFQJYH (ORCPT ); Mon, 17 Jun 2019 05:24:07 -0400 Received: from mail-vs1-f66.google.com ([209.85.217.66]:43073 "EHLO mail-vs1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728072AbfFQJYG (ORCPT ); Mon, 17 Jun 2019 05:24:06 -0400 Received: by mail-vs1-f66.google.com with SMTP id j26so5649494vsn.10 for ; Mon, 17 Jun 2019 02:24:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=umdgKs2bNnJY9HXfHhz3bsUId8Rzs2pzW5jW/1X7NcU=; b=OXa+q3W87tfWQcpF0uxoHITJFizoYAXfcZq6FfD6FQjvMtz7O3qMNV2JbC6Lb8dbyk tTSNEsZi1hjbL/RDXXz3N9giRdYKSEN854FpoX9/iUUStSVj3w+1AtTQp17F3IHSQ4cA /dBxIkWagaqET5jpE6R7i4LSyDiyGTzhKqwbOhwZR4bSX0ftz9fArTAQckU6sSsPMjRy 1bqmWq9MVrlKlS5EAhgGoPJUvY0T0QhLVhyG9Y2dS6mt/ysK1XuoCZeJGwygDPOrTUE9 Gkh13qk1fQ+JkIqyW6D+aTcqn7FxvXHR9GVwZ0PBSA0FRGC3xare5h3Txqq4yVIPYsNz UU3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=umdgKs2bNnJY9HXfHhz3bsUId8Rzs2pzW5jW/1X7NcU=; b=WF2MIwFZ0kpYupUS3i77Nsh/+rZSgDfjBk59TRDjmgRwUq3N2XV6iHBGbBW4Lg9F0r qawgB3bCHeilS16B4L3At0i+JpOAiL/H9FJL/7R4EmaNSebX06tUrNpg0tkmyQ1jRifJ TXcGn672VoVg0N/KftVoegAafEzlgXxkB6Qx5AML+0cY1c7joa7yQT9FD9gPJcL958F4 VwMr00WNeon8pNYMMf3XMz54qq98FTleQW4wc/mw7f/J5/aNPvOuHkdOK1i9IRhRKNTV MrBqJYrsAahXegyDGsK5QKdDQkFAIblnTBWmHMdeWxohSGx3rHdvQOYLPwLhVDkqzjCw 2faA== X-Gm-Message-State: APjAAAUmWdJsHlX8AufZydaXEBZ3QA/v8SVgAeZEwIuCLXTl9G4KS+wh XWr4Zsj7QDiAMSwhuvm5cDummDIsJEYCh/QDHTh5dg== X-Google-Smtp-Source: APXvYqyOCET2BPKPdyrO1g8wp6D6kX3WpCJaKqyNpodbxzbp/Hrk21ppx5tR+0/MBvXjPuoV5Xl4qvbouGDr0Y195AQ= X-Received: by 2002:a67:7a90:: with SMTP id v138mr11246240vsc.200.1560763445423; Mon, 17 Jun 2019 02:24:05 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ulf Hansson Date: Mon, 17 Jun 2019 11:23:29 +0200 Message-ID: Subject: Re: [PATCH V3 2/5] PM / QOS: Pass request type to dev_pm_qos_read_value() To: Viresh Kumar Cc: Rafael Wysocki , Len Brown , Pavel Machek , Kevin Hilman , Daniel Lezcano , Linux PM , Vincent Guittot , Qais.Yousef@arm.com, Matthias Kaehlcke , juri.lelli@gmail.com, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, 10 Jun 2019 at 12:51, Viresh Kumar wrote: > > In order to use dev_pm_qos_read_value(), and other internal routines to > it, to read values for different QoS requests, pass request type as a > parameter to these routines. > > For now, it only supports resume-latency request type. > > Signed-off-by: Viresh Kumar Reviewed-by: Ulf Hansson Kind regards Uffe > --- > Documentation/power/pm_qos_interface.txt | 2 +- > drivers/base/power/domain_governor.c | 4 +-- > drivers/base/power/qos.c | 10 +++--- > drivers/base/power/runtime.c | 2 +- > drivers/cpuidle/governor.c | 2 +- > include/linux/pm_qos.h | 41 +++++++++++++++++------- > 6 files changed, 40 insertions(+), 21 deletions(-) > > diff --git a/Documentation/power/pm_qos_interface.txt b/Documentation/power/pm_qos_interface.txt > index ec7d662d1707..cfcb1df39799 100644 > --- a/Documentation/power/pm_qos_interface.txt > +++ b/Documentation/power/pm_qos_interface.txt > @@ -123,7 +123,7 @@ Will remove the element. After removal it will update the aggregate target and > call the notification trees if the target was changed as a result of removing > the request. > > -s32 dev_pm_qos_read_value(device): > +s32 dev_pm_qos_read_value(device, type): > Returns the aggregated value for a given device's constraints list. > > enum pm_qos_flags_status dev_pm_qos_flags(device, mask) > diff --git a/drivers/base/power/domain_governor.c b/drivers/base/power/domain_governor.c > index 3838045c9277..f66ac46d07d0 100644 > --- a/drivers/base/power/domain_governor.c > +++ b/drivers/base/power/domain_governor.c > @@ -33,7 +33,7 @@ static int dev_update_qos_constraint(struct device *dev, void *data) > * take its current PM QoS constraint (that's the only thing > * known at this point anyway). > */ > - constraint_ns = dev_pm_qos_read_value(dev); > + constraint_ns = dev_pm_qos_read_value(dev, DEV_PM_QOS_RESUME_LATENCY); > constraint_ns *= NSEC_PER_USEC; > } > > @@ -66,7 +66,7 @@ static bool default_suspend_ok(struct device *dev) > td->constraint_changed = false; > td->cached_suspend_ok = false; > td->effective_constraint_ns = 0; > - constraint_ns = __dev_pm_qos_read_value(dev); > + constraint_ns = __dev_pm_qos_read_value(dev, DEV_PM_QOS_RESUME_LATENCY); > > spin_unlock_irqrestore(&dev->power.lock, flags); > > diff --git a/drivers/base/power/qos.c b/drivers/base/power/qos.c > index cfd463212513..7bb88174371f 100644 > --- a/drivers/base/power/qos.c > +++ b/drivers/base/power/qos.c > @@ -92,27 +92,29 @@ EXPORT_SYMBOL_GPL(dev_pm_qos_flags); > /** > * __dev_pm_qos_read_value - Get PM QoS constraint for a given device. > * @dev: Device to get the PM QoS constraint value for. > + * @type: QoS request type. > * > * This routine must be called with dev->power.lock held. > */ > -s32 __dev_pm_qos_read_value(struct device *dev) > +s32 __dev_pm_qos_read_value(struct device *dev, enum dev_pm_qos_req_type type) > { > lockdep_assert_held(&dev->power.lock); > > - return dev_pm_qos_raw_read_value(dev); > + return dev_pm_qos_raw_read_value(dev, type); > } > > /** > * dev_pm_qos_read_value - Get PM QoS constraint for a given device (locked). > * @dev: Device to get the PM QoS constraint value for. > + * @type: QoS request type. > */ > -s32 dev_pm_qos_read_value(struct device *dev) > +s32 dev_pm_qos_read_value(struct device *dev, enum dev_pm_qos_req_type type) > { > unsigned long flags; > s32 ret; > > spin_lock_irqsave(&dev->power.lock, flags); > - ret = __dev_pm_qos_read_value(dev); > + ret = __dev_pm_qos_read_value(dev, type); > spin_unlock_irqrestore(&dev->power.lock, flags); > > return ret; > diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c > index 952a1e7057c7..92ffc2a0151d 100644 > --- a/drivers/base/power/runtime.c > +++ b/drivers/base/power/runtime.c > @@ -275,7 +275,7 @@ static int rpm_check_suspend_allowed(struct device *dev) > || (dev->power.request_pending > && dev->power.request == RPM_REQ_RESUME)) > retval = -EAGAIN; > - else if (__dev_pm_qos_read_value(dev) == 0) > + else if (__dev_pm_qos_read_value(dev, DEV_PM_QOS_RESUME_LATENCY) == 0) > retval = -EPERM; > else if (dev->power.runtime_status == RPM_SUSPENDED) > retval = 1; > diff --git a/drivers/cpuidle/governor.c b/drivers/cpuidle/governor.c > index 9fddf828a76f..fb5659eb2009 100644 > --- a/drivers/cpuidle/governor.c > +++ b/drivers/cpuidle/governor.c > @@ -110,7 +110,7 @@ int cpuidle_governor_latency_req(unsigned int cpu) > { > int global_req = pm_qos_request(PM_QOS_CPU_DMA_LATENCY); > struct device *device = get_cpu_device(cpu); > - int device_req = dev_pm_qos_raw_read_value(device); > + int device_req = dev_pm_qos_raw_read_value(device, DEV_PM_QOS_RESUME_LATENCY); > > return device_req < global_req ? device_req : global_req; > } > diff --git a/include/linux/pm_qos.h b/include/linux/pm_qos.h > index 1f4d456e8fff..55814d48c39c 100644 > --- a/include/linux/pm_qos.h > +++ b/include/linux/pm_qos.h > @@ -139,8 +139,8 @@ s32 pm_qos_read_value(struct pm_qos_constraints *c); > #ifdef CONFIG_PM > enum pm_qos_flags_status __dev_pm_qos_flags(struct device *dev, s32 mask); > enum pm_qos_flags_status dev_pm_qos_flags(struct device *dev, s32 mask); > -s32 __dev_pm_qos_read_value(struct device *dev); > -s32 dev_pm_qos_read_value(struct device *dev); > +s32 __dev_pm_qos_read_value(struct device *dev, enum dev_pm_qos_req_type type); > +s32 dev_pm_qos_read_value(struct device *dev, enum dev_pm_qos_req_type type); > int dev_pm_qos_add_request(struct device *dev, struct dev_pm_qos_request *req, > enum dev_pm_qos_req_type type, s32 value); > int dev_pm_qos_update_request(struct dev_pm_qos_request *req, s32 new_value); > @@ -176,11 +176,19 @@ static inline s32 dev_pm_qos_requested_flags(struct device *dev) > return dev->power.qos->flags_req->data.flr.flags; > } > > -static inline s32 dev_pm_qos_raw_read_value(struct device *dev) > +static inline s32 dev_pm_qos_raw_read_value(struct device *dev, > + enum dev_pm_qos_req_type type) > { > - return IS_ERR_OR_NULL(dev->power.qos) ? > - PM_QOS_RESUME_LATENCY_NO_CONSTRAINT : > - pm_qos_read_value(&dev->power.qos->resume_latency); > + struct dev_pm_qos *qos = dev->power.qos; > + > + switch (type) { > + case DEV_PM_QOS_RESUME_LATENCY: > + return IS_ERR_OR_NULL(qos) ? PM_QOS_RESUME_LATENCY_NO_CONSTRAINT > + : pm_qos_read_value(&qos->resume_latency); > + default: > + WARN_ON(1); > + return 0; > + } > } > #else > static inline enum pm_qos_flags_status __dev_pm_qos_flags(struct device *dev, > @@ -189,10 +197,6 @@ static inline enum pm_qos_flags_status __dev_pm_qos_flags(struct device *dev, > static inline enum pm_qos_flags_status dev_pm_qos_flags(struct device *dev, > s32 mask) > { return PM_QOS_FLAGS_UNDEFINED; } > -static inline s32 __dev_pm_qos_read_value(struct device *dev) > - { return PM_QOS_RESUME_LATENCY_NO_CONSTRAINT; } > -static inline s32 dev_pm_qos_read_value(struct device *dev) > - { return PM_QOS_RESUME_LATENCY_NO_CONSTRAINT; } > static inline int dev_pm_qos_add_request(struct device *dev, > struct dev_pm_qos_request *req, > enum dev_pm_qos_req_type type, > @@ -245,10 +249,23 @@ static inline s32 dev_pm_qos_requested_resume_latency(struct device *dev) > return PM_QOS_RESUME_LATENCY_NO_CONSTRAINT; > } > static inline s32 dev_pm_qos_requested_flags(struct device *dev) { return 0; } > -static inline s32 dev_pm_qos_raw_read_value(struct device *dev) > + > +static inline s32 dev_pm_qos_raw_read_value(struct device *dev, > + enum dev_pm_qos_req_type type) > { > - return PM_QOS_RESUME_LATENCY_NO_CONSTRAINT; > + switch type { > + case DEV_PM_QOS_RESUME_LATENCY: > + return PM_QOS_RESUME_LATENCY_NO_CONSTRAINT; > + default: > + WARN_ON(1); > + return 0; > + } > } > + > +static inline s32 __dev_pm_qos_read_value(struct device *dev, enum dev_pm_qos_req_type type) > + { return dev_pm_qos_raw_read_value(dev, type); } > +static inline s32 dev_pm_qos_read_value(struct device *dev, enum dev_pm_qos_req_type type) > + { return dev_pm_qos_raw_read_value(dev, type); } > #endif > > #endif > -- > 2.21.0.rc0.269.g1a574e7a288b >