From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24B37C433E7 for ; Mon, 31 Aug 2020 10:58:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03815208CA for ; Mon, 31 Aug 2020 10:58:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FWfmKzY8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726468AbgHaK6T (ORCPT ); Mon, 31 Aug 2020 06:58:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726249AbgHaK6P (ORCPT ); Mon, 31 Aug 2020 06:58:15 -0400 Received: from mail-vs1-xe43.google.com (mail-vs1-xe43.google.com [IPv6:2607:f8b0:4864:20::e43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B65CC061755 for ; Mon, 31 Aug 2020 03:58:14 -0700 (PDT) Received: by mail-vs1-xe43.google.com with SMTP id b16so2960366vsl.6 for ; Mon, 31 Aug 2020 03:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nb3cs3W2I9yxQBIg3cdHDlV7kIJB+7DEi6PeKTo8Eug=; b=FWfmKzY8I4/to8pNWD+NRmED0JdcgjGghZCt02Q/PD2WPltmddNnEU7gh9Yiai14nc 5h02XEuhqDhrTPOFUO/jMmv6W2EHW1IArLgTQJ+Sc/+vACeFQN6fT7sYeVPwiLOBhSj6 kpuETe5M0yfTLShfo0XhaW1RCGbqmCYBl2rx4o0sm6zxS5tF1l4rNjgsZq4sfpGZXD2M 0NLBlph1iU+t1j7PGe9HdpA7hdYobAJt2ag2kLqU1EsmSuBi/TSNHAlkc+9QhyTIGfpG H0Pu8zTVR2cfljtJUd5zZkb+Kfdyxj4/hW9QNaJS+avJDDLzfZ5bv3udlqA28rqDjeBh sDNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nb3cs3W2I9yxQBIg3cdHDlV7kIJB+7DEi6PeKTo8Eug=; b=Ja5e+AM56Kcyhv0965JQFqWnlracIC7oBxrwN/bvAZeoTZUyX3DONhMKcJLihpiIHM jzU4s2n4UiGZaLcljAWEt45H8Es2YJWFHaEjRk/MJ2p8d9LsU6wA0QHyQrDI1c4A0SI8 KHwr/CToAJCh9cOEexhoTz7QcY+Ix91zPZ6JMK7ojhX3/Fpz5y1QfogeuvvR2Kqua1iW 7lvhDQ9OidTX+qQlmBC16xnduwNk7M7LHHOnfOMe0ehTh+DvSNTnVA89ywKGFixCfcEG JmsYVVO8IScuEJRPHjn9f3Vi3/e8M+VbFfARi4JxhB3GI4eGwHrz2I8ojZBQfT3jgZcK pDIg== X-Gm-Message-State: AOAM531L0aABMrZDlXfs8pohN5U552J0XfBR9NiHdP46U3Tgn0euPsPs Wn1F7zN1VXymqBOhXn6yAOIT9zqpsnjBQ6a73qrM9w== X-Google-Smtp-Source: ABdhPJwAM6SX62N09ud6DGQlvIZyV+WjRiF2eKERvJGlTG7C+O5xt0gwAmiMgQUZbjyRUjEQwt7NFwqBL8NyDQy4oTk= X-Received: by 2002:a67:7c4e:: with SMTP id x75mr445921vsc.60.1598871492254; Mon, 31 Aug 2020 03:58:12 -0700 (PDT) MIME-Version: 1.0 References: <1d7c97524b9e1fbc60271d9c246c5461ca8a106c.1598594714.git.viresh.kumar@linaro.org> <20200831104453.ux5fb5bpt57tj5am@vireshk-i7> In-Reply-To: <20200831104453.ux5fb5bpt57tj5am@vireshk-i7> From: Ulf Hansson Date: Mon, 31 Aug 2020 12:57:35 +0200 Message-ID: Subject: Re: [PATCH V2 4/8] mmc: sdhci-msm: Unconditionally call dev_pm_opp_of_remove_table() To: Viresh Kumar Cc: Rajendra Nayak , Adrian Hunter , Andy Gross , Bjorn Andersson , Linux PM , Vincent Guittot , Rafael Wysocki , Stephen Boyd , Nishanth Menon , Douglas Anderson , Naresh Kamboju , linux-arm-msm , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, 31 Aug 2020 at 12:45, Viresh Kumar wrote: > > On 28-08-20, 10:43, Ulf Hansson wrote: > > On Fri, 28 Aug 2020 at 08:08, Viresh Kumar wrote: > > > > > > dev_pm_opp_of_remove_table() doesn't report any errors when it fails to > > > find the OPP table with error -ENODEV (i.e. OPP table not present for > > > the device). And we can call dev_pm_opp_of_remove_table() > > > unconditionally here. > > > > > > Signed-off-by: Viresh Kumar > > > > Replaced v1 with v2 on my next branch, thanks! > > > > Just to be sure, this patch doesn't depend on any changes for the opp > > core that are queued for v5.10? > > The recent crashes reported by Anders and Naresh were related to a OPP > core bug, for which I have just sent the fix here: > > https://lore.kernel.org/lkml/922ff0759a16299e24cacfc981ac07914d8f1826.1598865786.git.viresh.kumar@linaro.org/ > > This is already tested by Naresh now and finally everything works as > expected. > > I am going to get this fix merged in 5.9-rc4, but we do have a > dependency now with that fix. > > What's the best way to handle this stuff now ? The easiest IMO would > be for me to send these patches through the OPP tree, otherwise people > need to carry this and the OPP fix (for which I can provide the > branch/tag). No need for a tag/branch to be shared. Instead I am simply going to defer to pick up any related changes for mmc, until I can rebase my tree on an rc[n] that contains your fix. When that is possible, please re-post the mmc patches. Kind regards Uffe