From: Ulf Hansson <ulf.hansson@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Kevin Hilman <khilman@linaro.org>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH V2 1/3] PM / Domains: Initial PM clock support for genpd
Date: Fri, 28 Nov 2014 08:26:28 +0100 [thread overview]
Message-ID: <CAPDyKFp8sSCAt-oZTex-UG1RAFUYQBRPwbKuGmYiGP+0OtaTYw@mail.gmail.com> (raw)
In-Reply-To: <3169286.RI9fuSo8ZA@vostro.rjw.lan>
>
> If you defined the flag as
>
> #define PM_DOMAIN_FLAGS_PM_CLK (1U << 0)
>
> (which is a kind of usual way to do that), you wouldn't need the
> bitops.h above.
>
> Moreover, I personally don't like #defines in struct definitions.
>
>>
>> @@ -76,6 +77,8 @@ struct generic_pm_domain {
>> struct device *dev);
>> void (*detach_dev)(struct generic_pm_domain *domain,
>> struct device *dev);
>> + unsigned int flags; /* Bit field of configs for genpd */
>> +#define PM_DOMAIN_PM_CLK BIT(0) /* PM domain uses PM clk */
While I fix your above comments, I wonder whether I actually also
should change the prefix of the define as well.
>From "PM_DOMAIN" to "GENPD". Cause I think it's a genpd specific
define and not a "PM domain" define. Please tell me if you have any
objections to that.
>> };
>>
>> static inline struct generic_pm_domain *pd_to_genpd(struct dev_pm_domain *pd)
>>
>
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
Thanks for review!
Kind regards
Uffe
next prev parent reply other threads:[~2014-11-28 7:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 14:51 [PATCH V2 0/3] PM / Domains: Add initial PM clock support to genpd Ulf Hansson
2014-11-27 14:51 ` [PATCH V2 1/3] PM / Domains: Initial PM clock support for genpd Ulf Hansson
2014-11-28 0:05 ` Rafael J. Wysocki
2014-11-28 7:26 ` Ulf Hansson [this message]
2014-11-27 14:51 ` [PATCH V2 2/3] ARM: shmobile: Convert to genpd flags for PM clocks for r8a7779 Ulf Hansson
2014-11-27 14:51 ` [PATCH V2 3/3] ARM: shmobile: Convert to genpd flags for PM clocks for R-mobile Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFp8sSCAt-oZTex-UG1RAFUYQBRPwbKuGmYiGP+0OtaTYw@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=arnd@arndb.de \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=grygorii.strashko@ti.com \
--cc=horms@verge.net.au \
--cc=khilman@linaro.org \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).