From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05A02ECE58E for ; Thu, 17 Oct 2019 09:04:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF36E21848 for ; Thu, 17 Oct 2019 09:04:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="W2e51Z68" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439364AbfJQJEq (ORCPT ); Thu, 17 Oct 2019 05:04:46 -0400 Received: from mail-vk1-f194.google.com ([209.85.221.194]:33394 "EHLO mail-vk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2439363AbfJQJEq (ORCPT ); Thu, 17 Oct 2019 05:04:46 -0400 Received: by mail-vk1-f194.google.com with SMTP id s21so348032vkm.0 for ; Thu, 17 Oct 2019 02:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3YEZ6kmrwj0jmNEINZ5DrxfXAkCY+f5snursTVbXw/Q=; b=W2e51Z687HKzqeEUxw8//AMcHGkkuFOP8XPRGjOfymWxiy5Zp1IsFw7JpdMcbsWu2b 3XRp9hda4U35V3m4NBdsGLbwORsP7M6z6hcLgkBMeNdc6Kv9H54zl1XG8UyqG3oVaiRA uYXbj1yTpmGTc5+j3xXkUibu704TmnkPoO2sjQNeCRQIL58QuDsOIAezBG7b14OxBFv6 5FbrylzIeAFhCyolzRmA8yt6ll3bpHI/fYR97EcEQ3jn9UGLTrm83xRCCHz8AS86pmze m1mdnFdbPnS0BElbdxvOVcKomZv+rfTKsUOZ1i3MKBNxnh2hdw7vJ49G7aVlAm37710n WkLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3YEZ6kmrwj0jmNEINZ5DrxfXAkCY+f5snursTVbXw/Q=; b=dRJ5NTSwkIFRJUwLTgs5mw2SEEjOyWOxjCyVkZyHQS+OG2SDisNqQQxs1BKJN2+D7n UpUNKKXHqLczrGOP8bZiWggWZUIiO1HHr3QkLekomPAi+K3gR+PnnaYiPLfGubFzMsAa aF5Jrb7v8TB9IUFqk/IdFxtslqDmQJ9ihm0BXK+e+e0tT7r0UqaQZ4IHrh1u30Z1S+53 z0FEFisOaQBVncz/a58tDuzldVcGfzq/4bFZcjRhl/DPKZW+V6Dt5ERA/Q8BfyilKFc7 /kNS8+QBsSqnF7uRnsfHzyyGoMx8O00WzYM3CAki27zEttOGdjDHav96MFHJGOhQABrO 4K8w== X-Gm-Message-State: APjAAAX1wQCKQFC+XH64Lm0KbrnPC7GoQIZjsIFc2JicZl5BsyDfUCAH NpLKVNGYJXSCqJxj7gaweAte0G76zKt5MBjXTgphvQ== X-Google-Smtp-Source: APXvYqyt8CM8fHUNAOrVRVddOgQGQx8mRNb41o6lI3llgLFlyRzgA5YeS309L///NMZr8TxyMVq1MEKf6S7M8tbxb2E= X-Received: by 2002:a1f:b202:: with SMTP id b2mr1313280vkf.59.1571303083600; Thu, 17 Oct 2019 02:04:43 -0700 (PDT) MIME-Version: 1.0 References: <1571254641-13626-1-git-send-email-thara.gopinath@linaro.org> <1571254641-13626-7-git-send-email-thara.gopinath@linaro.org> In-Reply-To: <1571254641-13626-7-git-send-email-thara.gopinath@linaro.org> From: Ulf Hansson Date: Thu, 17 Oct 2019 11:04:07 +0200 Message-ID: Subject: Re: [PATCH v3 6/7] dt-bindings: soc: qcom: Extend RPMh power controller binding to describe thermal warming device To: Thara Gopinath Cc: Eduardo Valentin , Zhang Rui , Daniel Lezcano , Bjorn Andersson , Andy Gross , amit.kucheria@verdurent.com, Mark Rutland , "Rafael J. Wysocki" , Linux PM , DTML , linux-arm-msm , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Wed, 16 Oct 2019 at 21:37, Thara Gopinath wrote: > > RPMh power controller hosts mx domain that can be used as thermal > warming device. Add a sub-node to specify this. > > Signed-off-by: Thara Gopinath > --- > Documentation/devicetree/bindings/power/qcom,rpmpd.txt | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.txt b/Documentation/devicetree/bindings/power/qcom,rpmpd.txt > index eb35b22..fff695d 100644 > --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.txt > +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.txt > @@ -18,6 +18,16 @@ Required Properties: > Refer to for the level values for > various OPPs for different platforms as well as Power domain indexes > > += SUBNODES > +RPMh alsp hosts power domains that can behave as thermal warming device. > +These are expressed as subnodes of the RPMh. The name of the node is used > +to identify the power domain and must therefor be "mx". > + > +- #cooling-cells: > + Usage: optional > + Value type: > + Definition: must be 2 > + Just wanted to express a minor thought about this. In general we use subnodes of PM domain providers to represent the topology of PM domains (subdomains), this is something different, which I guess is fine. I assume the #cooling-cells is here tells us this is not a PM domain provider, but a "cooling device provider"? Also, I wonder if it would be fine to specify "power-domains" here, rather than using "name" as I think that is kind of awkward!? > Example: rpmh power domain controller and OPP table > > #include > -- > 2.1.4 > Kind regards Uffe