From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 905C8C4740A for ; Mon, 9 Sep 2019 18:21:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B03120692 for ; Mon, 9 Sep 2019 18:21:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="l3i7Hnvx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729796AbfIISVE (ORCPT ); Mon, 9 Sep 2019 14:21:04 -0400 Received: from mo4-p02-ob.smtp.rzone.de ([81.169.146.170]:21305 "EHLO mo4-p02-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729035AbfIISVE (ORCPT ); Mon, 9 Sep 2019 14:21:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1568053262; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=Sk5OR4pmbgyWkeMqms3Ra2DZT4PK2j+gZDf8HZXEQFc=; b=l3i7HnvxNpjhSvJXwLhtOnaY2jlXz2BJ5MkTqfxlfTGfweDaIosqrBXFRVdh4mUSq3 wUFa/0r0iESKne++pD2+l39TFnO7a36uVzmISC3wCLc0ZHm4hvbccnOvCHZ26ZD9RKbD UPemUYm8143kegF/wbtLprFUCgsyKUGOB26LjcHIRls/MSzEUgGxF864G2MHTVvzHoAD sjMmHxUSoZJxjPtQW8oyXiXEQxzikw72Omc7hUSPY8JRQbwLKEpxGTvKmbqU8rmCCrmD nEV3UAlVynO1EzVc70v89AQzonVxJWANRXzFnNdJAIP1b9WObNXM32ALs7DMcYddkQse Z8QQ== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj4Qpw9iZeHmMnw4vkig==" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 44.27.0 DYNA|AUTH) with ESMTPSA id u036f9v89IKhy5y (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Mon, 9 Sep 2019 20:20:43 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH 1/2] cpufreq: ti-cpufreq: Add support for AM3517 From: "H. Nikolaus Schaller" In-Reply-To: Date: Mon, 9 Sep 2019 20:20:43 +0200 Cc: Linux-OMAP , =?utf-8?Q?Andr=C3=A9_Roth?= , Discussions about the Letux Kernel , Andreas Kemnade , Tony Lindgren , Adam Ford , =?utf-8?Q?Beno=C3=AEt_Cousson?= , Rob Herring , Mark Rutland , "Rafael J. Wysocki" , Viresh Kumar , devicetree , Linux Kernel Mailing List , linux-pm@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20190909154502.19804-1-aford173@gmail.com> <6081134F-AACD-412C-B36A-BF9463C9712B@goldelico.com> To: Adam Ford X-Mailer: Apple Mail (2.3124) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi, > Am 09.09.2019 um 20:17 schrieb Adam Ford : >=20 > On Mon, Sep 9, 2019 at 1:13 PM H. Nikolaus Schaller = wrote: >>=20 >> Hi Adam, >>=20 >>> Am 09.09.2019 um 17:45 schrieb Adam Ford : >>>=20 >>> The AM3517 only lists 600MHz @ 1.2V, but the revister values for >>=20 >> a small typo... >>=20 >> s/revister/register/ >>=20 >>> 0x4830A204 =3D 1b86 802f, it seems like am3517 might be a derivative >>> of the omap36 which has OPPs would be OPP50 (300 MHz) and OPP100 >>> (600 MHz). >>>=20 >>> This patch simply enable adds the am3517 to the compatible table >>> using the omap3630 structure instead of the 3430. >>>=20 >>> Signed-off-by: Adam Ford >>>=20 >>> diff --git a/drivers/cpufreq/ti-cpufreq.c = b/drivers/cpufreq/ti-cpufreq.c >>> index f2f58d689320..6b69fb1d6bdf 100644 >>> --- a/drivers/cpufreq/ti-cpufreq.c >>> +++ b/drivers/cpufreq/ti-cpufreq.c >>> @@ -270,6 +270,7 @@ static int = ti_cpufreq_setup_syscon_register(struct ti_cpufreq_data *opp_data) >>>=20 >>> static const struct of_device_id ti_cpufreq_of_match[] =3D { >>> { .compatible =3D "ti,am33xx", .data =3D &am3x_soc_data, }, >>> + { .compatible =3D "ti,am3517", .data =3D &omap36xx_soc_data, = }, >>> { .compatible =3D "ti,am43", .data =3D &am4x_soc_data, }, >>> { .compatible =3D "ti,dra7", .data =3D &dra7_soc_data }, >>> { .compatible =3D "ti,omap34xx", .data =3D &omap34xx_soc_data, = }, >>> -- >>> 2.17.1 >>>=20 >>=20 >> Looks good to me. >>=20 >> Should I include your two patches to my patch set (and resend)? >> Or should we keep them separated? >=20 > Go ahead and take credit for them. I just did what you told me to do > and tested them. Well, you are still the Author, the one who wrote down the ideas :) I think git will even keep the author name untouched. > Go ahead and mark it as Tested-by with my name. Best is to keep your Signed-Off + mine and add a tested-by as well :) BR and thanks, Nikolaus