From: Anson Huang <anson.huang@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: "rui.zhang@intel.com" <rui.zhang@intel.com>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"amit.kucheria@verdurent.com" <amit.kucheria@verdurent.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH V2] dt-bindings: thermal: Convert i.MX to json-schema
Date: Wed, 13 May 2020 06:55:34 +0000 [thread overview]
Message-ID: <DB3PR0402MB39167476CE5FA107505A78C5F5BF0@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <DB3PR0402MB3916B60832507A72F39750EAF5D50@DB3PR0402MB3916.eurprd04.prod.outlook.com>
Hi, Rob
> Subject: RE: [PATCH V2] dt-bindings: thermal: Convert i.MX to json-schema
>
> Hi, Rob
>
>
> > Subject: Re: [PATCH V2] dt-bindings: thermal: Convert i.MX to
> > json-schema
> >
> > On Fri, Apr 10, 2020 at 09:07:24AM +0800, Anson Huang wrote:
> > > Convert the i.MX thermal binding to DT schema format using
> > > json-schema
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > > ---
> > > Changes since V1:
> > > - make clock property optional.
> > > ---
> > > .../devicetree/bindings/thermal/imx-thermal.txt | 61 --------------
> > > .../devicetree/bindings/thermal/imx-thermal.yaml | 96
> > ++++++++++++++++++++++
> > > 2 files changed, 96 insertions(+), 61 deletions(-) delete mode
> > > 100644 Documentation/devicetree/bindings/thermal/imx-thermal.txt
> > > create mode 100644
> > > Documentation/devicetree/bindings/thermal/imx-thermal.yaml
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/thermal/imx-thermal.txt
> > > b/Documentation/devicetree/bindings/thermal/imx-thermal.txt
> > > deleted file mode 100644
> > > index 823e417..0000000
> > > +
> > > +title: NXP i.MX Thermal Binding
> > > +
> > > +maintainers:
> > > + - Anson Huang <Anson.Huang@nxp.com>
> > > +
> > > +properties:
> > > + compatible:
> > > + oneOf:
> > > + - items:
> > > + - enum:
> > > + - fsl,imx6q-tempmon
> > > + - fsl,imx6sx-tempmon
> > > + - fsl,imx7d-tempmon
> > > +
> > > + interrupts:
> > > + description: |
> > > + The interrupt output of the controller, the IRQ will be triggered
> > > + when temperature is higher than high threshold.
> > > + maxItems: 1
> > > +
> > > + nvmem-cells:
> > > + description: |
> > > + Phandle to the calibration cells provided by ocotp for calibration
> > > + data and temperature grade.
> > > + maxItems: 2
> > > +
> > > + nvmem-cell-names:
> > > + maxItems: 2
> > > + items:
> > > + - const: calib
> > > + - const: temp_grade
> > > +
> > > + fsl,tempmon:
> > > + $ref: '/schemas/types.yaml#/definitions/phandle'
> > > + description: |
> > > + Phandle pointer to system controller that contains TEMPMON
> > control
> > > + registers, e.g. ANATOP on imx6q.
> >
> > Really, this should have been a child of the system controller. Not
> > too late to do that, but you'd need to keep this for compatibility.
>
> Sorry, I don't quite get your point, can you provide more details or example,
> thanks.
I guess you meant the tempmon node should be put inside anatop node? Then
DT files also needs to be changed? Right?
anatop: anatop@20c8000 {
compatible = "fsl,imx6sx-anatop", "fsl,imx6q-anatop",
"syscon", "simple-mfd";
reg = <0x020c8000 0x1000>;
interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>;
...
};
tempmon: tempmon {
compatible = "fsl,imx6sx-tempmon", "fsl,imx6q-tempmon";
interrupt-parent = <&gpc>;
interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;
fsl,tempmon = <&anatop>;
nvmem-cells = <&tempmon_calib>, <&tempmon_temp_grade>;
nvmem-cell-names = "calib", "temp_grade";
clocks = <&clks IMX6SX_CLK_PLL3_USB_OTG>;
};
Thanks,
Anson
next prev parent reply other threads:[~2020-05-13 6:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 1:07 [PATCH V2] dt-bindings: thermal: Convert i.MX to json-schema Anson Huang
2020-04-20 18:35 ` Rob Herring
2020-04-21 14:31 ` Anson Huang
2020-05-13 6:55 ` Anson Huang [this message]
2020-05-20 6:02 Anson Huang
2020-05-20 7:42 ` Aisheng Dong
2020-05-20 8:03 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0402MB39167476CE5FA107505A78C5F5BF0@DB3PR0402MB3916.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).