From: "Yuan, Perry" <Perry.Yuan@amd.com>
To: "Limonciello, Mario" <Mario.Limonciello@amd.com>,
"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
"Huang, Ray" <Ray.Huang@amd.com>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>
Cc: "Sharma, Deepak" <Deepak.Sharma@amd.com>,
"Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Huang, Shimmer" <Shimmer.Huang@amd.com>,
"Du, Xiaojian" <Xiaojian.Du@amd.com>,
"Meng, Li (Jassmine)" <Li.Meng@amd.com>,
"Karny, Wyes" <Wyes.Karny@amd.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v9 13/13] Documentation: amd-pstate: introduce new global sysfs attributes
Date: Thu, 5 Jan 2023 06:21:13 +0000 [thread overview]
Message-ID: <DM4PR12MB52783BFE1051AE668E360B1F9CFA9@DM4PR12MB5278.namprd12.prod.outlook.com> (raw)
In-Reply-To: <583d3642-a79e-fee0-5c90-84eac82c3812@amd.com>
[AMD Official Use Only - General]
Hi Mario.
> -----Original Message-----
> From: Limonciello, Mario <Mario.Limonciello@amd.com>
> Sent: Wednesday, January 4, 2023 8:35 AM
> To: Yuan, Perry <Perry.Yuan@amd.com>; rafael.j.wysocki@intel.com; Huang,
> Ray <Ray.Huang@amd.com>; viresh.kumar@linaro.org
> Cc: Sharma, Deepak <Deepak.Sharma@amd.com>; Fontenot, Nathan
> <Nathan.Fontenot@amd.com>; Deucher, Alexander
> <Alexander.Deucher@amd.com>; Huang, Shimmer
> <Shimmer.Huang@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>; Meng,
> Li (Jassmine) <Li.Meng@amd.com>; Karny, Wyes <Wyes.Karny@amd.com>;
> linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v9 13/13] Documentation: amd-pstate: introduce new
> global sysfs attributes
>
> On 12/25/2022 10:34, Perry Yuan wrote:
> > The amd-pstate driver supports switching working modes at runtime.
> > Users can view and change modes by interacting with the "status" sysfs
> > attribute.
> >
> > 1) check driver mode:
> > $ cat /sys/devices/system/cpu/amd-pstate/status
> >
> > 2) switch mode:
> > `# echo "passive" | sudo tee
> > /sys/devices/system/cpu/amd-pstate/status`
> > or
> > `# echo "active" | sudo tee /sys/devices/system/cpu/amd-pstate/status`
> >
> > Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> > ---
> > Documentation/admin-guide/pm/amd-pstate.rst | 29
> +++++++++++++++++++++
> > 1 file changed, 29 insertions(+)
> >
> > diff --git a/Documentation/admin-guide/pm/amd-pstate.rst
> > b/Documentation/admin-guide/pm/amd-pstate.rst
> > index 62744dae3c5f..5f6379475b32 100644
> > --- a/Documentation/admin-guide/pm/amd-pstate.rst
> > +++ b/Documentation/admin-guide/pm/amd-pstate.rst
> > @@ -339,6 +339,35 @@ processor must provide at least nominal
> performance requested and go higher if c
> > operating conditions allow.
> >
> >
> > +User Space Interface in ``sysfs``
> > +=================================
> > +
> > +Global Attributes
> > +-----------------
> > +
> > +``amd-pstate`` exposes several global attributes (files) in ``sysfs``
> > +to control its functionality at the system level. They are located
> > +in the ``/sys/devices/system/cpu/amd-pstate/`` directory and affect all
> CPUs.
> > +
> > +``status``
> > + Operation mode of the driver: "active", "passive" or "disable".
> > +
> > + "active"
> > + The driver is functional and in the ``active mode``
> > +
> > + "passive"
> > + The driver is functional and in the ``passive mode``
> > +
> > + "disable"
> > + The driver is unregistered and not functional now.
> > +
> > + This attribute can be written to in order to change the driver's
> > + operation mode or to unregister it. The string written to it must be
> > + one of the possible values of it and, if successful, writing one of
> > + these values to the sysfs file will cause the driver to cause
> > + the driver
>
> "will cause the driver to cause the driver to"?
>
> Presumably you mean just "will cause the driver to"
>
> With that fixed:
>
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Thanks for the review, will fix the words and pick up the RB tag in v10.
Perry.
>
> > + to switch over to the operation mode represented by that string - or
> to be
> > + unregistered in the "disable" case.
> > +
> > ``cpupower`` tool support for ``amd-pstate``
> > ===============================================
> >
prev parent reply other threads:[~2023-01-05 6:21 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-25 16:34 [PATCH v9 00/13] Implement AMD Pstate EPP Driver Perry Yuan
2022-12-25 16:34 ` [PATCH v9 01/13] ACPI: CPPC: Add AMD pstate energy performance preference cppc control Perry Yuan
2023-01-05 5:31 ` Wyes Karny
2023-01-05 6:02 ` Yuan, Perry
2022-12-25 16:34 ` [PATCH v9 02/13] Documentation: amd-pstate: add EPP profiles introduction Perry Yuan
2023-01-04 0:29 ` Limonciello, Mario
2023-01-05 3:18 ` Yuan, Perry
2022-12-25 16:34 ` [PATCH v9 03/13] cpufreq: intel_pstate: use common macro definition for Energy Preference Performance(EPP) Perry Yuan
2023-01-04 0:31 ` Limonciello, Mario
2023-01-05 5:49 ` Yuan, Perry
2023-01-05 5:56 ` Mario Limonciello
2023-01-05 6:14 ` Yuan, Perry
2022-12-25 16:34 ` [PATCH v9 04/13] cpufreq: amd-pstate: fix kernel hang issue while amd-pstate unregistering Perry Yuan
2022-12-27 2:53 ` Viresh Kumar
2022-12-27 6:32 ` Yuan, Perry
2022-12-25 16:34 ` [PATCH v9 05/13] cpufreq: amd-pstate: optimize driver working mode selection in amd_pstate_param() Perry Yuan
2023-01-04 0:32 ` Limonciello, Mario
2022-12-25 16:34 ` [PATCH v9 06/13] cpufreq: amd-pstate: implement Pstate EPP support for the AMD processors Perry Yuan
2023-01-04 1:05 ` Limonciello, Mario
2023-01-05 6:20 ` Yuan, Perry
2023-01-06 5:22 ` Wyes Karny
2023-01-06 5:58 ` Yuan, Perry
2022-12-25 16:34 ` [PATCH v9 07/13] cpufreq: amd-pstate: implement amd pstate cpu online and offline callback Perry Yuan
2022-12-25 16:34 ` [PATCH v9 08/13] cpufreq: amd-pstate: implement suspend and resume callbacks Perry Yuan
2022-12-27 2:52 ` Viresh Kumar
2023-01-05 15:08 ` Yuan, Perry
2022-12-25 16:34 ` [PATCH v9 09/13] cpufreq: amd-pstate: add driver working mode switch support Perry Yuan
2023-01-04 1:06 ` Limonciello, Mario
2023-01-05 6:02 ` Wyes Karny
2023-01-05 6:57 ` Yuan, Perry
2023-01-05 7:29 ` Wyes Karny
2023-01-05 16:03 ` Wyes Karny
2023-01-06 2:52 ` Yuan, Perry
2023-01-06 3:46 ` Wyes Karny
2022-12-25 16:34 ` [PATCH v9 10/13] Documentation: amd-pstate: add amd pstate driver mode introduction Perry Yuan
2022-12-25 16:34 ` [PATCH v9 11/13] Documentation: introduce amd pstate active mode kernel command line options Perry Yuan
2022-12-25 16:34 ` [PATCH v9 12/13] cpufreq: amd-pstate: convert sprintf with sysfs_emit() Perry Yuan
2022-12-25 16:34 ` [PATCH v9 13/13] Documentation: amd-pstate: introduce new global sysfs attributes Perry Yuan
2023-01-04 0:35 ` Limonciello, Mario
2023-01-05 6:21 ` Yuan, Perry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB52783BFE1051AE668E360B1F9CFA9@DM4PR12MB5278.namprd12.prod.outlook.com \
--to=perry.yuan@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Deepak.Sharma@amd.com \
--cc=Li.Meng@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Nathan.Fontenot@amd.com \
--cc=Ray.Huang@amd.com \
--cc=Shimmer.Huang@amd.com \
--cc=Wyes.Karny@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).