From: "Yuan, Perry" <Perry.Yuan@amd.com>
To: "Limonciello, Mario" <Mario.Limonciello@amd.com>,
"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
"Huang, Ray" <Ray.Huang@amd.com>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>
Cc: "Sharma, Deepak" <Deepak.Sharma@amd.com>,
"Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
"Huang, Shimmer" <Shimmer.Huang@amd.com>,
"Du, Xiaojian" <Xiaojian.Du@amd.com>,
"Meng, Li (Jassmine)" <Li.Meng@amd.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/7] cpufreq: amd_pstate: add module parameter to load amd pstate EPP driver
Date: Tue, 13 Sep 2022 15:14:13 +0000 [thread overview]
Message-ID: <DM4PR12MB52785281752518053A305D519C479@DM4PR12MB5278.namprd12.prod.outlook.com> (raw)
In-Reply-To: <abb1ec0e-2a1f-09bc-f11c-8e5be4526927@amd.com>
[AMD Official Use Only - General]
HI Mario
> -----Original Message-----
> From: Limonciello, Mario <Mario.Limonciello@amd.com>
> Sent: Saturday, September 10, 2022 2:50 AM
> To: Yuan, Perry <Perry.Yuan@amd.com>; rafael.j.wysocki@intel.com; Huang,
> Ray <Ray.Huang@amd.com>; viresh.kumar@linaro.org
> Cc: Sharma, Deepak <Deepak.Sharma@amd.com>; Fontenot, Nathan
> <Nathan.Fontenot@amd.com>; Deucher, Alexander
> <Alexander.Deucher@amd.com>; Su, Jinzhou (Joe) <Jinzhou.Su@amd.com>;
> Huang, Shimmer <Shimmer.Huang@amd.com>; Du, Xiaojian
> <Xiaojian.Du@amd.com>; Meng, Li (Jassmine) <Li.Meng@amd.com>; linux-
> pm@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 2/7] cpufreq: amd_pstate: add module parameter to
> load amd pstate EPP driver
>
> On 9/9/2022 11:45, Perry Yuan wrote:
> > The amd_pstate mode parameter will allow user to select which amd
> > pstate working mode as booting mode, amd_pstate instance or
> amd_pstate_epp instance.
> >
> > 1) amd_pstate instance is depending on the target operation mode.
> > 2) amd_pstate_epp instance is depending on the set_policy operation
> mode.It
> > is also called active mode that AMD SMU has EPP algorithm to control the
> > CPU runtime frequency according to the EPP set value and workload.
> >
> > Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> > ---
> > drivers/cpufreq/amd-pstate.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/cpufreq/amd-pstate.c
> > b/drivers/cpufreq/amd-pstate.c index a2463f785322..451295284a26 100644
> > --- a/drivers/cpufreq/amd-pstate.c
> > +++ b/drivers/cpufreq/amd-pstate.c
> > @@ -58,6 +58,12 @@ module_param(shared_mem, bool, 0444);
> > MODULE_PARM_DESC(shared_mem,
> > "enable amd-pstate on processors with shared memory
> solution
> > (false = disabled (default), true = enabled)");
> >
> > +static bool epp_enabled = true;
> > +module_param(epp_enabled, bool, 0444);
> MODULE_PARM_DESC(epp_enabled,
> > + "load amd_pstate or amd_pstate_epp (true =
> > +amd_pstate_epp driver instance (default), false = amd_pstate driver
> > +instance)");
> > +
>
> If you're operating in EPP mode or not the kernel module is still 'amd-pstate'.
> So to a user I think this is a pretty confusing designation.
>
> I would propose the following instead:
>
> > +static bool epp = true;
> > +module_param(epp, bool, 0444);
> > +MODULE_PARM_DESC(epp,
> > + "Enable energy performance preference (EPP) control");
>
> > +
> > static struct cpufreq_driver amd_pstate_driver;
> >
> > /**
Make sense, will make this change in the V2.
Thanks.
Perry.
next prev parent reply other threads:[~2022-09-13 16:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 16:45 [PATCH 0/7] Implement AMD Pstate EPP Driver Perry Yuan
2022-09-09 16:45 ` [PATCH 1/7] ACPI: CPPC: Add AMD pstate energy performance preference cppc control Perry Yuan
2022-09-09 16:45 ` [PATCH 2/7] cpufreq: amd_pstate: add module parameter to load amd pstate EPP driver Perry Yuan
2022-09-09 18:49 ` Limonciello, Mario
2022-09-13 15:14 ` Yuan, Perry [this message]
2022-09-25 16:58 ` Yuan, Perry
2022-09-09 16:45 ` [PATCH 3/7] Documentation: amd-pstate: add EPP profiles introduction Perry Yuan
2022-09-09 16:45 ` [PATCH 4/7] cpufreq: amd_pstate: add AMD pstate EPP support for shared memory type processor Perry Yuan
2022-09-09 18:52 ` Limonciello, Mario
2022-09-13 15:20 ` Yuan, Perry
2022-09-25 17:01 ` Yuan, Perry
2022-09-15 16:24 ` Nathan Fontenot
2022-09-25 12:23 ` Yuan, Perry
2022-09-29 14:08 ` Nathan Fontenot
2022-09-09 16:45 ` [PATCH 5/7] cpufreq: amd_pstate: add AMD Pstate EPP support for the MSR based processors Perry Yuan
2022-09-15 18:58 ` Nathan Fontenot
2022-09-25 17:12 ` Yuan, Perry
2022-09-09 16:45 ` [PATCH 6/7] cpufreq: amd_pstate: implement amd pstate cpu online and offline callback Perry Yuan
2022-09-09 19:02 ` Limonciello, Mario
2022-09-15 19:03 ` Nathan Fontenot
2022-09-09 16:45 ` [PATCH 7/7] cpufreq: amd-pstate: implement suspend and resume callbacks Perry Yuan
2022-09-09 19:00 ` Limonciello, Mario
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB52785281752518053A305D519C479@DM4PR12MB5278.namprd12.prod.outlook.com \
--to=perry.yuan@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Deepak.Sharma@amd.com \
--cc=Jinzhou.Su@amd.com \
--cc=Li.Meng@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Nathan.Fontenot@amd.com \
--cc=Ray.Huang@amd.com \
--cc=Shimmer.Huang@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).