From: Peng Fan <peng.fan@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
"djakov@kernel.org" <djakov@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
Abel Vesa <abel.vesa@nxp.com>,
"abailon@baylibre.com" <abailon@baylibre.com>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"laurent.pinchart@ideasonboard.com"
<laurent.pinchart@ideasonboard.com>,
"marex@denx.de" <marex@denx.de>,
"paul.elder@ideasonboard.com" <paul.elder@ideasonboard.com>,
"Markus.Niebel@ew.tq-group.com" <Markus.Niebel@ew.tq-group.com>,
"aford173@gmail.com" <aford173@gmail.com>
Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH 1/8] dt-bindings: interconnect: imx8m: Add bindings for imx8mp noc
Date: Wed, 1 Jun 2022 12:06:07 +0000 [thread overview]
Message-ID: <DU0PR04MB9417380EC27688B3DFB9326388DF9@DU0PR04MB9417.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <cf90d9aa-1ba9-9619-35b7-8c2de436fc12@linaro.org>
> Subject: Re: [PATCH 1/8] dt-bindings: interconnect: imx8m: Add bindings for
> imx8mp noc
>
> On 01/06/2022 11:41, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > i.MX8MP features same NoC/NIC as i.MX8MM/N/Q, and use two compatible
> > strings.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > .../devicetree/bindings/interconnect/fsl,imx8m-noc.yaml | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml
> > b/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml
> > index b8204ed22dd5..0923cd28d6c6 100644
> > ---
> > a/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml
> > +++ b/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yam
> > +++ l
> > @@ -26,16 +26,22 @@ properties:
> > oneOf:
> > - items:
> > - enum:
> > + - fsl,imx8mp-nic
>
> Please order the entries alphabetically, so 8mp goes after 8mm.
>
> > - fsl,imx8mn-nic
> > - fsl,imx8mm-nic
> > - fsl,imx8mq-nic
> > - const: fsl,imx8m-nic
> > - items:
> > - enum:
> > + - fsl,imx8mp-noc
>
> ditto
>
> > - fsl,imx8mn-noc
> > - fsl,imx8mm-noc
> > - fsl,imx8mq-noc
> > - const: fsl,imx8m-noc
> > + - items:
> > + - const: fsl,imx8mp-noc
> > + - const: fsl,imx8m-noc
> > + - const: syscon
>
> This is a bit confusing - why this is also fallbacked as syscon?
I thought to give some flexibility for drivers to access the
address through syscon. But it could be removed, I could
fix in V2.
Thanks,
Peng.
>
> > - const: fsl,imx8m-nic
> >
> > reg:
>
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2022-06-01 12:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 9:41 [PATCH 0/8] interconnect: support i.MX8MP Peng Fan (OSS)
2022-06-01 9:41 ` [PATCH 1/8] dt-bindings: interconnect: imx8m: Add bindings for imx8mp noc Peng Fan (OSS)
2022-06-01 11:55 ` Krzysztof Kozlowski
2022-06-01 12:06 ` Peng Fan [this message]
2022-06-01 12:13 ` Krzysztof Kozlowski
2022-06-01 9:41 ` [PATCH 2/8] interconnect: add device managed bulk API Peng Fan (OSS)
2022-06-01 12:33 ` kernel test robot
2022-06-01 13:15 ` kernel test robot
2022-06-01 13:37 ` kernel test robot
2022-06-01 14:58 ` kernel test robot
2022-06-13 18:27 ` Georgi Djakov
2022-06-01 9:41 ` [PATCH 3/8] interconnect: imx: fix max_node_id Peng Fan (OSS)
2022-06-04 0:14 ` Laurent Pinchart
2022-06-13 1:17 ` Peng Fan
2022-06-01 9:41 ` [PATCH 4/8] interconnect: imx: set src node Peng Fan (OSS)
2022-06-01 9:41 ` [PATCH 5/8] interconnect: imx: introduce imx_icc_provider Peng Fan (OSS)
2022-06-01 9:41 ` [PATCH 6/8] interconnect: imx: set of_node for interconnect provider Peng Fan (OSS)
2022-06-01 9:41 ` [PATCH 7/8] interconnect: imx: configure NoC mode/prioriry/ext_control Peng Fan (OSS)
2022-06-01 9:41 ` [PATCH 8/8] interconnect: imx: Add platform driver for imx8mp Peng Fan (OSS)
2022-06-01 11:56 ` Krzysztof Kozlowski
2022-06-01 12:03 ` Peng Fan
2022-06-13 1:23 ` [PATCH 0/8] interconnect: support i.MX8MP Peng Fan
2022-06-14 17:39 ` Lucas Stach
2022-06-14 23:38 ` Peng Fan
2022-06-15 9:06 ` Lucas Stach
2022-06-15 9:28 ` Peng Fan
2022-06-15 10:30 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DU0PR04MB9417380EC27688B3DFB9326388DF9@DU0PR04MB9417.eurprd04.prod.outlook.com \
--to=peng.fan@nxp.com \
--cc=Markus.Niebel@ew.tq-group.com \
--cc=abailon@baylibre.com \
--cc=abel.vesa@nxp.com \
--cc=aford173@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marex@denx.de \
--cc=paul.elder@ideasonboard.com \
--cc=peng.fan@oss.nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).