From: Matthias Kaehlcke <mka@chromium.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Thara Gopinath <thara.gopinath@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: sdm845: mtp: Add vadc channels and thermal zones
Date: Wed, 29 Sep 2021 11:40:37 -0700 [thread overview]
Message-ID: <YVSzJZ8G43CLml3L@google.com> (raw)
In-Reply-To: <20210923212311.2877048-5-bjorn.andersson@linaro.org>
On Thu, Sep 23, 2021 at 02:23:11PM -0700, Bjorn Andersson wrote:
> Downstream defines four ADC channels related to thermal sensors external
> to the PM8998 and two channels for internal voltage measurements.
>
> Add these to the upstream SDM845 MTP, describe the thermal monitor
> channels and add thermal_zones for these.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>
> In addition to the iio channels exposed by v1, Daniel wanted thermal_zones...
>
> Changes since v1:
> - Enable the pm8998_adc_tm and describe the ADC channels
> - Add thermal-zones for the new channels
>
> arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 128 ++++++++++++++++++++++++
> 1 file changed, 128 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> index 52dd7a858231..e3b40daef801 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> @@ -10,6 +10,8 @@
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> #include "sdm845.dtsi"
> +#include "pm8998.dtsi"
> +#include "pmi8998.dtsi"
>
> / {
> model = "Qualcomm Technologies, Inc. SDM845 MTP";
> @@ -46,6 +48,68 @@ vreg_s4a_1p8: pm8998-smps4 {
>
> vin-supply = <&vph_pwr>;
> };
> +
> + thermal-zones {
> + xo_thermal: xo-thermal {
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
> +
> + thermal-sensors = <&pm8998_adc_tm 1>;
> +
> + trips {
> + trip-point {
> + temperature = <125000>;
> + hysteresis = <10000>;
> + type = "passive";
> + };
> + };
> + };
> +
> + msm_thermal: msm-thermal {
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
> +
> + thermal-sensors = <&pm8998_adc_tm 2>;
> +
> + trips {
> + trip-point {
> + temperature = <125000>;
> + hysteresis = <10000>;
> + type = "passive";
> + };
> + };
> + };
> +
> + pa_thermal: pa-thermal {
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
> +
> + thermal-sensors = <&pm8998_adc_tm 3>;
> +
> + trips {
> + trip-point {
> + temperature = <125000>;
> + hysteresis = <10000>;
> + type = "passive";
> + };
> + };
> + };
> +
> + quiet_thermal: quiet-thermal {
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
> +
> + thermal-sensors = <&pm8998_adc_tm 4>;
> +
> + trips {
> + trip-point {
> + temperature = <125000>;
> + hysteresis = <10000>;
> + type = "passive";
> + };
> + };
> + };
> + };
> };
>
> &adsp_pas {
> @@ -469,6 +533,70 @@ &mss_pil {
> firmware-name = "qcom/sdm845/mba.mbn", "qcom/sdm845/modem.mbn";
> };
>
> +&pm8998_adc {
> + adc-chan@4c {
> + reg = <ADC5_XO_THERM_100K_PU>;
> + label = "xo_therm";
> + };
> +
> + adc-chan@4d {
> + reg = <ADC5_AMUX_THM1_100K_PU>;
> + label = "msm_therm";
> + };
> +
> + adc-chan@4f {
> + reg = <ADC5_AMUX_THM3_100K_PU>;
> + label = "pa_therm1";
> + };
> +
> + adc-chan@51 {
> + reg = <ADC5_AMUX_THM5_100K_PU>;
> + label = "quiet_therm";
> + };
> +
> + adc-chan@83 {
> + reg = <ADC5_VPH_PWR>;
> + label = "vph_pwr";
> + };
> +
> + adc-chan@85 {
> + reg = <ADC5_VCOIN>;
> + label = "vcoin";
> + };
> +};
> +
> +&pm8998_adc_tm {
> + status = "okay";
> +
> + xo-thermistor@1 {
> + reg = <1>;
> + io-channels = <&pm8998_adc ADC5_XO_THERM_100K_PU>;
> + qcom,ratiometric;
> + qcom,hw-settle-time-us = <200>;
> + };
> +
> + msm-thermistor@2 {
> + reg = <2>;
> + io-channels = <&pm8998_adc ADC5_AMUX_THM1_100K_PU>;
> + qcom,ratiometric;
> + qcom,hw-settle-time-us = <200>;
> + };
> +
> + pa-thermistor@3 {
> + reg = <3>;
> + io-channels = <&pm8998_adc ADC5_AMUX_THM3_100K_PU>;
> + qcom,ratiometric;
> + qcom,hw-settle-time-us = <200>;
> + };
> +
> + quiet-thermistor@4 {
> + reg = <4>;
> + io-channels = <&pm8998_adc ADC5_AMUX_THM5_100K_PU>;
> + qcom,ratiometric;
> + qcom,hw-settle-time-us = <200>;
> + };
> +};
> +
The example in the 'qcom,spmi-adc-tm5' binding specifies 'qcom,ratiometric'
and 'qcom,hw-settle-time-us' for both the ADC and the thermal monitor, so do
several board files (e.g. sm8250-mtp.dts and qrb5165-rb5.dts). This apparent
redundancy bothered me earlier, it's not really clear to me whether it's
needed/recommended or not. Do you happen to have any insights on this?
next prev parent reply other threads:[~2021-09-29 18:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 21:23 [PATCH v2 0/4] arm64: dts: qcom: sdm845: Add thermal zones for PM8998 ADC Bjorn Andersson
2021-09-23 21:23 ` [PATCH v2 1/4] dt-bindings: thermal: qcom: add HC variant of adc-thermal monitor bindings Bjorn Andersson
2021-09-23 21:23 ` [PATCH v2 2/4] thermal/drivers/qcom/spmi-adc-tm5: Add support for HC variant Bjorn Andersson
2021-09-29 19:55 ` Vladimir Zapolskiy
2021-09-23 21:23 ` [PATCH v2 3/4] arm64: dts: qcom: pm8998: Add ADC Thermal Monitor node Bjorn Andersson
2021-11-18 22:04 ` Dmitry Baryshkov
2021-09-23 21:23 ` [PATCH v2 4/4] arm64: dts: qcom: sdm845: mtp: Add vadc channels and thermal zones Bjorn Andersson
2021-09-29 18:40 ` Matthias Kaehlcke [this message]
2021-10-04 20:15 ` Bjorn Andersson
2021-10-04 20:56 ` Dmitry Baryshkov
2021-10-05 3:12 ` Bjorn Andersson
2021-10-05 20:30 ` Thara Gopinath
2021-10-05 21:52 ` Bjorn Andersson
2021-10-05 22:21 ` Thara Gopinath
2021-10-05 22:47 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVSzJZ8G43CLml3L@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).