From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux ACPI <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Mark Gross <markgross@kernel.org>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v2 12/16] platform/x86/thinkpad_acpi: Use acpi_dev_for_each_child()
Date: Mon, 13 Jun 2022 21:54:36 +0300 [thread overview]
Message-ID: <YqeH7G8pJMelXYaJ@smile.fi.intel.com> (raw)
In-Reply-To: <2091400.OBFZWjSADL@kreacher>
On Mon, Jun 13, 2022 at 08:30:19PM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Instead of walking the list of children of an ACPI device directly,
> use acpi_dev_for_each_child() to carry out an action for all of
> the given ACPI device's children.
>
> This will help to eliminate the children list head from struct
> acpi_device as it is redundant and it is used in questionable ways
> in some places (in particular, locking is needed for walking the
> list pointed to it safely, but it is often missing).
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>
> v1 -> v2:
> * Eliminate unnecessary branch (Andy).
>
> ---
> drivers/platform/x86/thinkpad_acpi.c | 53 +++++++++++++++++------------------
> 1 file changed, 27 insertions(+), 26 deletions(-)
>
> Index: linux-pm/drivers/platform/x86/thinkpad_acpi.c
> ===================================================================
> --- linux-pm.orig/drivers/platform/x86/thinkpad_acpi.c
> +++ linux-pm/drivers/platform/x86/thinkpad_acpi.c
> @@ -6841,6 +6841,31 @@ static const struct backlight_ops ibm_ba
>
> /* --------------------------------------------------------------------- */
>
> +static int __init tpacpi_evaluate_bcl(struct acpi_device *adev, void *not_used)
> +{
> + struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
> + union acpi_object *obj;
> + acpi_status status;
> + int rc;
> +
> + status = acpi_evaluate_object(adev->handle, "_BCL", NULL, &buffer);
> + if (ACPI_FAILURE(status))
> + return 0;
> +
> + obj = buffer.pointer;
> + if (!obj || obj->type != ACPI_TYPE_PACKAGE) {
> + acpi_handle_info(adev->handle,
> + "Unknown _BCL data, please report this to %s\n",
> + TPACPI_MAIL);
> + rc = 0;
> + } else {
> + rc = obj->package.count;
> + }
> + kfree(obj);
> +
> + return rc;
> +}
> +
> /*
> * Call _BCL method of video device. On some ThinkPads this will
> * switch the firmware to the ACPI brightness control mode.
> @@ -6848,37 +6873,13 @@ static const struct backlight_ops ibm_ba
>
> static int __init tpacpi_query_bcl_levels(acpi_handle handle)
> {
> - struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
> - union acpi_object *obj;
> - struct acpi_device *device, *child;
> - int rc;
> + struct acpi_device *device;
>
> device = acpi_fetch_acpi_dev(handle);
> if (!device)
> return 0;
>
> - rc = 0;
> - list_for_each_entry(child, &device->children, node) {
> - acpi_status status = acpi_evaluate_object(child->handle, "_BCL",
> - NULL, &buffer);
> - if (ACPI_FAILURE(status)) {
> - buffer.length = ACPI_ALLOCATE_BUFFER;
> - continue;
> - }
> -
> - obj = (union acpi_object *)buffer.pointer;
> - if (!obj || (obj->type != ACPI_TYPE_PACKAGE)) {
> - pr_err("Unknown _BCL data, please report this to %s\n",
> - TPACPI_MAIL);
> - rc = 0;
> - } else {
> - rc = obj->package.count;
> - }
> - break;
> - }
> -
> - kfree(buffer.pointer);
> - return rc;
> + return acpi_dev_for_each_child(device, tpacpi_evaluate_bcl, NULL);
> }
>
>
>
>
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-06-13 20:17 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 13:44 [PATCH v1 00/16] ACPI: Get rid of the list of children in struct acpi_device Rafael J. Wysocki
2022-06-09 13:47 ` [PATCH v1 01/16] ACPI: glue: Use acpi_dev_for_each_child() Rafael J. Wysocki
2022-06-09 13:49 ` [PATCH v1 02/16] ACPI: glue: Introduce acpi_dev_has_children() Rafael J. Wysocki
2022-06-09 13:54 ` [PATCH v1 03/16] ACPI: glue: Introduce acpi_find_child_by_adr() Rafael J. Wysocki
2022-06-09 13:54 ` [PATCH v1 04/16] thunderbolt: ACPI: Use acpi_find_child_by_adr() Rafael J. Wysocki
2022-06-09 15:25 ` Andy Shevchenko
2022-06-09 15:36 ` Rafael J. Wysocki
2022-06-10 6:46 ` Heikki Krogerus
2022-06-10 13:12 ` Rafael J. Wysocki
2022-06-09 13:56 ` [PATCH v1 05/16] USB: " Rafael J. Wysocki
2022-06-09 15:27 ` Andy Shevchenko
2022-06-09 15:37 ` Rafael J. Wysocki
2022-06-10 6:47 ` Heikki Krogerus
2022-06-10 13:14 ` Rafael J. Wysocki
2022-06-09 13:58 ` [PATCH v1 06/16] ACPI: container: Use acpi_dev_for_each_child() Rafael J. Wysocki
2022-06-09 15:29 ` Andy Shevchenko
2022-06-09 15:58 ` Rafael J. Wysocki
2022-06-09 13:59 ` [PATCH v1 07/16] ACPI: property: Use acpi_dev_for_each_child() for child lookup Rafael J. Wysocki
2022-06-09 14:02 ` [PATCH v1 08/16] ACPI: bus: Export acpi_dev_for_each_child() to modules Rafael J. Wysocki
2022-06-09 14:03 ` [PATCH v1 09/16] ACPI: video: Use acpi_dev_for_each_child() Rafael J. Wysocki
2022-06-09 15:40 ` Andy Shevchenko
2022-06-09 14:06 ` [PATCH v1 10/16] ACPI: bus: Introduce acpi_dev_for_each_child_reverse() Rafael J. Wysocki
2022-06-09 15:40 ` Andy Shevchenko
2022-06-09 14:07 ` [PATCH v1 11/16] ACPI: scan: Walk ACPI device's children using driver core Rafael J. Wysocki
2022-06-09 14:09 ` [PATCH v1 12/16] platform/x86/thinkpad_acpi: Use acpi_dev_for_each_child() Rafael J. Wysocki
2022-06-09 15:48 ` Andy Shevchenko
2022-06-09 15:56 ` Rafael J. Wysocki
2022-06-09 14:12 ` [PATCH v1 13/16] mfd: core: " Rafael J. Wysocki
2022-06-09 14:16 ` [PATCH v1 14/16] soundwire: " Rafael J. Wysocki
2022-06-09 15:22 ` Pierre-Louis Bossart
2022-06-09 16:13 ` Rafael J. Wysocki
2022-06-09 16:21 ` Pierre-Louis Bossart
2022-06-09 17:35 ` Rafael J. Wysocki
2022-06-09 19:08 ` Pierre-Louis Bossart
2022-06-09 14:18 ` [PATCH v1 15/16] ACPI / MMC: PM: Unify fixing up device power Rafael J. Wysocki
2022-06-09 15:33 ` Adrian Hunter
2022-06-10 12:16 ` Ulf Hansson
2022-06-09 14:19 ` [PATCH v1 16/16] ACPI: bus: Drop unused list heads from struct acpi_device Rafael J. Wysocki
2022-06-09 15:12 ` [PATCH v1 00/16] ACPI: Get rid of the list of children in " Andy Shevchenko
2022-06-09 20:24 ` Frank Rowand
2022-06-09 15:56 ` Andy Shevchenko
2022-06-09 15:59 ` Rafael J. Wysocki
2022-06-13 18:03 ` [PATCH v2 " Rafael J. Wysocki
2022-06-13 18:05 ` [PATCH v2 01/16] ACPI: glue: Use acpi_dev_for_each_child() Rafael J. Wysocki
2022-06-13 18:06 ` [PATCH v2 02/16] ACPI: glue: Introduce acpi_dev_has_children() Rafael J. Wysocki
2022-06-13 18:10 ` [PATCH v2 03/16] ACPI: glue: Introduce acpi_find_child_by_adr() Rafael J. Wysocki
2022-06-13 18:11 ` [PATCH v2 04/16] thunderbolt: ACPI: Replace tb_acpi_find_port() with acpi_find_child_by_adr() Rafael J. Wysocki
2022-06-13 18:55 ` Andy Shevchenko
2022-06-14 6:07 ` Mika Westerberg
2022-06-14 18:25 ` Rafael J. Wysocki
2022-06-15 6:27 ` Mika Westerberg
2022-06-15 19:52 ` Rafael J. Wysocki
2022-06-14 7:36 ` Heikki Krogerus
2022-06-13 18:15 ` [PATCH v2 06/16] ACPI: container: Use acpi_dev_for_each_child() Rafael J. Wysocki
2022-06-13 18:16 ` [PATCH v2 07/16] ACPI: property: Use acpi_dev_for_each_child() for child lookup Rafael J. Wysocki
2022-06-13 18:26 ` [PATCH v2 08/16] ACPI: bus: Export acpi_dev_for_each_child() to modules Rafael J. Wysocki
2022-06-13 18:26 ` [PATCH v2 09/16] ACPI: video: Use acpi_dev_for_each_child() Rafael J. Wysocki
2022-06-13 18:26 ` [PATCH v2 10/16] ACPI: bus: Introduce acpi_dev_for_each_child_reverse() Rafael J. Wysocki
2022-06-13 18:27 ` [PATCH v2 11/16] ACPI: scan: Walk ACPI device's children using driver core Rafael J. Wysocki
2022-06-13 18:30 ` [PATCH v2 12/16] platform/x86/thinkpad_acpi: Use acpi_dev_for_each_child() Rafael J. Wysocki
2022-06-13 18:54 ` Andy Shevchenko [this message]
2022-06-13 20:50 ` Hans de Goede
2022-06-13 18:31 ` [PATCH v2 13/16] mfd: core: " Rafael J. Wysocki
2022-06-15 22:39 ` Lee Jones
2022-06-16 17:31 ` Rafael J. Wysocki
2022-06-27 11:38 ` [GIT PULL] Immutable branch between MFD and ACPI due for the v5.20 merge window Lee Jones
2022-06-27 12:15 ` Rafael J. Wysocki
2022-06-13 18:35 ` [PATCH v2 14/16] soundwire: Use acpi_dev_for_each_child() Rafael J. Wysocki
2022-06-23 8:10 ` Vinod Koul
2022-06-23 12:29 ` Rafael J. Wysocki
2022-06-23 12:41 ` Vinod Koul
2022-06-23 13:26 ` Rafael J. Wysocki
2022-06-13 18:36 ` [PATCH v2 15/16] ACPI / MMC: PM: Unify fixing up device power Rafael J. Wysocki
2022-06-13 18:38 ` [PATCH v2 16/16] ACPI: bus: Drop unused list heads from struct acpi_device Rafael J. Wysocki
2022-06-13 18:39 ` [PATCH v2 05/16] USB: ACPI: Replace usb_acpi_find_port() with acpi_find_child_by_adr() Rafael J. Wysocki
2022-06-13 18:53 ` Andy Shevchenko
2022-06-14 7:37 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqeH7G8pJMelXYaJ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).