From: Greg KH <gregkh@linuxfoundation.org>
To: Alex Elder <elder@linaro.org>
Cc: Douglas Anderson <dianders@chromium.org>,
stable@vger.kernel.org, swboyd@chromium.org,
Mike Tipton <mdtipton@codeaurora.org>,
Georgi Djakov <djakov@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Georgi Djakov <georgi.djakov@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [5.10 PATCH] interconnect: qcom: icc-rpmh: Add BCMs to commit list in pre_aggregate
Date: Sat, 24 Sep 2022 11:34:13 +0200 [thread overview]
Message-ID: <Yy7PFenCa0Sa3B3n@kroah.com> (raw)
In-Reply-To: <00eb82ca-8bf6-c744-d04d-96b97ce06b17@linaro.org>
On Thu, Sep 22, 2022 at 04:28:25PM -0500, Alex Elder wrote:
> On 9/22/22 4:18 PM, Douglas Anderson wrote:
> > From: Mike Tipton <mdtipton@codeaurora.org>
> >
> > commit b95b668eaaa2574e8ee72f143c52075e9955177e upstream.
> >
> > We're only adding BCMs to the commit list in aggregate(), but there are
> > cases where pre_aggregate() is called without subsequently calling
> > aggregate(). In particular, in icc_sync_state() when a node with initial
> > BW has zero requests. Since BCMs aren't added to the commit list in
> > these cases, we don't actually send the zero BW request to HW. So the
> > resources remain on unnecessarily.
> >
> > Add BCMs to the commit list in pre_aggregate() instead, which is always
> > called even when there are no requests.
> >
> > Signed-off-by: Mike Tipton <mdtipton@codeaurora.org>
> > [georgi: remove icc_sync_state for platforms with incomplete support]
> > Link: https://lore.kernel.org/r/20211125174751.25317-1-djakov@kernel.org
> > Signed-off-by: Georgi Djakov <djakov@kernel.org>
> > [dianders: dropped sm8350.c which isn't present in 5.10]
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
>
> Whoops, sorry about that.
>
> Acked-by: Alex Elder <elder@linaro.org>
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2022-09-24 9:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 21:18 [5.10 PATCH] interconnect: qcom: icc-rpmh: Add BCMs to commit list in pre_aggregate Douglas Anderson
2022-09-22 21:28 ` Alex Elder
2022-09-24 9:34 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy7PFenCa0Sa3B3n@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=djakov@kernel.org \
--cc=elder@linaro.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mdtipton@codeaurora.org \
--cc=stable@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).