From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Sebastian Reichel <sre@kernel.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v2 2/3] extcon: max14577: Add proper dt-compatible strings
Date: Fri, 22 May 2020 10:30:55 +0200 [thread overview]
Message-ID: <a1f499fa-1907-93f5-6f57-13187ae10d7e@samsung.com> (raw)
In-Reply-To: <8ec0c604-8cdc-04f8-fc5c-fd967f52022b@samsung.com>
Hi Chanwoo,
On 22.05.2020 09:08, Chanwoo Choi wrote:
> On 5/22/20 3:48 PM, Marek Szyprowski wrote:
>> Add device tree compatible strings and create proper modalias structures
>> to let this driver load automatically if compiled as module, because
>> max14577 MFD driver creates MFD cells with such compatible strings.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> ---
>> v2:
>> - added .of_match_table pointer
>> ---
>> drivers/extcon/extcon-max14577.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c
>> index 32f663436e6e..03af678ddeba 100644
>> --- a/drivers/extcon/extcon-max14577.c
>> +++ b/drivers/extcon/extcon-max14577.c
>> @@ -782,9 +782,19 @@ static const struct platform_device_id max14577_muic_id[] = {
>> };
>> MODULE_DEVICE_TABLE(platform, max14577_muic_id);
>>
>> +static const struct of_device_id of_max14577_muic_dt_match[] = {
>> + { .compatible = "maxim,max77836-muic",
>> + .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, },
>> + { .compatible = "maxim,max14577-muic",
>> + .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, },
>> + { },
> How about changing the order between max77836 and max14577 as already added structure
> like platform_device_id if there are no specific reason as following:?
>
>
> static const struct of_device_id of_max14577_muic_dt_match[] = {
> { .compatible = "maxim,max14577-muic",
> .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, },
> { .compatible = "maxim,max77836-muic",
> .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, },
> { },
Sure. I will swap them and send updated patch. This order comes from
drivers/power/supply/max14577_charger.c, which also lacks
.of_match_table, so I will also fix it.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2020-05-22 8:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200522064806eucas1p120fc21b6e3ae5783e627a3da3761def3@eucas1p1.samsung.com>
2020-05-22 6:47 ` [PATCH v2 1/3] regulator: max14577: Add proper dt-compatible strings Marek Szyprowski
[not found] ` <CGME20200522064807eucas1p2665d6b3928b2ad515abe54513cbd7fd8@eucas1p2.samsung.com>
2020-05-22 6:48 ` [PATCH v2 2/3] extcon: " Marek Szyprowski
2020-05-22 7:08 ` Chanwoo Choi
2020-05-22 8:30 ` Marek Szyprowski [this message]
2020-05-22 9:20 ` Marek Szyprowski
[not found] ` <CGME20200522064807eucas1p2db9a6fe5599cc9d58ea1fb2d9acc36c7@eucas1p2.samsung.com>
2020-05-22 6:48 ` [PATCH v2 3/3] power: charger: " Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1f499fa-1907-93f5-6f57-13187ae10d7e@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).