From: Lukasz Luba <lukasz.luba@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org,
linux-pm@vger.kernel.org, amitk@kernel.org, rui.zhang@intel.com,
dietmar.eggemann@arm.com, Chris.Redpath@arm.com,
Beata.Michalska@arm.com, rjw@rjwysocki.net,
amit.kachhap@gmail.com
Subject: Re: [RFC PATCH 3/4] cpufreq: Add Active Stats calls tracking frequency changes
Date: Tue, 22 Jun 2021 12:07:14 +0100 [thread overview]
Message-ID: <a5d5d6b8-f358-d1d6-86d0-750af76b0cfb@arm.com> (raw)
In-Reply-To: <20210622093258.lddlznwsndpw5mju@vireshk-i7>
On 6/22/21 10:32 AM, Viresh Kumar wrote:
> Not commenting on the idea itself but just the code changes here.
>
> On 22-06-21, 08:59, Lukasz Luba wrote:
>> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
>> index 802abc925b2a..d79cb9310572 100644
>> --- a/drivers/cpufreq/cpufreq.c
>> +++ b/drivers/cpufreq/cpufreq.c
>> @@ -14,6 +14,7 @@
>>
>> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>>
>> +#include <linux/active_stats.h>
>> #include <linux/cpu.h>
>> #include <linux/cpufreq.h>
>> #include <linux/cpu_cooling.h>
>> @@ -387,6 +388,8 @@ static void cpufreq_notify_transition(struct cpufreq_policy *policy,
>>
>> cpufreq_stats_record_transition(policy, freqs->new);
>> policy->cur = freqs->new;
>> +
>> + active_stats_cpu_freq_change(policy->cpu, freqs->new);
>> }
>> }
>>
>> @@ -2085,6 +2088,8 @@ unsigned int cpufreq_driver_fast_switch(struct cpufreq_policy *policy,
>> policy->cpuinfo.max_freq);
>> cpufreq_stats_record_transition(policy, freq);
>>
>> + active_stats_cpu_freq_fast_change(policy->cpu, freq);
>> +
>
> It would have been better if you would have modified
> cpufreq_stats_record_transition() instead, since that is there for
> similar kind of stats.
That cpufreq_stats_record_transition() is present only if
CONFIG_CPU_FREQ_STAT is set. I didn't wanted to be dependent on
this config.
>
> Plus don't you need to record this for all policy->cpus instead of
> just policy->cpu ?
>
It will be accounted for all cpus in that freq domain. The
active_stats_cpu_freq_fast_change() implementation uses
a shared structure (single for whole domain) 'shared_ast':
_active_stats_cpu_freq_change(ast->shared_ast, freq, ts)
(from patch 1/4)
next prev parent reply other threads:[~2021-06-22 11:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 7:59 [RFC PATCH 0/4] Introduce Active Stats framework with CPU performance statistics Lukasz Luba
2021-06-22 7:59 ` [RFC PATCH 1/4] PM: Introduce Active Stats framework Lukasz Luba
2021-06-22 7:59 ` [RFC PATCH 2/4] cpuidle: Add Active Stats calls tracking idle entry/exit Lukasz Luba
2021-06-22 12:33 ` Rafael J. Wysocki
2021-06-22 13:58 ` Lukasz Luba
2021-06-22 14:44 ` Rafael J. Wysocki
2021-06-22 15:02 ` Lukasz Luba
2021-06-22 7:59 ` [RFC PATCH 3/4] cpufreq: Add Active Stats calls tracking frequency changes Lukasz Luba
2021-06-22 9:32 ` Viresh Kumar
2021-06-22 11:07 ` Lukasz Luba [this message]
2021-06-23 3:15 ` Viresh Kumar
2021-06-23 9:14 ` Lukasz Luba
2021-06-22 12:28 ` Rafael J. Wysocki
2021-06-22 13:42 ` Lukasz Luba
2021-06-22 13:51 ` Rafael J. Wysocki
2021-06-22 14:09 ` Lukasz Luba
2021-06-22 14:51 ` Rafael J. Wysocki
2021-06-22 14:59 ` Rafael J. Wysocki
2021-06-22 15:10 ` Lukasz Luba
2021-06-22 15:02 ` Lukasz Luba
2021-06-22 7:59 ` [RFC PATCH 4/4] thermal: cpufreq_cooling: Improve power estimation based on Active Stats framework Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5d5d6b8-f358-d1d6-86d0-750af76b0cfb@arm.com \
--to=lukasz.luba@arm.com \
--cc=Beata.Michalska@arm.com \
--cc=Chris.Redpath@arm.com \
--cc=amit.kachhap@gmail.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).