From: Chanwoo Choi <cw00.choi@samsung.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Rob Herring <robh+dt@kernel.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Sylwester Nawrocki <snawrocki@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v2 3/3] ARM: dts: exynos: align PPMU event node names with dtschema
Date: Thu, 23 Sep 2021 11:22:20 +0900 [thread overview]
Message-ID: <a7a4e1d3-77a7-a48e-4cbf-36cb06435e9c@samsung.com> (raw)
In-Reply-To: <20210920071753.38560-3-krzysztof.kozlowski@canonical.com>
Hi Krzysztof,
On 9/20/21 4:17 PM, Krzysztof Kozlowski wrote:
> Use hyphen instead of underscore and align the PPMU event node name with
> dtschema. The event-name property must match the node name, by the
> design of devfreq events and PPMU driver.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> arch/arm/boot/dts/exynos5420.dtsi | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index e23e8ffb093f..b2f30bea96ce 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -302,8 +302,8 @@ ppmu_dmc0_0: ppmu@10d00000 {
> clocks = <&clock CLK_PCLK_PPMU_DREX0_0>;
> clock-names = "ppmu";
> events {
> - ppmu_event3_dmc0_0: ppmu-event3-dmc0_0 {
> - event-name = "ppmu-event3-dmc0_0";
> + ppmu_event3_dmc0_0: ppmu-event3-dmc0-0 {
> + event-name = "ppmu-event3-dmc0-0";
> };
> };
> };
> @@ -314,8 +314,8 @@ ppmu_dmc0_1: ppmu@10d10000 {
> clocks = <&clock CLK_PCLK_PPMU_DREX0_1>;
> clock-names = "ppmu";
> events {
> - ppmu_event3_dmc0_1: ppmu-event3-dmc0_1 {
> - event-name = "ppmu-event3-dmc0_1";
> + ppmu_event3_dmc0_1: ppmu-event3-dmc0-1 {
> + event-name = "ppmu-event3-dmc0-1";
> };
> };
> };
> @@ -326,8 +326,8 @@ ppmu_dmc1_0: ppmu@10d60000 {
> clocks = <&clock CLK_PCLK_PPMU_DREX1_0>;
> clock-names = "ppmu";
> events {
> - ppmu_event3_dmc1_0: ppmu-event3-dmc1_0 {
> - event-name = "ppmu-event3-dmc1_0";
> + ppmu_event3_dmc1_0: ppmu-event3-dmc1-0 {
> + event-name = "ppmu-event3-dmc1-0";
> };
> };
> };
> @@ -338,8 +338,8 @@ ppmu_dmc1_1: ppmu@10d70000 {
> clocks = <&clock CLK_PCLK_PPMU_DREX1_1>;
> clock-names = "ppmu";
> events {
> - ppmu_event3_dmc1_1: ppmu-event3-dmc1_1 {
> - event-name = "ppmu-event3-dmc1_1";
> + ppmu_event3_dmc1_1: ppmu-event3-dmc1-1 {
> + event-name = "ppmu-event3-dmc1-1";
> };
> };
> };
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2021-09-23 2:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210920071554eucas1p195184c73f79e7bc12ea83cb43e14adc5@eucas1p1.samsung.com>
2021-09-20 7:15 ` [PATCH v2 0/3] devfreq: exynos-ppmu: conform to dt naming convention Krzysztof Kozlowski
2021-09-20 7:17 ` [PATCH v2 1/3] devfreq: exynos-ppmu: use node names with hyphens Krzysztof Kozlowski
2021-09-22 7:55 ` Chanwoo Choi
2021-09-20 7:17 ` [PATCH v2 2/3] devfreq: exynos-ppmu: simplify parsing event-type from DT Krzysztof Kozlowski
2021-09-22 8:05 ` Chanwoo Choi
2021-09-20 7:17 ` [PATCH v2 3/3] ARM: dts: exynos: align PPMU event node names with dtschema Krzysztof Kozlowski
2021-09-23 2:22 ` Chanwoo Choi [this message]
2022-02-18 13:18 ` (subset) " Krzysztof Kozlowski
2021-09-20 9:38 ` [PATCH v2 0/3] devfreq: exynos-ppmu: conform to dt naming convention Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7a4e1d3-77a7-a48e-4cbf-36cb06435e9c@samsung.com \
--to=cw00.choi@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
--cc=snawrocki@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).