From: Jon Hunter <jonathanh@nvidia.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Thierry Reding <thierry.reding@gmail.com>,
<linux-pm@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] cpufreq: tegra186: Fix initial frequency
Date: Tue, 25 Aug 2020 09:22:38 +0100 [thread overview]
Message-ID: <ab693b02-9ae2-48c2-0104-e82d949d82b7@nvidia.com> (raw)
In-Reply-To: <20200825055003.qfsuktsv7cyouxei@vireshk-i7>
On 25/08/2020 06:50, Viresh Kumar wrote:
> On 24-08-20, 15:59, Jon Hunter wrote:
>> Commit 6cc3d0e9a097 ("cpufreq: tegra186: add
>> CPUFREQ_NEED_INITIAL_FREQ_CHECK flag") fixed CPUFREQ support for
>> Tegra186 but as a consequence the following warnings are now seen on
>> boot ...
>>
>> cpufreq: cpufreq_online: CPU0: Running at unlisted freq: 0 KHz
>> cpufreq: cpufreq_online: CPU0: Unlisted initial frequency changed to: 2035200 KHz
>> cpufreq: cpufreq_online: CPU1: Running at unlisted freq: 0 KHz
>> cpufreq: cpufreq_online: CPU1: Unlisted initial frequency changed to: 2035200 KHz
>> cpufreq: cpufreq_online: CPU2: Running at unlisted freq: 0 KHz
>> cpufreq: cpufreq_online: CPU2: Unlisted initial frequency changed to: 2035200 KHz
>> cpufreq: cpufreq_online: CPU3: Running at unlisted freq: 0 KHz
>> cpufreq: cpufreq_online: CPU3: Unlisted initial frequency changed to: 2035200 KHz
>> cpufreq: cpufreq_online: CPU4: Running at unlisted freq: 0 KHz
>> cpufreq: cpufreq_online: CPU4: Unlisted initial frequency changed to: 2035200 KHz
>> cpufreq: cpufreq_online: CPU5: Running at unlisted freq: 0 KHz
>> cpufreq: cpufreq_online: CPU5: Unlisted initial frequency changed to: 2035200 KHz
>>
>> Fix this by adding a 'get' callback for the Tegra186 CPUFREQ driver to
>> retrieve the current operating frequency for a given CPU. The 'get'
>> callback uses the current 'ndiv' value that is programmed to determine
>> that current operating frequency.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>> Changes since V1:
>> - Moved code into a 'get' callback
>>
>> drivers/cpufreq/tegra186-cpufreq.c | 30 ++++++++++++++++++++++++++++++
>> 1 file changed, 30 insertions(+)
>>
>> diff --git a/drivers/cpufreq/tegra186-cpufreq.c b/drivers/cpufreq/tegra186-cpufreq.c
>> index 01e1f58ba422..0d0fcff60765 100644
>> --- a/drivers/cpufreq/tegra186-cpufreq.c
>> +++ b/drivers/cpufreq/tegra186-cpufreq.c
>> @@ -14,6 +14,7 @@
>>
>> #define EDVD_CORE_VOLT_FREQ(core) (0x20 + (core) * 0x4)
>> #define EDVD_CORE_VOLT_FREQ_F_SHIFT 0
>> +#define EDVD_CORE_VOLT_FREQ_F_MASK 0xffff
>> #define EDVD_CORE_VOLT_FREQ_V_SHIFT 16
>>
>> struct tegra186_cpufreq_cluster_info {
>> @@ -91,10 +92,39 @@ static int tegra186_cpufreq_set_target(struct cpufreq_policy *policy,
>> return 0;
>> }
>>
>> +static unsigned int tegra186_cpufreq_get(unsigned int cpu)
>> +{
>> + struct cpufreq_frequency_table *tbl;
>> + struct cpufreq_policy *policy;
>> + void __iomem *edvd_reg;
>> + unsigned int i, freq = 0;
>> + u32 ndiv;
>> +
>> + policy = cpufreq_cpu_get(cpu);
>> + if (!policy)
>> + return -EINVAL;
>
> This should be return 0;
>
> Applied with that change. Thanks.
OK, thanks!
Jon
--
nvpublic
next prev parent reply other threads:[~2020-08-25 8:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 14:59 [PATCH V2] cpufreq: tegra186: Fix initial frequency Jon Hunter
2020-08-25 5:50 ` Viresh Kumar
2020-08-25 8:22 ` Jon Hunter [this message]
2020-10-15 14:03 ` Jon Hunter
2020-10-16 4:07 ` Viresh Kumar
2020-10-19 9:33 ` Jon Hunter
2020-10-26 12:57 ` Jon Hunter
2020-10-28 4:11 ` Viresh Kumar
2020-10-28 12:31 ` Jon Hunter
2020-10-28 14:52 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab693b02-9ae2-48c2-0104-e82d949d82b7@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=thierry.reding@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).