From: "Kenneth R. Crudup" <kenny@panix.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Rafael Wysocki <rafael.j.wysocki@intel.com>,
Linux PM <linux-pm@vger.kernel.org>
Subject: Re: Help me fix a regression caused by 56b9918490 (PM: sleep: Simplify suspend-to-idle control flow)
Date: Sun, 24 Nov 2019 21:50:13 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.21.1911242140010.3858@hp-x360n> (raw)
In-Reply-To: <CAJZ5v0i2oC-w1RJ2X35fYyHdysorjLRYs-OBn+y_r6ksEZzVtg@mail.gmail.com>
On Sun, 24 Nov 2019, Rafael J. Wysocki wrote:
> Well, because you identified 56b991849 as the first bad commit, the
> following three lines of code in drivers/acpi/sleep.c are likely to be
> the source of the problem:
>
> acpi_os_wait_events_complete(); /* synchronize EC GPE processing */
> acpi_ec_flush_work();
> acpi_os_wait_events_complete(); /* synchronize Notify handling */
Huh- so this is encouraging- I've removed these lines, and while I haven't
been able to kill it yet (give me time :)) what DOES happen now is I get
wakeups from sleep on POWER events- charger connect (and disconnect)- and
now I wonder if this is somehow related to the issue of the suspend not
resuming if the machine is charging?
Are we masking out any events, perhaps?
-Kenny
--
Kenneth R. Crudup Sr. SW Engineer, Scott County Consulting, Silicon Valley
next prev parent reply other threads:[~2019-11-25 5:50 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 0:11 Help me fix a regression caused by 56b9918490 (PM: sleep: Simplify suspend-to-idle control flow) Kenneth R. Crudup
2019-11-22 10:12 ` Rafael J. Wysocki
2019-11-22 12:45 ` Rafael J. Wysocki
2019-11-22 17:35 ` Kenneth R. Crudup
2019-11-23 10:24 ` Kenneth R. Crudup
2019-11-24 16:02 ` Rafael J. Wysocki
2019-11-25 3:40 ` Kenneth R. Crudup
2019-11-25 13:27 ` Rafael J. Wysocki
2019-11-25 14:14 ` Rafael J. Wysocki
2019-11-25 18:27 ` Kenneth R. Crudup
2019-11-25 20:11 ` Kenneth R. Crudup
2019-11-25 20:19 ` Kenneth R. Crudup
2019-11-25 22:01 ` Rafael J. Wysocki
2019-11-25 23:32 ` Kenneth R. Crudup
2019-11-26 8:50 ` Rafael J. Wysocki
2019-11-26 16:12 ` Rafael J. Wysocki
2019-11-26 16:15 ` Kenneth R. Crudup
2019-11-26 16:27 ` Rafael J. Wysocki
2019-11-26 16:35 ` Kenneth R. Crudup
2019-11-26 18:48 ` Rafael J. Wysocki
2019-11-26 19:03 ` Kenneth R. Crudup
2019-11-26 19:09 ` Rafael J. Wysocki
2019-11-26 19:13 ` Kenneth R. Crudup
2019-11-26 19:45 ` Kenneth R. Crudup
2019-11-26 23:56 ` Kenneth R. Crudup
2019-11-27 2:35 ` Kenneth R. Crudup
2019-11-27 8:31 ` Rafael J. Wysocki
2019-11-27 22:30 ` Kenneth R. Crudup
2019-11-28 16:25 ` Rafael J. Wysocki
2019-11-25 21:47 ` Rafael J. Wysocki
2019-11-25 16:21 ` Kenneth R. Crudup
2019-11-25 21:46 ` Rafael J. Wysocki
2019-11-25 23:02 ` Kenneth R. Crudup
2019-11-26 8:53 ` Rafael J. Wysocki
2019-11-25 5:50 ` Kenneth R. Crudup [this message]
2019-11-25 7:17 ` Kenneth R. Crudup
2019-11-22 17:29 ` Kenneth R. Crudup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1911242140010.3858@hp-x360n \
--to=kenny@panix.com \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).